From: Markus Armbruster <armbru@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 2/6] monitor: accept chardev input from iothread
Date: Wed, 05 Dec 2018 09:17:06 +0100 [thread overview]
Message-ID: <87lg541j7h.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20181204131802.16885-3-marcandre.lureau@redhat.com> ("Marc-André Lureau"'s message of "Tue, 4 Dec 2018 17:17:58 +0400")
Marc-André Lureau <marcandre.lureau@redhat.com> writes:
> Chardev backends may not handle safely IO events from concurrent
> threads (they are not thread-safe in general, only the write path is
Suggest "may not handle I/O events from concurrent threads safely".
> since commit > 9005b2a7589540a3733b3abdcfbccfe7746cd1a1). Better to
> wake up the chardev from the monitor IO thread if it's being used as
> the chardev context.
>
> Unify code paths by using a BH in all cases.
>
> Drop the now redundant aio_notify() call.
>
> Simplify the condition, based on mon->use_io_thread (only QMP so far).
Suggest
Clean up control flow not to rely on mon->use_io_thread implying
monitor_is_qmp(mon).
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Peter Xu <peterx@redhat.com>
Happy to improve the commit message in my tree.
Preferably with commit message improvements:
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2018-12-05 8:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 13:17 [Qemu-devel] [PATCH v3 0/6] monitor: misc fixes Marc-André Lureau
2018-12-04 13:17 ` [Qemu-devel] [PATCH v3 1/6] monitor: inline ambiguous helper functions Marc-André Lureau
2018-12-04 13:17 ` [Qemu-devel] [PATCH v3 2/6] monitor: accept chardev input from iothread Marc-André Lureau
2018-12-05 8:17 ` Markus Armbruster [this message]
2018-12-05 8:41 ` Marc-André Lureau
2018-12-04 13:17 ` [Qemu-devel] [PATCH v3 3/6] char: add a QEMU_CHAR_FEATURE_GCONTEXT flag Marc-André Lureau
2018-12-05 8:37 ` Markus Armbruster
2018-12-04 13:18 ` [Qemu-devel] [PATCH v3 4/6] monitor: check if chardev can switch gcontext for OOB Marc-André Lureau
2018-12-05 8:42 ` Markus Armbruster
2018-12-05 8:54 ` Marc-André Lureau
2018-12-05 9:15 ` Markus Armbruster
2018-12-04 13:18 ` [Qemu-devel] [PATCH v3 5/6] monitor: prevent inserting new monitors after cleanup Marc-André Lureau
2018-12-05 8:45 ` Markus Armbruster
2018-12-04 13:18 ` [Qemu-devel] [PATCH v3 6/6] monitor: avoid potential dead-lock when cleaning up Marc-André Lureau
2018-12-05 8:46 ` Markus Armbruster
2018-12-05 12:37 ` [Qemu-devel] [PATCH v3 0/6] monitor: misc fixes Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg541j7h.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.