From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Rajkumar Manoharan <rmanohar@codeaurora.org>
Cc: linux-wireless-owner@vger.kernel.org,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [RFC v2 1/2] ath10k: migrate to mac80211 txq scheduling
Date: Tue, 02 Oct 2018 12:51:54 +0200 [thread overview]
Message-ID: <87lg7gei45.fsf@toke.dk> (raw)
In-Reply-To: <a944f87d1d94fd246f309cc62680a04b@codeaurora.org>
Rajkumar Manoharan <rmanohar@codeaurora.org> writes:
> On 2018-09-29 03:06, Toke Høiland-Jørgensen wrote:
>> Rajkumar Manoharan <rmanohar@codeaurora.org> writes:
>>
>>> - ath10k_htt_tx_txq_update(hw, f_txq);
>>> + if (ret == -EBUSY) {
>>> + ieee80211_txq_schedule_start(hw, ac);
>>> + ieee80211_return_txq(hw, txq);
>>> + ieee80211_txq_schedule_end(hw, ac);
>>> + }
>>
>> And ieee80211_return_txq() should be called regardless of the return
>> code (it'll do it's own checking and do nothing if the queue is empty).
>>
> Yeah.. Seems like calling return_txq unconditionally is messing with
> may_transmit sequence. i.e pull mode.
Messing with, how?
-Toke
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Rajkumar Manoharan <rmanohar@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-wireless-owner@vger.kernel.org
Subject: Re: [RFC v2 1/2] ath10k: migrate to mac80211 txq scheduling
Date: Tue, 02 Oct 2018 12:51:54 +0200 [thread overview]
Message-ID: <87lg7gei45.fsf@toke.dk> (raw)
In-Reply-To: <a944f87d1d94fd246f309cc62680a04b@codeaurora.org>
Rajkumar Manoharan <rmanohar@codeaurora.org> writes:
> On 2018-09-29 03:06, Toke Høiland-Jørgensen wrote:
>> Rajkumar Manoharan <rmanohar@codeaurora.org> writes:
>>
>>> - ath10k_htt_tx_txq_update(hw, f_txq);
>>> + if (ret == -EBUSY) {
>>> + ieee80211_txq_schedule_start(hw, ac);
>>> + ieee80211_return_txq(hw, txq);
>>> + ieee80211_txq_schedule_end(hw, ac);
>>> + }
>>
>> And ieee80211_return_txq() should be called regardless of the return
>> code (it'll do it's own checking and do nothing if the queue is empty).
>>
> Yeah.. Seems like calling return_txq unconditionally is messing with
> may_transmit sequence. i.e pull mode.
Messing with, how?
-Toke
next prev parent reply other threads:[~2018-10-02 10:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 23:16 [RFC v2 1/2] ath10k: migrate to mac80211 txq scheduling Rajkumar Manoharan
2018-09-28 23:16 ` Rajkumar Manoharan
2018-09-28 23:16 ` [RFC v2 2/2] ath10k: reporting estimated tx airtime for fairness Rajkumar Manoharan
2018-09-28 23:16 ` Rajkumar Manoharan
2018-09-29 10:06 ` [RFC v2 1/2] ath10k: migrate to mac80211 txq scheduling Toke Høiland-Jørgensen
2018-09-29 10:06 ` Toke Høiland-Jørgensen
2018-10-02 5:20 ` Rajkumar Manoharan
2018-10-02 5:20 ` Rajkumar Manoharan
2018-10-02 10:51 ` Toke Høiland-Jørgensen [this message]
2018-10-02 10:51 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg7gei45.fsf@toke.dk \
--to=toke@toke.dk \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.