From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.toke.dk ([2001:470:dc45:1000::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g7IHj-0002eX-0G for ath10k@lists.infradead.org; Tue, 02 Oct 2018 10:52:13 +0000 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [RFC v2 1/2] ath10k: migrate to mac80211 txq scheduling In-Reply-To: References: <1538176574-5580-1-git-send-email-rmanohar@codeaurora.org> <87k1n4botm.fsf@toke.dk> Date: Tue, 02 Oct 2018 12:51:54 +0200 Message-ID: <87lg7gei45.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Rajkumar Manoharan Cc: linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org UmFqa3VtYXIgTWFub2hhcmFuIDxybWFub2hhckBjb2RlYXVyb3JhLm9yZz4gd3JpdGVzOgoKPiBP biAyMDE4LTA5LTI5IDAzOjA2LCBUb2tlIEjDuGlsYW5kLUrDuHJnZW5zZW4gd3JvdGU6Cj4+IFJh amt1bWFyIE1hbm9oYXJhbiA8cm1hbm9oYXJAY29kZWF1cm9yYS5vcmc+IHdyaXRlczoKPj4gCj4+ PiAtCWF0aDEwa19odHRfdHhfdHhxX3VwZGF0ZShodywgZl90eHEpOwo+Pj4gKwlpZiAocmV0ID09 IC1FQlVTWSkgewo+Pj4gKwkJaWVlZTgwMjExX3R4cV9zY2hlZHVsZV9zdGFydChodywgYWMpOwo+ Pj4gKwkJaWVlZTgwMjExX3JldHVybl90eHEoaHcsIHR4cSk7Cj4+PiArCQlpZWVlODAyMTFfdHhx X3NjaGVkdWxlX2VuZChodywgYWMpOwo+Pj4gKwl9Cj4+IAo+PiBBbmQgaWVlZTgwMjExX3JldHVy bl90eHEoKSBzaG91bGQgYmUgY2FsbGVkIHJlZ2FyZGxlc3Mgb2YgdGhlIHJldHVybgo+PiBjb2Rl IChpdCdsbCBkbyBpdCdzIG93biBjaGVja2luZyBhbmQgZG8gbm90aGluZyBpZiB0aGUgcXVldWUg aXMgZW1wdHkpLgo+PiAKPiBZZWFoLi4gU2VlbXMgbGlrZSBjYWxsaW5nIHJldHVybl90eHEgdW5j b25kaXRpb25hbGx5IGlzIG1lc3Npbmcgd2l0aAo+IG1heV90cmFuc21pdCBzZXF1ZW5jZS4gaS5l IHB1bGwgbW9kZS4KCk1lc3Npbmcgd2l0aCwgaG93PwoKLVRva2UKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBr QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D442C43143 for ; Tue, 2 Oct 2018 10:51:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECEC4205C9 for ; Tue, 2 Oct 2018 10:51:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toke.dk header.i=@toke.dk header.b="QorpQTvu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECEC4205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=toke.dk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727160AbeJBReh (ORCPT ); Tue, 2 Oct 2018 13:34:37 -0400 Received: from mail.toke.dk ([52.28.52.200]:59285 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726244AbeJBReh (ORCPT ); Tue, 2 Oct 2018 13:34:37 -0400 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1538477515; bh=sA0zaNHwZmiBG/g3dwxDP+jTmjkTFLi/yADeRHiDBtg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=QorpQTvuk8sNsBeedccksNtpam0RKSq60OrG9XpHNq8HIhEbRRN+oWxOnjUrX0kGn iVoC1kzXD4saupcGNIJnyfWMbFHnf3IO84WUONW7fw2zq+b2V3SnnosZ5puoJ3KZ75 ngnR6pDJerrVCslp+KTZdNGNqAeU/tbkifls4FIEe6HNhJMCrRvYit8RRWcLkimfwE pN6aG5ptUbr64LuDlmqo/m/ELJLHCuPhqeQuWjLTsk1R3k/AK8IHzw473nhEiN3I4e VcuYuqyZCFZNEQy0UFlL77s4uIB8f+dWIsAPTVnCq3AOrbuhoG6nZ+NHXI0V2vw4Eg WJuCrALzVqOaQ== To: Rajkumar Manoharan Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org Subject: Re: [RFC v2 1/2] ath10k: migrate to mac80211 txq scheduling In-Reply-To: References: <1538176574-5580-1-git-send-email-rmanohar@codeaurora.org> <87k1n4botm.fsf@toke.dk> Date: Tue, 02 Oct 2018 12:51:54 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87lg7gei45.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Rajkumar Manoharan writes: > On 2018-09-29 03:06, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> Rajkumar Manoharan writes: >>=20 >>> - ath10k_htt_tx_txq_update(hw, f_txq); >>> + if (ret =3D=3D -EBUSY) { >>> + ieee80211_txq_schedule_start(hw, ac); >>> + ieee80211_return_txq(hw, txq); >>> + ieee80211_txq_schedule_end(hw, ac); >>> + } >>=20 >> And ieee80211_return_txq() should be called regardless of the return >> code (it'll do it's own checking and do nothing if the queue is empty). >>=20 > Yeah.. Seems like calling return_txq unconditionally is messing with > may_transmit sequence. i.e pull mode. Messing with, how? -Toke