All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: <linux-kernel@vger.kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH 0/4] signal: Cleanups
Date: Sun, 16 Sep 2018 20:04:05 +0200	[thread overview]
Message-ID: <87lg81pbe2.fsf@xmission.com> (raw)
In-Reply-To: <87musyl3fa.fsf@xmission.com> (Eric W. Biederman's message of "Mon, 03 Sep 2018 22:41:13 +0200")


What follows are some small cleanups to signal handling functions that
arose from my previous work on sorting out signals during fork.

There are two cases where I did not previously mark functions
that sent signals to a group of processes.  It was safe because
they sent SIGKILL but it is still a good idea to mark that they send
signals to a group of processes to be consistent.

After that I just have the trivial cleanups of removing
specific_send_sig_info which confuses more than helps when I read the
code, and moving the exports of signal functions next to their
callers so that future cleanups are easier.

On my wish list is to continue this work and ensure all of the signal
sending functions are being used correctly and to reduce the set of
signal sending functions so that there is less confusion in how to use
them.

I took a quick look at limiting force_sig to only the callers
that use it to transmit a synchronous exception.  Unfortunately I
discovered that where there is one small bug there are others so those
use cases need something more than a brainless mass conversion to fix.

So I am first going to focus on finishing on cleaning up the signal
sending functions for exceptions that send siginfo.  I have just a few
architectures left and I just need to double check that I didn't do
anything stupid and post those changes for review.

If anyone sees any issues with these patches let me know.  Otherwise I
am going to merge them into my siginfo tree.

Eric W. Biederman (4):
      tty_io: Use group_send_sig_info in __do_SACK to note it is a session being killed
      signal: Use group_send_sig_info to kill all processes in a pid namespace
      signal: Remove specific_send_sig_info
      signal: Pair exports with their functions

 drivers/tty/tty_io.c   |  6 +++---
 kernel/pid_namespace.c |  2 +-
 kernel/signal.c        | 25 +++++++++----------------
 3 files changed, 13 insertions(+), 20 deletions(-)

Eric

  parent reply	other threads:[~2018-09-16 18:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03 20:41 [PATCH 00/10] Removing SEND_SIG_FORCED Eric W. Biederman
2018-09-03 20:41 ` Eric W. Biederman
2018-09-03 20:44 ` [PATCH 01/10] signal: Always ignore SIGKILL and SIGSTOP sent to the global init Eric W. Biederman
2018-09-03 20:44 ` [PATCH 02/10] signal: Properly deliver SIGILL from uprobes Eric W. Biederman
2018-09-03 20:44 ` [PATCH 03/10] signal: Properly deliver SIGSEGV from x86 uprobes Eric W. Biederman
2018-09-03 20:44 ` [PATCH 04/10] signal: Always deliver the kernel's SIGKILL and SIGSTOP to a pid namespace init Eric W. Biederman
2018-09-03 20:44 ` [PATCH 05/10] signal: send_sig_all no longer needs SEND_SIG_FORCED Eric W. Biederman
2018-09-03 20:44 ` [PATCH 06/10] signal: Remove the siginfo paramater from kernel_dqueue_signal Eric W. Biederman
2018-09-03 20:44 ` [PATCH 07/10] signal: Don't send siginfo to kthreads Eric W. Biederman
2018-09-03 20:44 ` [PATCH 08/10] signal: Never allocate siginfo for SIGKILL or SIGSTOP Eric W. Biederman
2018-09-03 20:44 ` [PATCH 09/10] signal: Use SEND_SIG_PRIV not SEND_SIG_FORCED with SIGKILL and SIGSTOP Eric W. Biederman
2018-09-03 20:44 ` [PATCH 10/10] signal: Remove SEND_SIG_FORCED Eric W. Biederman
2018-09-08 11:03 ` [PATCH 00/10] Removing SEND_SIG_FORCED Thomas Gleixner
2018-09-16 18:04 ` Eric W. Biederman [this message]
2018-09-16 18:04   ` [PATCH 1/4] tty_io: Use group_send_sig_info in __do_SACK to note it is a session being killed Eric W. Biederman
2018-09-16 18:05   ` [PATCH 2/4] signal: Use group_send_sig_info to kill all processes in a pid namespace Eric W. Biederman
2018-09-16 18:06   ` [PATCH 3/4] signal: Remove specific_send_sig_info Eric W. Biederman
2018-09-16 18:06   ` [PATCH 4/4] signal: Pair exports with their functions Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lg81pbe2.fsf@xmission.com \
    --to=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.