From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fZJjj-0001Yb-J8 for ath10k@lists.infradead.org; Sat, 30 Jun 2018 17:32:41 +0000 From: Kalle Valo Subject: Re: [v2] ath10k: Update the phymode along with bandwidth change request References: <1528482759-12604-1-git-send-email-ryanhsu@codeaurora.org> <20180628092800.6517B608C8@smtp.codeaurora.org> <45265cf5224d8d5e12e2eddc8968a879008657e5.camel@gmail.com> Date: Sat, 30 Jun 2018 20:32:22 +0300 In-Reply-To: <45265cf5224d8d5e12e2eddc8968a879008657e5.camel@gmail.com> ("Timur \=\?utf-8\?Q\?Krist\=C3\=B3f\=22's\?\= message of "Sat, 30 Jun 2018 15:56:33 +0200") Message-ID: <87lgawdvtl.fsf@codeaurora.org> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Timur =?utf-8?Q?Krist=C3=B3f?= Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, Ryan Hsu VGltdXIgS3Jpc3TDs2YgPHRpbXVyLmtyaXN0b2ZAZ21haWwuY29tPiB3cml0ZXM6Cgo+IE9uIFRo dSwgMjAxOC0wNi0yOCBhdCAwOToyOCArMDAwMCwgS2FsbGUgVmFsbyB3cm90ZToKPj4gUnlhbiBI c3UgPHJ5YW5oc3VAY29kZWF1cm9yYS5vcmc+IHdyb3RlOgo+PiAKPj4gPiBJbiB0aGUgY2FzZSBv ZiBTdGF0aW9uIGNvbm5lY3RzIHRvIEFQIHdpdGggbmFycm93ZXIgYmFuZHdpZHRoIGF0Cj4+ID4g YmVnaW5uaW5nLgo+PiA+IEFuZCBsYXRlciB0aGUgQVAgY2hhbmdlcyB0aGUgYmFuZHdpZHRoIHRv IHdpbmRlciBiYW5kd2lkdGgsIHRoZSBBUAo+PiA+IHdpbGwKPj4gPiBiZWFjb24gd2l0aCB3aWRl ciBiYW5kd2lkdGggSUUsIGVnIFZIVDIwLT5WSFQ0MC0+VkhUODAgb3IgVkhUNDAtCj4+ID4gPlZI VDgwLgo+PiA+IAo+PiA+IFNpbmNlIHRoZSBzdXBwb3J0ZWQgQkFORFdJRFRIIHdpbGwgYmUgbGlt aXRlZCBieSB0aGUgUEhZTU9ERSwgc28KPj4gPiB3aGlsZQo+PiA+IFN0YXRpb24gcmVjZWl2ZXMg dGhlIGJhbmR3aWR0aCBjaGFuZ2UgcmVxdWVzdCwgaXQgd2lsbCBhbHNvIG5lZWQgdG8KPj4gPiBy ZWNvbmZpZ3VyZSB0aGUgUEhZTU9ERSBzZXR0aW5nIHRvIGZpcm13YXJlIGluc3RlYWQgb2YganVz dAo+PiA+IGNvbmZpZ3VyaW5nCj4+ID4gdGhlIEJBTkRXSURUSCBpbmZvLCBvdGhlcndpc2UgaXQn bGwgdHJpZ2dlciBhIGZpcm13YXJlIGNyYXNoIHdpdGgKPj4gPiBub24tc3VwcG9ydCBiYW5kd2lk dGguCj4+ID4gCj4+ID4gVGhlIGlzc3VlIHdhcyBvYnNlcnZlZCBpbiBXTEFOLlJNLjQuNC4xLTAw MDUxLVFDQVJNU1dQLTEsIFFDQTYxNzQKPj4gPiB3aXRoCj4+ID4gYmVsb3cgc2NlbmFyaW86Cj4+ ID4gCj4+ID4gQVAgeHh4IGNoYW5nZWQgYmFuZHdpZHRoLCBuZXcgY29uZmlnIGlzIDUyMDAgTUh6 LCB3aWR0aCAyICg1MTkwLzAKPj4gPiBNSHopCj4+ID4gZGlzY29ubmVjdCBmcm9tIEFQIHh4eCBm b3IgbmV3IGF1dGggdG8geXl5Cj4+ID4gUlggUmVhc3NvY1Jlc3AgZnJvbSB4eHggKGNhcGFiPTB4 MTExMSBzdGF0dXM9MCBhaWQ9MTAyKQo+PiA+IGFzc29jaWF0ZWQKPj4gPiAKPj4gPiAuLi4uCj4+ ID4gCj4+ID4gQVAgeHh4IGNoYW5nZWQgYmFuZHdpZHRoLCBuZXcgY29uZmlnIGlzIDUyMDAgTUh6 LCB3aWR0aCAyICg1MTkwLzAKPj4gPiBNSHopCj4+ID4gQVAgeHh4IGNoYW5nZWQgYmFuZHdpZHRo LCBuZXcgY29uZmlnIGlzIDUyMDAgTUh6LCB3aWR0aCAzICg1MjEwLzAKPj4gPiBNSHopCj4+ID4g Cj4+ID4gLi4uLgo+PiA+IAo+PiA+IGZpcm13YXJlIHJlZ2lzdGVyIGR1bXA6Cj4+ID4gWzAwXTog MHgwNTAzMDAwMCAweDAwMDAxNUIzIDB4MDA5ODcyOTEgMHgwMDk1NUIzMQo+PiA+IFswNF06IDB4 MDA5ODcyOTEgMHgwMDA2MDczMCAweDAwMDAwMDA0IDB4MDAwMDAwMDEKPj4gPiBbMDhdOiAweDAw NDA4OUYwIDB4MDA5NTVBMDAgMHgwMDBBMEIwMCAweDAwNDAwMDAwCj4+ID4gWzEyXTogMHgwMDAw MDAwOSAweDAwMDAwMDAwIDB4MDA5NTJDRDAgMHgwMDk1MkNFNgo+PiA+IFsxNl06IDB4MDA5NTJD QzQgMHgwMDk4RTI1RiAweDAwMDAwMDAwIDB4MDA5MTA4MEQKPj4gPiBbMjBdOiAweDQwOTg3Mjkx IDB4MDA0MEU3QTggMHgwMDAwMDAwMCAweDAwNDFFRTNDCj4+ID4gWzI0XTogMHg4MDlBQkYwNSAw eDAwNDBFODA4IDB4MDAwMDAwMDAgMHhDMDk4NzI5MQo+PiA+IFsyOF06IDB4ODA5QTY1MEMgMHgw MDQwRTk0OCAweDAwNDFGRTQwIDB4MDA0MzQ1QzQKPj4gPiBbMzJdOiAweDgwOUE1QzYzIDB4MDA0 MEU5ODggMHgwMDQwRTlBQyAweDAwNDJEMUE4Cj4+ID4gWzM2XTogMHg4MDkxRDI1MiAweDAwNDBF OUE4IDB4MDAwMDAwMDIgMHgwMDAwMDAwMQo+PiA+IFs0MF06IDB4ODA5RkRBOUQgMHgwMDQwRUE1 OCAweDAwNDNENTU0IDB4MDA0MkQ1NTQKPj4gPiBbNDRdOiAweDgwOUY4QjIyIDB4MDA0MEVBNzgg MHgwMDQzRDU1NCAweDAwMDAwMDAxCj4+ID4gWzQ4XTogMHg4MDkxMTIxMCAweDAwNDBFQUM4IDB4 MDAwMDAwMTAgMHgwMDQwNDFEMAo+PiA+IFs1Ml06IDB4ODA5MTExNTQgMHgwMDQwRUIyOCAweDAw NDAwMDAwIDB4MDAwMDAwMDAKPj4gPiBbNTZdOiAweDgwOTExMjJEIDB4MDA0MEVCNDggMHgwMDAw MDAwMCAweDAwNDAwNjAwCj4+ID4gCj4+ID4gUmVwb3J0ZWQtYnk6IFJvdXZlbiBDemVyd2luc2tp IDxyb3V2ZW5AY3plcndpbnNraXMuZGU+Cj4+ID4gVGVzdGVkLWJ5OiBUaW11ciBLcmlzdMOzZiA8 dGltdXIua3Jpc3RvZkBnbWFpbC5jb20+Cj4+ID4gU2lnbmVkLW9mZi1ieTogUnlhbiBIc3UgPHJ5 YW5oc3VAY29kZWF1cm9yYS5vcmc+Cj4+ID4gU2lnbmVkLW9mZi1ieTogS2FsbGUgVmFsbyA8a3Zh bG9AY29kZWF1cm9yYS5vcmc+Cj4+IAo+PiBQYXRjaCBhcHBsaWVkIHRvIGF0aC1jdXJyZW50IGJy YW5jaCBvZiBhdGguZ2l0LCB0aGFua3MuCj4+IAo+PiA5MTkxZmMyYTQzMWIgYXRoMTBrOiB1cGRh dGUgdGhlIHBoeW1vZGUgYWxvbmcgd2l0aCBiYW5kd2lkdGggY2hhbmdlCj4+IHJlcXVlc3QKPgo+ IFRoYW5rIHlvdSBLYWxsZS4KPiBEb2VzIHRoaXMgbWVhbiB0aGF0IHRoZSBwYXRjaCB3aWxsIGdl dCBpbnRvIGtlcm5lbCA0LjE4PwoKWWVzLCBpZiBhbGwgZ29lcyB3ZWxsLiBCdXQgaXQgbWlnaHQg dGFrZSBhIHdlZWsgb3IgdHdvIGJlZm9yZSBpdCByZWFjaGVzCkxpbnVzJyB0cmVlIGFzIEkgc3Vi bWl0IHBhdGNoZXMgdG8gbmV0IHRyZWUuCgotLSAKS2FsbGUgVmFsbwoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRoMTBrIG1haWxpbmcgbGlzdAphdGgx MGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:45554 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460AbeF3Rc3 (ORCPT ); Sat, 30 Jun 2018 13:32:29 -0400 From: Kalle Valo To: Timur =?utf-8?Q?Krist=C3=B3f?= Cc: Ryan Hsu , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [v2] ath10k: Update the phymode along with bandwidth change request References: <1528482759-12604-1-git-send-email-ryanhsu@codeaurora.org> <20180628092800.6517B608C8@smtp.codeaurora.org> <45265cf5224d8d5e12e2eddc8968a879008657e5.camel@gmail.com> Date: Sat, 30 Jun 2018 20:32:22 +0300 In-Reply-To: <45265cf5224d8d5e12e2eddc8968a879008657e5.camel@gmail.com> ("Timur \=\?utf-8\?Q\?Krist\=C3\=B3f\=22's\?\= message of "Sat, 30 Jun 2018 15:56:33 +0200") Message-ID: <87lgawdvtl.fsf@codeaurora.org> (sfid-20180630_193241_312389_22DCF1D0) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Timur Krist=C3=B3f writes: > On Thu, 2018-06-28 at 09:28 +0000, Kalle Valo wrote: >> Ryan Hsu wrote: >>=20 >> > In the case of Station connects to AP with narrower bandwidth at >> > beginning. >> > And later the AP changes the bandwidth to winder bandwidth, the AP >> > will >> > beacon with wider bandwidth IE, eg VHT20->VHT40->VHT80 or VHT40- >> > >VHT80. >> >=20 >> > Since the supported BANDWIDTH will be limited by the PHYMODE, so >> > while >> > Station receives the bandwidth change request, it will also need to >> > reconfigure the PHYMODE setting to firmware instead of just >> > configuring >> > the BANDWIDTH info, otherwise it'll trigger a firmware crash with >> > non-support bandwidth. >> >=20 >> > The issue was observed in WLAN.RM.4.4.1-00051-QCARMSWP-1, QCA6174 >> > with >> > below scenario: >> >=20 >> > AP xxx changed bandwidth, new config is 5200 MHz, width 2 (5190/0 >> > MHz) >> > disconnect from AP xxx for new auth to yyy >> > RX ReassocResp from xxx (capab=3D0x1111 status=3D0 aid=3D102) >> > associated >> >=20 >> > .... >> >=20 >> > AP xxx changed bandwidth, new config is 5200 MHz, width 2 (5190/0 >> > MHz) >> > AP xxx changed bandwidth, new config is 5200 MHz, width 3 (5210/0 >> > MHz) >> >=20 >> > .... >> >=20 >> > firmware register dump: >> > [00]: 0x05030000 0x000015B3 0x00987291 0x00955B31 >> > [04]: 0x00987291 0x00060730 0x00000004 0x00000001 >> > [08]: 0x004089F0 0x00955A00 0x000A0B00 0x00400000 >> > [12]: 0x00000009 0x00000000 0x00952CD0 0x00952CE6 >> > [16]: 0x00952CC4 0x0098E25F 0x00000000 0x0091080D >> > [20]: 0x40987291 0x0040E7A8 0x00000000 0x0041EE3C >> > [24]: 0x809ABF05 0x0040E808 0x00000000 0xC0987291 >> > [28]: 0x809A650C 0x0040E948 0x0041FE40 0x004345C4 >> > [32]: 0x809A5C63 0x0040E988 0x0040E9AC 0x0042D1A8 >> > [36]: 0x8091D252 0x0040E9A8 0x00000002 0x00000001 >> > [40]: 0x809FDA9D 0x0040EA58 0x0043D554 0x0042D554 >> > [44]: 0x809F8B22 0x0040EA78 0x0043D554 0x00000001 >> > [48]: 0x80911210 0x0040EAC8 0x00000010 0x004041D0 >> > [52]: 0x80911154 0x0040EB28 0x00400000 0x00000000 >> > [56]: 0x8091122D 0x0040EB48 0x00000000 0x00400600 >> >=20 >> > Reported-by: Rouven Czerwinski >> > Tested-by: Timur Krist=C3=B3f >> > Signed-off-by: Ryan Hsu >> > Signed-off-by: Kalle Valo >>=20 >> Patch applied to ath-current branch of ath.git, thanks. >>=20 >> 9191fc2a431b ath10k: update the phymode along with bandwidth change >> request > > Thank you Kalle. > Does this mean that the patch will get into kernel 4.18? Yes, if all goes well. But it might take a week or two before it reaches Linus' tree as I submit patches to net tree. --=20 Kalle Valo