All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org
Cc: Boris Brezillon <boris.brezillon@bootlin.com>,
	Liviu Dudau <Liviu.Dudau@arm.com>
Subject: Re: [PATCH v2 3/8] drm/vc4: Use wait_for_flip_done() instead of wait_for_vblanks()
Date: Fri, 29 Jun 2018 13:19:16 -0700	[thread overview]
Message-ID: <87lgaxny63.fsf@anholt.net> (raw)
In-Reply-To: <20180629111722.20299-4-boris.brezillon@bootlin.com>


[-- Attachment #1.1: Type: text/plain, Size: 970 bytes --]

Boris Brezillon <boris.brezillon@bootlin.com> writes:

> drm_atomic_helper_wait_for_vblanks() assumes the CRTC will continuously
> generate VBLANK events and the vblank counter will keep increasing.
> While this work for a regular pipeline, it doesn't when you have the
> CRTC is feeding the transposer block, because this block works in
> oneshot mode, and, by the time we reach
> drm_atomic_helper_wait_for_vblanks() the only VBLANK event might have
> already been sent and the VBLANK counter will stay unchanged, thus
> triggering a timeout.
>
> Luckily, we can replace the drm_atomic_helper_wait_for_vblanks() call
> by drm_atomic_helper_wait_for_flip_done() because the only thing we
> want to check when calling drm_atomic_helper_wait_for_vblanks() from
> vc4_atomic_complete_commit() is that new FBs are in use and the old
> ones can be safely released.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>

Reviewed-by: Eric Anholt <eric@anholt.net>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-06-29 20:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-29 11:17 [PATCH v2 0/8] drm/vc4: Add support for the transposer IP Boris Brezillon
2018-06-29 11:17 ` [PATCH v2 1/8] drm/atomic: Avoid connector to writeback_connector casts Boris Brezillon
2018-07-02  7:49   ` Daniel Vetter
2018-06-29 11:17 ` [PATCH v2 2/8] drm/connector: Pass a drm_connector_state to ->atomic_commit() Boris Brezillon
2018-06-29 11:23   ` Liviu Dudau
2018-06-29 11:37   ` Liviu Dudau
2018-07-02  7:51     ` Daniel Vetter
2018-07-02  9:49       ` Boris Brezillon
2018-07-02 11:14         ` Liviu Dudau
2018-07-02 11:58           ` Boris Brezillon
2018-06-29 11:17 ` [PATCH v2 3/8] drm/vc4: Use wait_for_flip_done() instead of wait_for_vblanks() Boris Brezillon
2018-06-29 20:19   ` Eric Anholt [this message]
2018-06-29 11:17 ` [PATCH v2 4/8] drm/crtc: Add a generic infrastructure to fake VBLANK events Boris Brezillon
2018-06-29 11:38   ` Liviu Dudau
2018-07-02  8:02   ` Daniel Vetter
2018-07-02  8:14     ` Boris Brezillon
2018-07-02  8:37       ` Daniel Vetter
2018-07-02  9:01         ` Boris Brezillon
2018-07-02  8:40       ` Daniel Vetter
2018-07-02  8:46         ` Boris Brezillon
2018-06-29 11:17 ` [PATCH v2 5/8] drm/atomic: Call drm_atomic_helper_fake_vblank() from the generic commit_tail() helpers Boris Brezillon
2018-06-29 11:38   ` Liviu Dudau
2018-07-02  7:54   ` Daniel Vetter
2018-07-02  7:57     ` Daniel Vetter
2018-07-02  7:59       ` Boris Brezillon
2018-07-02  7:58     ` Boris Brezillon
2018-06-29 11:17 ` [PATCH v2 6/8] drm/vc4: Call drm_atomic_helper_fake_vblank() in the commit path Boris Brezillon
2018-06-29 20:27   ` Eric Anholt
2018-06-29 11:17 ` [PATCH v2 7/8] drm/vc4: Add support for the transposer block Boris Brezillon
2018-06-29 20:35   ` Eric Anholt
2018-07-02 10:19     ` Boris Brezillon
2018-06-29 11:17 ` [PATCH v2 8/8] ARM: dts: bcm283x: Add Transposer block Boris Brezillon
2018-06-29 20:27   ` Eric Anholt
2018-06-29 11:17 ` [PATCH v2 0/8] drm/vc4: Add support for the transposer IP Boris Brezillon
2018-06-29 11:40   ` Liviu Dudau
2018-07-02 10:21     ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgaxny63.fsf@anholt.net \
    --to=eric@anholt.net \
    --cc=Liviu.Dudau@arm.com \
    --cc=airlied@linux.ie \
    --cc=boris.brezillon@bootlin.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.