From mboxrd@z Thu Jan 1 00:00:00 1970 From: eric@anholt.net (Eric Anholt) Date: Thu, 21 Jun 2018 13:00:41 -0700 Subject: [PATCH] drm/pl111: Support Nomadik LCDC variant In-Reply-To: <20180621184450.25377-1-linus.walleij@linaro.org> References: <20180621184450.25377-1-linus.walleij@linaro.org> Message-ID: <87lgb79afq.fsf@anholt.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Linus Walleij writes: > The Nomadik has a variant of the PL110 known as "Color LCD > Controller" LCDC. This variant has the same bit ordering as > the DRM subsystem (in difference from the other variants) > and adds a few bits for the control of 5551, 565 etc in the > control register. Notably it also adds a packed RGB888 > 24BPP mode. > > We add support by detecting this variant and also adding a > small plug-in that will mux the LCDC out if the ASIC happens > to be muxed to the other graphics controller (they are > mutually exclusive). This all looks reasonable to me. Reviewed-by: Eric Anholt -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 832 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] drm/pl111: Support Nomadik LCDC variant Date: Thu, 21 Jun 2018 13:00:41 -0700 Message-ID: <87lgb79afq.fsf@anholt.net> References: <20180621184450.25377-1-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0582392024==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 017B16E949 for ; Thu, 21 Jun 2018 20:00:44 +0000 (UTC) In-Reply-To: <20180621184450.25377-1-linus.walleij@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Linus Walleij , Gustavo Padovan , Maarten Lankhorst , Sean Paul , Liviu Dudau Cc: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0582392024== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Linus Walleij writes: > The Nomadik has a variant of the PL110 known as "Color LCD > Controller" LCDC. This variant has the same bit ordering as > the DRM subsystem (in difference from the other variants) > and adds a few bits for the control of 5551, 565 etc in the > control register. Notably it also adds a packed RGB888 > 24BPP mode. > > We add support by detecting this variant and also adding a > small plug-in that will mux the LCDC out if the ASIC happens > to be muxed to the other graphics controller (they are > mutually exclusive). This all looks reasonable to me. Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlssA+kACgkQtdYpNtH8 nujikxAAls5xvLJ8XHE7533W2N1JQw8q8TL8A9LHs8SJOrVt6AQTGjnAJQPjLigp +NnmsI56Wq2IXTevWrD9qcA7FMYuxdJYwOabtJlgCmrnSKYJy5IbikSeS4TAly9V 9TTpBEW8WZxFFZbD7+wXw4NWocxxhlYa7shhj5hb/p6koixc+QLLxlPzi7cben4p iW13hlO9aNnJ2ZLZ8XtNwktMkPQCEnhkS7YBW6mGbUSTUj7arEYlgkZ82BrppO/d t8SlpCmCTPHBBi3qGTmp5ig4RFTpRpGmNeMgP/Ti56l+pBmFvirG12EFx611apMp sPIsh25fvAHL3elnE9k5/P31w+vE53AyKXFEXYMsg9iS2YBp1f8/UNRFI60eLUEm FylUJWQAvcRG/2tqZTtXsL3jWwDVBnIL8Zexr5AS5QRSONzYgTXLmqzBG0+YTtkE b00qwXoD2yihG4NCMMm8lnGWaAW5rWqpV8e9qtuf0iqxyW2WAx67cc6HL+m/oEGO fhfsg66/yqDF5fxGU6gyKLtK7UiqAFpMa9SHPGyHVew/z7mUWQWMvcPN7oQ90cQV pNiPg2wSb1Ms1Do6sZXGQDUt4hqsEMNw8UVHu/vQfT3JTmtfwGIA6ppjgh9DYqDc DcajZA68j1/rvEMbLJDMjPoznKMNgnamqSO273cxL4svkzAF1Jg= =rR1v -----END PGP SIGNATURE----- --=-=-=-- --===============0582392024== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0582392024==--