From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, jdenemar@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 for 2.13] migration: Don't activate block devices if using -S
Date: Mon, 04 Jun 2018 05:56:07 +0200 [thread overview]
Message-ID: <87lgbv8aso.fsf@secure.laptop> (raw)
In-Reply-To: <20180416170930.35504-1-dgilbert@redhat.com> (David Alan Gilbert's message of "Mon, 16 Apr 2018 18:09:30 +0100")
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Activating the block devices causes the locks to be taken on
> the backing file. If we're running with -S and the destination libvirt
> hasn't started the destination with 'cont', it's expecting the locks are
> still untaken.
>
> Don't activate the block devices if we're not going to autostart the VM;
> 'cont' already will do that anyway. This change is tied to the new
> migration capability 'late-block-activate' that defaults to off, keeping
> the old behaviour by default.
>
> bz: https://bugzilla.redhat.com/show_bug.cgi?id=1560854
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
prev parent reply other threads:[~2018-06-04 3:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 17:09 [Qemu-devel] [PATCH v2 for 2.13] migration: Don't activate block devices if using -S Dr. David Alan Gilbert (git)
2018-04-30 14:15 ` Juan Quintela
2018-06-04 3:56 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgbv8aso.fsf@secure.laptop \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jdenemar@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.