From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH 3/7] drm/i915: Nuke intel_trans_dp_port_sel()
Date: Wed, 23 May 2018 12:26:11 +0300
Message-ID: <87lgcan2oc.fsf@intel.com>
References: <20180518152931.13104-1-ville.syrjala@linux.intel.com>
 <20180518152931.13104-3-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 9DB3E6E3F8
 for <intel-gfx@lists.freedesktop.org>; Wed, 23 May 2018 09:22:14 +0000 (UTC)
In-Reply-To: <20180518152931.13104-3-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCAxOCBNYXkgMjAxOCwgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5p
bnRlbC5jb20+IHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs
aW51eC5pbnRlbC5jb20+Cj4KPiBmb3JfZWFjaF9lbmNvZGVyX29uX2NydGMoKSBpcyBsZWdhY3kg
YW5kIHNob3VsZG4ndCBiZSB1c2VkIGJ5IGF0b21pYwo+IGRyaXZlcnMuIExldCdzIHRocm93IG91
dCBpbnRlbF90cmFuc19kcF9wb3J0X3NlbCgpIGFuZCByZXBsYWNlIGl0Cj4gd2l0aCBpbnRlbF9n
ZXRfY3J0Y19uZXdfZW5jb2RlcigpIHdoaWNoIGxvb2tzIHRoZSBhdG9taWMgc3RhdGUgaW5zdGVh
ZC4KPgo+IFNpbmNlIHdlIG5vdyBoYXZlIHRvIGNhbGwgaW50ZWxfZ2V0X2NydGNfbmV3X2VuY29k
ZXIoKSBkdXJpbmcgdGhlIGNvbW1pdAo+IHBoYXNlIHdlJ2xsIG5lZWQgdG8gcGx1bWIgaW4gdGhl
IHRvcCBsZXZlbCBhdG9taWMgc3RhdGUuIFRoZQo+IGNydGNfc3RhdGUtPnN0YXRlIHBvaW50ZXJz
IGFyZSBubyBsb25nZXIgdmFsaWQgYXQgdGhhdCBwb2ludC4KPgo+IFNpZ25lZC1vZmYtYnk6IFZp
bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRy
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDM5ICsrKysrKysrKysrKystLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwg
MjUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5k
ZXggYTg1Zjc3YWViZDEyLi5kMzZkZWE1NjhiODIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZGlzcGxheS5jCj4gQEAgLTQ1OTQsMTcgKzQ1OTQsMTcgQEAgc3RhdGljIHZvaWQgaXZ5YnJp
ZGdlX3VwZGF0ZV9mZGlfYmNfYmlmdXJjYXRpb24oc3RydWN0IGludGVsX2NydGMgKmludGVsX2Ny
dGMpCj4gICAqIHVzZWQgd2hlbiB3ZSBrbm93IHRoYXQgdGhlIENSVEMgaXNuJ3QgZmVlZGluZyBt
dWx0aXBsZSBlbmNvZGVycyEKPiAgICovCj4gIHN0YXRpYyBzdHJ1Y3QgaW50ZWxfZW5jb2RlciAq
Cj4gLWludGVsX2dldF9jcnRjX25ld19lbmNvZGVyKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0
YXRlICpjcnRjX3N0YXRlKQo+ICtpbnRlbF9nZXRfY3J0Y19uZXdfZW5jb2Rlcihjb25zdCBzdHJ1
Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpzdGF0ZSwKPiArCQkJICAgY29uc3Qgc3RydWN0IGludGVs
X2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIHsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRj
ID0gdG9faW50ZWxfY3J0YyhjcnRjX3N0YXRlLT5iYXNlLmNydGMpOwo+IC0JY29uc3Qgc3RydWN0
IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlID0gY3J0Y19zdGF0ZS0+YmFzZS5zdGF0ZTsKPiAgCWNv
bnN0IHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpjb25uZWN0b3Jfc3RhdGU7Cj4gIAljb25z
dCBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ICAJc3RydWN0IGludGVsX2VuY29k
ZXIgKmVuY29kZXIgPSBOVUxMOwo+ICAJaW50IG51bV9lbmNvZGVycyA9IDA7Cj4gIAlpbnQgaTsK
PiAgCj4gLQlmb3JfZWFjaF9uZXdfY29ubmVjdG9yX2luX3N0YXRlKHN0YXRlLCBjb25uZWN0b3Is
IGNvbm5lY3Rvcl9zdGF0ZSwgaSkgewo+ICsJZm9yX2VhY2hfbmV3X2Nvbm5lY3Rvcl9pbl9zdGF0
ZSgmc3RhdGUtPmJhc2UsIGNvbm5lY3RvciwgY29ubmVjdG9yX3N0YXRlLCBpKSB7Cj4gIAkJaWYg
KGNvbm5lY3Rvcl9zdGF0ZS0+Y3J0YyAhPSAmY3J0Yy0+YmFzZSkKPiAgCQkJY29udGludWU7Cj4g
IAo+IEBAIC00NjE4LDIyICs0NjE4LDYgQEAgaW50ZWxfZ2V0X2NydGNfbmV3X2VuY29kZXIoY29u
c3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIAlyZXR1cm4gZW5jb2Rl
cjsKPiAgfQo+ICAKPiAtLyogUmV0dXJuIHdoaWNoIERQIFBvcnQgc2hvdWxkIGJlIHNlbGVjdGVk
IGZvciBUcmFuc2NvZGVyIERQIGNvbnRyb2wgKi8KPiAtc3RhdGljIGVudW0gcG9ydAo+IC1pbnRl
bF90cmFuc19kcF9wb3J0X3NlbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAtewo+IC0Jc3Ry
dWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGMtPmJhc2UuZGV2Owo+IC0Jc3RydWN0IGludGVsX2Vu
Y29kZXIgKmVuY29kZXI7Cj4gLQo+IC0JZm9yX2VhY2hfZW5jb2Rlcl9vbl9jcnRjKGRldiwgJmNy
dGMtPmJhc2UsIGVuY29kZXIpIHsKPiAtCQlpZiAoZW5jb2Rlci0+dHlwZSA9PSBJTlRFTF9PVVRQ
VVRfRFAgfHwKPiAtCQkgICAgZW5jb2Rlci0+dHlwZSA9PSBJTlRFTF9PVVRQVVRfRURQKQo+IC0J
CQlyZXR1cm4gZW5jb2Rlci0+cG9ydDsKPiAtCX0KPiAtCj4gLQlyZXR1cm4gLTE7Cj4gLX0KCkds
YWQgdG8gc2VlIHRoaXMgZ28sIGZpbmdlcnMgY3Jvc3NlZCB0aGUgc2FuaXR5IGNoZWNrcyBpbgpp
bnRlbF9nZXRfY3J0Y19uZXdfZW5jb2RlcigpIGFuZCBpcm9ubGFrZV9wY2hfZW5hYmxlKCkgd2ls
bCBnaXZlIGVub3VnaApkZWJ1ZyBkZXRhaWxzIGluIGNhc2UgdGhpcyBnb2VzIGJvb20uIDspCgpS
ZXZpZXdlZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KCj4gLQo+ICAv
Kgo+ICAgKiBFbmFibGUgUENIIHJlc291cmNlcyByZXF1aXJlZCBmb3IgUENIIHBvcnRzOgo+ICAg
KiAgIC0gUENIIFBMTHMKPiBAQCAtNDY0Miw3ICs0NjI2LDggQEAgaW50ZWxfdHJhbnNfZHBfcG9y
dF9zZWwoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gICAqICAgLSBEUCB0cmFuc2NvZGluZyBi
aXRzCj4gICAqICAgLSB0cmFuc2NvZGVyCj4gICAqLwo+IC1zdGF0aWMgdm9pZCBpcm9ubGFrZV9w
Y2hfZW5hYmxlKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICtz
dGF0aWMgdm9pZCBpcm9ubGFrZV9wY2hfZW5hYmxlKGNvbnN0IHN0cnVjdCBpbnRlbF9hdG9taWNf
c3RhdGUgKnN0YXRlLAo+ICsJCQkJY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNf
c3RhdGUpCj4gIHsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gdG9faW50ZWxfY3J0Yyhj
cnRjX3N0YXRlLT5iYXNlLmNydGMpOwo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGMt
PmJhc2UuZGV2Owo+IEBAIC00NzE1LDcgKzQ3MDAsNyBAQCBzdGF0aWMgdm9pZCBpcm9ubGFrZV9w
Y2hfZW5hYmxlKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICAJ
CWlmIChhZGp1c3RlZF9tb2RlLT5mbGFncyAmIERSTV9NT0RFX0ZMQUdfUFZTWU5DKQo+ICAJCQl0
ZW1wIHw9IFRSQU5TX0RQX1ZTWU5DX0FDVElWRV9ISUdIOwo+ICAKPiAtCQlwb3J0ID0gaW50ZWxf
dHJhbnNfZHBfcG9ydF9zZWwoY3J0Yyk7Cj4gKwkJcG9ydCA9IGludGVsX2dldF9jcnRjX25ld19l
bmNvZGVyKHN0YXRlLCBjcnRjX3N0YXRlKS0+cG9ydDsKPiAgCQlXQVJOX09OKHBvcnQgPCBQT1JU
X0IgfHwgcG9ydCA+IFBPUlRfRCk7Cj4gIAkJdGVtcCB8PSBUUkFOU19EUF9QT1JUX1NFTChwb3J0
KTsKPiAgCj4gQEAgLTQ3MjUsNyArNDcxMCw4IEBAIHN0YXRpYyB2b2lkIGlyb25sYWtlX3BjaF9l
bmFibGUoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIAlpcm9u
bGFrZV9lbmFibGVfcGNoX3RyYW5zY29kZXIoZGV2X3ByaXYsIHBpcGUpOwo+ICB9Cj4gIAo+IC1z
dGF0aWMgdm9pZCBscHRfcGNoX2VuYWJsZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAq
Y3J0Y19zdGF0ZSkKPiArc3RhdGljIHZvaWQgbHB0X3BjaF9lbmFibGUoY29uc3Qgc3RydWN0IGlu
dGVsX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gKwkJCSAgIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRj
X3N0YXRlICpjcnRjX3N0YXRlKQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YyA9IHRv
X2ludGVsX2NydGMoY3J0Y19zdGF0ZS0+YmFzZS5jcnRjKTsKPiAgCXN0cnVjdCBkcm1faTkxNV9w
cml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY3J0Yy0+YmFzZS5kZXYpOwo+IEBAIC01NTI4LDcg
KzU1MTQsNyBAQCBzdGF0aWMgdm9pZCBpcm9ubGFrZV9jcnRjX2VuYWJsZShzdHJ1Y3QgaW50ZWxf
Y3J0Y19zdGF0ZSAqcGlwZV9jb25maWcsCj4gIAlpbnRlbF9lbmFibGVfcGlwZShwaXBlX2NvbmZp
Zyk7Cj4gIAo+ICAJaWYgKGludGVsX2NydGMtPmNvbmZpZy0+aGFzX3BjaF9lbmNvZGVyKQo+IC0J
CWlyb25sYWtlX3BjaF9lbmFibGUocGlwZV9jb25maWcpOwo+ICsJCWlyb25sYWtlX3BjaF9lbmFi
bGUob2xkX2ludGVsX3N0YXRlLCBwaXBlX2NvbmZpZyk7Cj4gIAo+ICAJYXNzZXJ0X3ZibGFua19k
aXNhYmxlZChjcnRjKTsKPiAgCWRybV9jcnRjX3ZibGFua19vbihjcnRjKTsKPiBAQCAtNTY2Nyw3
ICs1NjUzLDcgQEAgc3RhdGljIHZvaWQgaGFzd2VsbF9jcnRjX2VuYWJsZShzdHJ1Y3QgaW50ZWxf
Y3J0Y19zdGF0ZSAqcGlwZV9jb25maWcsCj4gIAkJaW50ZWxfZW5hYmxlX3BpcGUocGlwZV9jb25m
aWcpOwo+ICAKPiAgCWlmIChpbnRlbF9jcnRjLT5jb25maWctPmhhc19wY2hfZW5jb2RlcikKPiAt
CQlscHRfcGNoX2VuYWJsZShwaXBlX2NvbmZpZyk7Cj4gKwkJbHB0X3BjaF9lbmFibGUob2xkX2lu
dGVsX3N0YXRlLCBwaXBlX2NvbmZpZyk7Cj4gIAo+ICAJaWYgKGludGVsX2NydGNfaGFzX3R5cGUo
aW50ZWxfY3J0Yy0+Y29uZmlnLCBJTlRFTF9PVVRQVVRfRFBfTVNUKSkKPiAgCQlpbnRlbF9kZGlf
c2V0X3ZjX3BheWxvYWRfYWxsb2MocGlwZV9jb25maWcsIHRydWUpOwo+IEBAIC05MTIxLDkgKzkx
MDcsMTIgQEAgdm9pZCBoc3dfZGlzYWJsZV9wYzgoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2KQo+ICBzdGF0aWMgaW50IGhhc3dlbGxfY3J0Y19jb21wdXRlX2Nsb2NrKHN0cnVjdCBp
bnRlbF9jcnRjICpjcnRjLAo+ICAJCQkJICAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNy
dGNfc3RhdGUpCj4gIHsKPiArCXN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRlID0KPiAr
CQl0b19pbnRlbF9hdG9taWNfc3RhdGUoY3J0Y19zdGF0ZS0+YmFzZS5zdGF0ZSk7Cj4gKwo+ICAJ
aWYgKCFpbnRlbF9jcnRjX2hhc190eXBlKGNydGNfc3RhdGUsIElOVEVMX09VVFBVVF9EU0kpKSB7
Cj4gIAkJc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIgPQo+IC0JCQlpbnRlbF9nZXRfY3J0
Y19uZXdfZW5jb2RlcihjcnRjX3N0YXRlKTsKPiArCQkJaW50ZWxfZ2V0X2NydGNfbmV3X2VuY29k
ZXIoc3RhdGUsIGNydGNfc3RhdGUpOwo+ICAKPiAgCQlpZiAoIWludGVsX2dldF9zaGFyZWRfZHBs
bChjcnRjLCBjcnRjX3N0YXRlLCBlbmNvZGVyKSkgewo+ICAJCQlEUk1fREVCVUdfRFJJVkVSKCJm
YWlsZWQgdG8gZmluZCBQTEwgZm9yIHBpcGUgJWNcbiIsCgotLSAKSmFuaSBOaWt1bGEsIEludGVs
IE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0
cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s
aXN0aW5mby9pbnRlbC1nZngK