From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state Date: Mon, 30 Apr 2018 13:21:16 +0300 Message-ID: <87lgd59eqr.fsf@intel.com> References: <20180425174253.4616-1-daniel.vetter@ffwll.ch> <20180425174253.4616-2-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id EBC966E15C for ; Mon, 30 Apr 2018 10:18:36 +0000 (UTC) In-Reply-To: <20180425174253.4616-2-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: DRI Development , LKML Cc: Jingoo Han , Daniel Vetter , Daniel Thompson , Lee Jones , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAyNSBBcHIgMjAxOCwgRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5j aD4gd3JvdGU6Cj4gTm90aGluZyBpbiB0aGUgZW50aXJlIHRyZWUgZXZlciBzZXRzIHRoaXMsIHdo aWNoIG1lYW5zIHRoaXMgaXMgZGVhZAo+IGNvZGUuIFJlbW92ZSBpdC4KPgo+IENjOiBMZWUgSm9u ZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+IENjOiBEYW5pZWwgVGhvbXBzb24gPGRhbmllbC50 aG9tcHNvbkBsaW5hcm8ub3JnPgo+IENjOiBKaW5nb28gSGFuIDxqaW5nb29oYW4xQGdtYWlsLmNv bT4KPiBBY2tlZC1ieTogRGFuaWVsIFRob21wc29uIDxkYW5pZWwudGhvbXBzb25AbGluYXJvLm9y Zz4KPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNv bT4KClJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKPiAt LS0KPiAgZHJpdmVycy92aWRlby9iYWNrbGlnaHQvZ2VuZXJpY19ibC5jIHwgNSAtLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Zp ZGVvL2JhY2tsaWdodC9nZW5lcmljX2JsLmMgYi9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9nZW5l cmljX2JsLmMKPiBpbmRleCA2N2RmYjkzOWE1MTQuLjRkZWE5MWFjZWExMyAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9nZW5lcmljX2JsLmMKPiArKysgYi9kcml2ZXJzL3Zp ZGVvL2JhY2tsaWdodC9nZW5lcmljX2JsLmMKPiBAQCAtMjEsOSArMjEsNiBAQCBzdGF0aWMgaW50 IGdlbmVyaWNibF9pbnRlbnNpdHk7Cj4gIHN0YXRpYyBzdHJ1Y3QgYmFja2xpZ2h0X2RldmljZSAq Z2VuZXJpY19iYWNrbGlnaHRfZGV2aWNlOwo+ICBzdGF0aWMgc3RydWN0IGdlbmVyaWNfYmxfaW5m byAqYmxfbWFjaGluZm87Cj4gIAo+IC0vKiBGbGFnIHRvIHNpZ25hbCB3aGVuIHRoZSBiYXR0ZXJ5 IGlzIGxvdyAqLwo+IC0jZGVmaW5lIEdFTkVSSUNCTF9CQVRUTE9XICAgICAgIEJMX0NPUkVfRFJJ VkVSMQo+IC0KPiAgc3RhdGljIGludCBnZW5lcmljYmxfc2VuZF9pbnRlbnNpdHkoc3RydWN0IGJh Y2tsaWdodF9kZXZpY2UgKmJkKQo+ICB7Cj4gIAlpbnQgaW50ZW5zaXR5ID0gYmQtPnByb3BzLmJy aWdodG5lc3M7Cj4gQEAgLTM0LDggKzMxLDYgQEAgc3RhdGljIGludCBnZW5lcmljYmxfc2VuZF9p bnRlbnNpdHkoc3RydWN0IGJhY2tsaWdodF9kZXZpY2UgKmJkKQo+ICAJCWludGVuc2l0eSA9IDA7 Cj4gIAlpZiAoYmQtPnByb3BzLnN0YXRlICYgQkxfQ09SRV9TVVNQRU5ERUQpCj4gIAkJaW50ZW5z aXR5ID0gMDsKPiAtCWlmIChiZC0+cHJvcHMuc3RhdGUgJiBHRU5FUklDQkxfQkFUVExPVykKPiAt CQlpbnRlbnNpdHkgJj0gYmxfbWFjaGluZm8tPmxpbWl0X21hc2s7Cj4gIAo+ICAJYmxfbWFjaGlu Zm8tPnNldF9ibF9pbnRlbnNpdHkoaW50ZW5zaXR5KTsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwg T3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752786AbeD3KSj (ORCPT ); Mon, 30 Apr 2018 06:18:39 -0400 Received: from mga12.intel.com ([192.55.52.136]:38019 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752363AbeD3KSh (ORCPT ); Mon, 30 Apr 2018 06:18:37 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,346,1520924400"; d="scan'208";a="51101761" From: Jani Nikula To: Daniel Vetter , DRI Development , LKML Cc: Daniel Vetter , Daniel Vetter , Daniel Thompson , Lee Jones , Jingoo Han Subject: Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state In-Reply-To: <20180425174253.4616-2-daniel.vetter@ffwll.ch> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20180425174253.4616-1-daniel.vetter@ffwll.ch> <20180425174253.4616-2-daniel.vetter@ffwll.ch> Date: Mon, 30 Apr 2018 13:21:16 +0300 Message-ID: <87lgd59eqr.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Apr 2018, Daniel Vetter wrote: > Nothing in the entire tree ever sets this, which means this is dead > code. Remove it. > > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Acked-by: Daniel Thompson > Signed-off-by: Daniel Vetter Reviewed-by: Jani Nikula > --- > drivers/video/backlight/generic_bl.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c > index 67dfb939a514..4dea91acea13 100644 > --- a/drivers/video/backlight/generic_bl.c > +++ b/drivers/video/backlight/generic_bl.c > @@ -21,9 +21,6 @@ static int genericbl_intensity; > static struct backlight_device *generic_backlight_device; > static struct generic_bl_info *bl_machinfo; > > -/* Flag to signal when the battery is low */ > -#define GENERICBL_BATTLOW BL_CORE_DRIVER1 > - > static int genericbl_send_intensity(struct backlight_device *bd) > { > int intensity = bd->props.brightness; > @@ -34,8 +31,6 @@ static int genericbl_send_intensity(struct backlight_device *bd) > intensity = 0; > if (bd->props.state & BL_CORE_SUSPENDED) > intensity = 0; > - if (bd->props.state & GENERICBL_BATTLOW) > - intensity &= bl_machinfo->limit_mask; > > bl_machinfo->set_bl_intensity(intensity); -- Jani Nikula, Intel Open Source Technology Center