From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 2/2] drm/i915/bios: reduce the scope of some local variables in parse_ddi_port() Date: Thu, 12 Apr 2018 12:29:42 +0300 Message-ID: <87lgdsg4c9.fsf@intel.com> References: <20180411131519.9091-1-jani.nikula@intel.com> <20180411131519.9091-2-jani.nikula@intel.com> <152345265763.13225.18014047201030023125@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 71CBB6E7B2 for ; Thu, 12 Apr 2018 09:28:55 +0000 (UTC) In-Reply-To: <152345265763.13225.18014047201030023125@mail.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAxMSBBcHIgMjAxOCwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IFF1b3RpbmcgSmFuaSBOaWt1bGEgKDIwMTgtMDQtMTEgMTQ6MTU6MTkpCj4+ IE5vIGZ1bmN0aW9uYWwgY2hhbmdlcy4KPj4gCj4+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNo cmlzLXdpbHNvbi5jby51az4KPj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlr dWxhQGludGVsLmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9z LmMgfCAxMCArKysrLS0tLS0tCj4+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA2 IGRlbGV0aW9ucygtKQo+PiAKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Jpb3MuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+PiBpbmRleCA0 NDdiNzIxYzNiZTkuLjAzNjMwN2FmODQxOSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfYmlvcy5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jp b3MuYwo+PiBAQCAtMTIxNSwxMCArMTIxNSw4IEBAIHN0YXRpYyB2b2lkIHBhcnNlX2RkaV9wb3J0 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgZW51bSBwb3J0IHBvcnQsCj4+ICB7 Cj4+ICAgICAgICAgc3RydWN0IGNoaWxkX2RldmljZV9jb25maWcgKml0LCAqY2hpbGQgPSBOVUxM Owo+PiAgICAgICAgIHN0cnVjdCBkZGlfdmJ0X3BvcnRfaW5mbyAqaW5mbyA9ICZkZXZfcHJpdi0+ dmJ0LmRkaV9wb3J0X2luZm9bcG9ydF07Cj4+IC0gICAgICAgdWludDhfdCBoZG1pX2xldmVsX3No aWZ0Owo+PiAgICAgICAgIGludCBpLCBqOwo+PiAgICAgICAgIGJvb2wgaXNfZHZpLCBpc19oZG1p LCBpc19kcCwgaXNfZWRwLCBpc19jcnQ7Cj4+IC0gICAgICAgdWludDhfdCBhdXhfY2hhbm5lbCwg ZGRjX3BpbjsKPj4gICAgICAgICAvKiBFYWNoIERESSBwb3J0IGNhbiBoYXZlIG1vcmUgdGhhbiBv bmUgdmFsdWUgb24gdGhlICJEVk8gUG9ydCIgZmllbGQsCj4+ICAgICAgICAgICogc28gbG9vayBm b3IgYWxsIHRoZSBwb3NzaWJsZSB2YWx1ZXMgZm9yIGVhY2ggcG9ydC4KPj4gICAgICAgICAgKi8K Pj4gQEAgLTEyNTUsOCArMTI1Myw2IEBAIHN0YXRpYyB2b2lkIHBhcnNlX2RkaV9wb3J0KHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgZW51bSBwb3J0IHBvcnQsCj4+ICAgICAgICAg aWYgKCFjaGlsZCkKPj4gICAgICAgICAgICAgICAgIHJldHVybjsKPj4gIAo+PiAtICAgICAgIGF1 eF9jaGFubmVsID0gY2hpbGQtPmF1eF9jaGFubmVsOwo+PiAtCj4+ICAgICAgICAgaXNfZHZpID0g Y2hpbGQtPmRldmljZV90eXBlICYgREVWSUNFX1RZUEVfVE1EU19EVklfU0lHTkFMSU5HOwo+PiAg ICAgICAgIGlzX2RwID0gY2hpbGQtPmRldmljZV90eXBlICYgREVWSUNFX1RZUEVfRElTUExBWVBP UlRfT1VUUFVUOwo+PiAgICAgICAgIGlzX2NydCA9IGNoaWxkLT5kZXZpY2VfdHlwZSAmIERFVklD RV9UWVBFX0FOQUxPR19PVVRQVVQ7Cj4+IEBAIC0xMzAyLDYgKzEyOTgsOCBAQCBzdGF0aWMgdm9p ZCBwYXJzZV9kZGlfcG9ydChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0g cG9ydCBwb3J0LAo+PiAgICAgICAgICAgICAgICAgRFJNX0RFQlVHX0tNUygiUG9ydCAlYyBpcyBp bnRlcm5hbCBEUFxuIiwgcG9ydF9uYW1lKHBvcnQpKTsKPj4gIAo+PiAgICAgICAgIGlmIChpc19k dmkpIHsKPj4gKyAgICAgICAgICAgICAgIHU4IGRkY19waW47Cj4+ICsKPj4gICAgICAgICAgICAg ICAgIGRkY19waW4gPSBtYXBfZGRjX3BpbihkZXZfcHJpdiwgY2hpbGQtPmRkY19waW4pOwo+PiAg ICAgICAgICAgICAgICAgaWYgKGludGVsX2dtYnVzX2lzX3ZhbGlkX3BpbihkZXZfcHJpdiwgZGRj X3BpbikpIHsKPj4gICAgICAgICAgICAgICAgICAgICAgICAgaW5mby0+YWx0ZXJuYXRlX2RkY19w aW4gPSBkZGNfcGluOwo+PiBAQCAtMTMxNCwxNCArMTMxMiwxNCBAQCBzdGF0aWMgdm9pZCBwYXJz ZV9kZGlfcG9ydChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gcG9ydCBw b3J0LAo+PiAgICAgICAgIH0KPj4gIAo+PiAgICAgICAgIGlmIChpc19kcCkgewo+PiAtICAgICAg ICAgICAgICAgaW5mby0+YWx0ZXJuYXRlX2F1eF9jaGFubmVsID0gYXV4X2NoYW5uZWw7Cj4+ICsg ICAgICAgICAgICAgICBpbmZvLT5hbHRlcm5hdGVfYXV4X2NoYW5uZWwgPSBjaGlsZC0+YXV4X2No YW5uZWw7Cj4+ICAKPj4gICAgICAgICAgICAgICAgIHNhbml0aXplX2F1eF9jaChkZXZfcHJpdiwg cG9ydCk7Cj4+ICAgICAgICAgfQo+PiAgCj4+ICAgICAgICAgaWYgKGJkYl92ZXJzaW9uID49IDE1 OCkgewo+PiAgICAgICAgICAgICAgICAgLyogVGhlIFZCVCBIRE1JIGxldmVsIHNoaWZ0IHZhbHVl cyBtYXRjaCB0aGUgdGFibGUgd2UgaGF2ZS4gKi8KPj4gLSAgICAgICAgICAgICAgIGhkbWlfbGV2 ZWxfc2hpZnQgPSBjaGlsZC0+aGRtaV9sZXZlbF9zaGlmdGVyX3ZhbHVlOwo+PiArICAgICAgICAg ICAgICAgdTggaGRtaV9sZXZlbF9zaGlmdCA9IGNoaWxkLT5oZG1pX2xldmVsX3NoaWZ0ZXJfdmFs dWU7Cj4KPiBjaGVja3BhdGNoIHdpbGwgYXNrIGZvciBhIFxuLAoKSGFwcGlseSBub3QsIHB1c2hl ZCBhcy1pcywgdGhhbmtzIGZvciB0aGUgcmV2aWV3LgoKQlIsCkphbmkuCgoKCj4KPiBSZXZpZXdl ZC1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLUNocmlzCgot LSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=