From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f4MNW-0007va-7l for ath10k@lists.infradead.org; Fri, 06 Apr 2018 08:05:48 +0000 From: Kalle Valo Subject: Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets References: <20180226084406.2093-1-s.gottschall@dd-wrt.com> <871sftemru.fsf@kamboji.qca.qualcomm.com> Date: Fri, 06 Apr 2018 11:05:30 +0300 In-Reply-To: (Sebastian Gottschall's message of "Thu, 5 Apr 2018 20:01:47 +0200") Message-ID: <87lge0sqt1.fsf@codeaurora.org> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Sebastian Gottschall Cc: Sebastian Gottschall , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org U2ViYXN0aWFuIEdvdHRzY2hhbGwgPHMuZ290dHNjaGFsbEBkZC13cnQuY29tPiB3cml0ZXM6Cgo+ IEFtIDA1LjA0LjIwMTggdW0gMTY6NDQgc2NocmllYiBLYWxsZSBWYWxvOgo+PiBzLmdvdHRzY2hh bGxAZGQtd3J0LmNvbSB3cml0ZXM6Cj4+Cj4+PiBBZGRzIExFRCBhbmQgR1BJTyBDb250cm9sIHN1 cHBvcnQgZm9yIDk4OHgsIDk4ODcsIDk4ODgsIDk5eDAsIDk5ODQKPj4+IGJhc2VkIGNoaXBzZXRz IHdpdGggb24gY2hpcHNldCBjb25uZWN0ZWQgbGVkJ3MgdXNpbmcgV01JIEZpcm13YXJlIEFQSS4K Pj4+IFRoZSBMRUQgZGV2aWNlIHdpbGwgZ2V0IGF2YWlsYWJsZSBuYW1lZCBhcyAiYXRoMTBrLXBo eVgiIGF0IHN5c2ZzIGFuZAo+Pj4gY2FuIGJlIGNvbnRyb2xsZWQgd2l0aCB2YXJpb3VzIHRyaWdn ZXJzLiBhZGRzIGFsc28gZGVidWdmcyBpbnRlcmZhY2UKPj4+IGZvciBncGlvIGNvbnRyb2wuCj4+ Pgo+Pj4gU2lnbmVkLW9mZi1ieTogU2ViYXN0aWFuIEdvdHRzY2hhbGwgPHMuZ290dHNjaGFsbEBk ZC13cnQuY29tPgo+PiBbLi4uXQo+Pgo+Pj4gQEAgLTEwMzQsNyArMTA2OCw3IEBAIGF0aDEwa193 bWlfcGRldl9nZXRfdGVtcGVyYXR1cmUoc3RydWN0IGF0aDEwayAqYXIpCj4+PiDCoMKgwqDCoMKg IGlmIChJU19FUlIoc2tiKSkKPj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gUFRSX0VSUihz a2IpOwo+Pj4gwqAgLcKgwqDCoCByZXR1cm4gYXRoMTBrX3dtaV9jbWRfc2VuZChhciwgc2tiLAo+ Pj4gK8KgwqDCoCByZXR1cm4gYXRoMTBrX3dtaV9jbWRfc2VuZF9ub3dhaXQoYXIsIHNrYiwKPj4+ IGFyLT53bWkuY21kLT5wZGV2X2dldF90ZW1wZXJhdHVyZV9jbWRpZCk7Cj4+PiDCoCB9Cj4+IFRo aXMgbG9va3Mgb2RkLCBJIGRvbid0IHRoaW5rIGl0IGJlbG9uZ3MgdG8gdGhpcyBwYXRjaC4KPgo+ IHRoYXRzIHRydWUuIGJ1dCBkdWUgdGhlIG5hdHVyZSBvZiB0aGlzIGZ1bmN0aW9uIGkgZm91bmQg aXQgYmV0dGVyIHRvCj4gdXNlIG5vd2FpdCBoZXJlLiBiZXR0ZXIgaWYgaSBzcGxpdCBpdCB1cD8K ClllcywgdGhpcyBzaG91bGQgYmUgZG9uZSBpbiBhIHNlcGFyYXRlIHBhdGNoIHdpdGggYSBwcm9w ZXIgY29tbWl0IGxvZwpleHBsYWluaW5nIHdoeSBpdCdzIG5lZWRlZC4KCj4+IEFsc28geW91IG1h ZGUgYSBzb21lIHNvcnQgb2YgcmVjb3JkLCB5b3VyIHBhdGNoIGhhZCAxODEgY2hlY2twYXRjaAo+ PiB3YXJuaW5ncyEgRG8geW91IHVzZSBXb3JkIGFzIHlvdXIgZWRpdG9yIG9yIHdoYXQ/IEJ1dCBw bGVhc2UgZG8gY2hlY2sKPj4geW91ciBlZGl0b3Igc2V0dGluZ3MgYW5kIHJlYWQgdGhlIGNvZGlu ZyBzdHlsZSBkb2N1bWVudHMuCj4KPiBubz8gaSB1c2UgbWlkbmlnaHQgY29tbWFuZGVyIGZvciBh bGwgb2YgbXkgY29kZSBzaW5jZSBtb3JlIHRoYW4gMjAgeWVhcnMKPiBhbmQgaXRzIHRoZSBmaXJz dCB0aW1lIHRoYXQgaSBzZWUgc3VjaCB3YXJuaW5ncy4gaXMgdGhlcmUgYW55IHNwZWNpYWwKPiBj b2RpbmcgcnVsZSBmb3IgYXRoMTBrIHdoaWNoIGRpZmZlcnMgZnJvbSB0aGUga2VybmVsIHJ1bGVz PwoKWW91IGdvdCBldmVuIHRoZSBpbmRlbnRhdGlvbiB3cm9uZyBpbiBtdWx0aXBsZSBmdW5jdGlv bnMgYW5kIGluZGVudGF0aW9uCnJ1bGVzIGhhdmUgYmVlbiB0aGUgc2FtZSBhcyBsb25nIGFzIEkg cmVtZW1iZXIuIEFuZCBjaGVja3BhdGNoIGhhcyBiZWVuCmFyb3VuZCBhIGxvbmcgdGltZSBhbHJl YWR5LCB0aGF0IHNob3VsZCBub3QgYmUgbmV3IHRvIGFueW9uZSBzdWJtaXR0aW5nCnBhdGNoZXMu Cgo+IGFuZCB3aGVyZSBpcyBhdGgxMGstY2hlY2sgbG9jYXRlZD8KCkNoZWNrIHRoZSBsaW5rIEkg cHJvdmlkZWQ6Cgo+PiBodHRwczovL3dpcmVsZXNzLndpa2kua2VybmVsLm9yZy9lbi91c2Vycy9k cml2ZXJzL2F0aDEway9jb2RpbmdzdHlsZQoKLS0gCkthbGxlIFZhbG8KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRo MTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:42652 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751089AbeDFIFg (ORCPT ); Fri, 6 Apr 2018 04:05:36 -0400 From: Kalle Valo To: Sebastian Gottschall Cc: linux-wireless@vger.kernel.org, Sebastian Gottschall , ath10k@lists.infradead.org Subject: Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets References: <20180226084406.2093-1-s.gottschall@dd-wrt.com> <871sftemru.fsf@kamboji.qca.qualcomm.com> Date: Fri, 06 Apr 2018 11:05:30 +0300 In-Reply-To: (Sebastian Gottschall's message of "Thu, 5 Apr 2018 20:01:47 +0200") Message-ID: <87lge0sqt1.fsf@codeaurora.org> (sfid-20180406_100544_352534_E87683EA) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Sebastian Gottschall writes: > Am 05.04.2018 um 16:44 schrieb Kalle Valo: >> s.gottschall@dd-wrt.com writes: >> >>> Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 >>> based chipsets with on chipset connected led's using WMI Firmware API. >>> The LED device will get available named as "ath10k-phyX" at sysfs and >>> can be controlled with various triggers. adds also debugfs interface >>> for gpio control. >>> >>> Signed-off-by: Sebastian Gottschall >> [...] >> >>> @@ -1034,7 +1068,7 @@ ath10k_wmi_pdev_get_temperature(struct ath10k *ar) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (IS_ERR(skb)) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return PTR_ERR(s= kb); >>> =C2=A0 -=C2=A0=C2=A0=C2=A0 return ath10k_wmi_cmd_send(ar, skb, >>> +=C2=A0=C2=A0=C2=A0 return ath10k_wmi_cmd_send_nowait(ar, skb, >>> ar->wmi.cmd->pdev_get_temperature_cmdid); >>> =C2=A0 } >> This looks odd, I don't think it belongs to this patch. > > thats true. but due the nature of this function i found it better to > use nowait here. better if i split it up? Yes, this should be done in a separate patch with a proper commit log explaining why it's needed. >> Also you made a some sort of record, your patch had 181 checkpatch >> warnings! Do you use Word as your editor or what? But please do check >> your editor settings and read the coding style documents. > > no? i use midnight commander for all of my code since more than 20 years > and its the first time that i see such warnings. is there any special > coding rule for ath10k which differs from the kernel rules? You got even the indentation wrong in multiple functions and indentation rules have been the same as long as I remember. And checkpatch has been around a long time already, that should not be new to anyone submitting patches. > and where is ath10k-check located? Check the link I provided: >> https://wireless.wiki.kernel.org/en/users/drivers/ath10k/codingstyle --=20 Kalle Valo