From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com ([62.4.15.54]:48294 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753025AbeB0KYZ (ORCPT ); Tue, 27 Feb 2018 05:24:25 -0500 From: Gregory CLEMENT To: Andrew Lunn Cc: David Miller , netdev , Vivien Didelot , Gregory Clement Subject: Re: [PATCH 0/2] mv88e6xxx: Poll when no interrupt defined References: <1519336713-5417-1-git-send-email-andrew@lunn.ch> Date: Tue, 27 Feb 2018 11:24:02 +0100 In-Reply-To: <1519336713-5417-1-git-send-email-andrew@lunn.ch> (Andrew Lunn's message of "Thu, 22 Feb 2018 22:58:31 +0100") Message-ID: <87lgfelohp.fsf@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: netdev-owner@vger.kernel.org List-ID: Hi Andrew, On jeu., févr. 22 2018, Andrew Lunn wrote: > Not all boards using the mv88e6xxx switches have the interrupt output > connected to a GPIO. On these boards phylib has to poll the PHYs, > rather than use interrupts. Have the driver poll the interrupt status > register, which is more efficient than having phylib do it. And it > enables other switch interrupts to be services. > > The Armada 370RD is such a board without a interrupt GPIO. Now that > interrupts work, wire up the PHYs to make use if them. > > Gregory: Are you O.K. for the second patch to go through netdev? Why do you need that the second patch to go through netdev. Is there any dependency between the 2 patches? If it is the case does it means that an new kernel won't work with an old device tree? Gregory > > Andrew Lunn (2): > net: dsa: mv88e6xxx: Poll when no interrupt defined > arm: mvebu: 370-rd: Enable PHY interrupt handling > > arch/arm/boot/dts/armada-370-rd.dts | 32 ++++++++ > drivers/net/dsa/mv88e6xxx/chip.c | 146 +++++++++++++++++++++++++----------- > drivers/net/dsa/mv88e6xxx/chip.h | 3 + > 3 files changed, 138 insertions(+), 43 deletions(-) > > -- > 2.15.1 > -- Gregory Clement, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com