From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from bart.luffy.cx ([78.47.78.131]:46261 "EHLO bart.luffy.cx"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750738AbeBUGHD (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 21 Feb 2018 01:07:03 -0500
From: Vincent Bernat <vincent@bernat.im>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] color: disable color when json output is requested
References: <20180220232804.10930-1-vincent@bernat.im>
        <20180220160455.1e89c0be@xeon-e3>
Date: Wed, 21 Feb 2018 06:58:47 +0100
In-Reply-To: <20180220160455.1e89c0be@xeon-e3> (Stephen Hemminger's message of
        "Tue, 20 Feb 2018 16:04:55 -0800")
Message-ID: <87lgfmsx2g.fsf@luffy.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

 =E2=9D=A6 20 f=C3=A9vrier 2018 16:04 -0800, Stephen Hemminger <stephen@net=
workplumber.org>=C2=A0:

>> Instead of declaring -color and -json exclusive, ignore -color when
>> -json is provided. The rationale is to allow to put -color in an alias
>> for ip while still being able to use -json. -color is merely a
>> presentation suggestion and we can assume there is nothing to color in
>> the JSON output.
>>=20
>> Signed-off-by: Vincent Bernat <vincent@bernat.im>
>
> Looks fine to me, this could even go into master.
> Need to update man page and make sure behavior is consistent
> across ip, tc, and bridge commands.

Currently, in master or net-next, only the "ip" command has a -color
option.
--=20
The human race is a race of cowards; and I am not only marching in that
procession but carrying a banner.
		-- Mark Twain