Re: [PATCH] Btrfs: cleanup 'start' subtraction from try uncompressed inline extent

[Satoru Takeuchi <satoru.takeuchi@gmail.com>]

At Fri, 15 Sep 2017 01:57:26 +0300,
Timofey Titovets wrote:
> 
> Was added in:
>   c8b978188c9a0fd3d535c13debd19d522b726f1f
>   "Btrfs: Add zlib compression support"
> Survive to near time (from 08.10.2008).
> 
> Because 'start' checked for zero before branch, so it's
> safe to remove that subtraction.
> 
> Signed-off-by: Timofey Titovets <nefelim4ag@gmail.com>

Reviewed-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

> ---
>  fs/btrfs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 02ef32149c15..81123408e82e 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -570,7 +570,7 @@ static noinline void compress_file_range(struct inode *inode,
>  cont:
>  	if (start == 0) {
>  		/* lets try to make an inline extent */
> -		if (ret || total_in < (actual_end - start)) {
> +		if (ret || total_in < actual_end) {
>  			/* we didn't compress the entire range, try
>  			 * to make an uncompressed inline extent.
>  			 */
> -- 
> 2.14.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html