From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id l91sm601798wrc.16.2017.09.05.05.02.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Sep 2017 05:02:23 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTPS id 9402A3E00A0; Tue, 5 Sep 2017 13:02:22 +0100 (BST) References: <20170829063313.10237-1-bobby.prani@gmail.com> User-agent: mu4e 0.9.19; emacs 25.2.50.3 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Pranith Kumar Cc: Peter Maydell , "open list\:ARM" , qemu-devel@nongnu.org, rth@twiddle.net, pbonzini@redhat.com Subject: Re: [PATCH 1/5] target/arm: Remove stale comment In-reply-to: <20170829063313.10237-1-bobby.prani@gmail.com> Date: Tue, 05 Sep 2017 13:02:22 +0100 Message-ID: <87lgltmjzl.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-TUID: ePV2X97xzLSR Pranith Kumar writes: > Update the comment which is not true since MTTCG. What happened to the cover letter? We seem to have a mix of patches but no summary of the overall outcome. > > Reviewed-by: Richard Henderson > Signed-off-by: Pranith Kumar > --- > target/arm/translate-a64.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c > index 2200e25be0..f42b155d7d 100644 > --- a/target/arm/translate-a64.c > +++ b/target/arm/translate-a64.c > @@ -2012,10 +2012,6 @@ static void disas_ldst_excl(DisasContext *s, uint32_t insn) > } > tcg_addr = read_cpu_reg_sp(s, rn, 1); > > - /* Note that since TCG is single threaded load-acquire/store-release > - * semantics require no extra if (is_lasr) { ... } handling. > - */ > - > if (is_excl) { > if (!is_store) { > s->is_ldex = true; -- Alex Bennée From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpCYr-0005bA-K4 for qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:02:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpCYk-0007DB-4P for qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:02:33 -0400 Received: from mail-wr0-x232.google.com ([2a00:1450:400c:c0c::232]:38886) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dpCYj-0007Bx-Tt for qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:02:26 -0400 Received: by mail-wr0-x232.google.com with SMTP id 108so8192170wra.5 for ; Tue, 05 Sep 2017 05:02:25 -0700 (PDT) References: <20170829063313.10237-1-bobby.prani@gmail.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20170829063313.10237-1-bobby.prani@gmail.com> Date: Tue, 05 Sep 2017 13:02:22 +0100 Message-ID: <87lgltmjzl.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 1/5] target/arm: Remove stale comment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pranith Kumar Cc: Peter Maydell , "open list:ARM" , qemu-devel@nongnu.org, rth@twiddle.net, pbonzini@redhat.com Pranith Kumar writes: > Update the comment which is not true since MTTCG. What happened to the cover letter? We seem to have a mix of patches but no summary of the overall outcome. > > Reviewed-by: Richard Henderson > Signed-off-by: Pranith Kumar > --- > target/arm/translate-a64.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c > index 2200e25be0..f42b155d7d 100644 > --- a/target/arm/translate-a64.c > +++ b/target/arm/translate-a64.c > @@ -2012,10 +2012,6 @@ static void disas_ldst_excl(DisasContext *s, uint32_t insn) > } > tcg_addr = read_cpu_reg_sp(s, rn, 1); > > - /* Note that since TCG is single threaded load-acquire/store-release > - * semantics require no extra if (is_lasr) { ... } handling. > - */ > - > if (is_excl) { > if (!is_store) { > s->is_ldex = true; -- Alex Bennée