From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 3/3] drm/i915: Check the ring is empty when declaring the engines are idle Date: Wed, 31 May 2017 17:01:53 +0300 Message-ID: <87lgpdrupa.fsf@gaia.fi.intel.com> References: <20170530121334.17364-1-chris@chris-wilson.co.uk> <20170530121334.17364-3-chris@chris-wilson.co.uk> <87tw42sevu.fsf@gaia.fi.intel.com> <20170531135835.GT23936@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 536666E205 for ; Wed, 31 May 2017 14:02:34 +0000 (UTC) In-Reply-To: <20170531135835.GT23936@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gT24gVHVl LCBNYXkgMzAsIDIwMTcgYXQgMDM6MzM6NDFQTSArMDMwMCwgTWlrYSBLdW9wcGFsYSB3cm90ZToK Pj4gQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKPj4gCj4+ ID4gQXMgYW5vdGhlciBwcmVjYXV0aW9uIHdoZW4gdGVzdGluZyB3aGV0aGVyIHRoZSBDUyBlbmdp bmUgaXMgYWN0dWFsbHkKPj4gPiBpZGxlLCBhbHNvIGluc3BlY3QgdGhlIHJpbmcncyBIRUFEL1RB SUwgcmVnaXN0ZXJzLCB3aGljaCBzaG91bGQgYmUgZXF1YWwKPj4gPiB3aGVuIHRoZXJlIGFyZSBu byBjb21tYW5kcyBsZWZ0IHRvIGV4ZWN1dGUgYnkgdGhlIEdQVS4KPj4gPgo+PiA+IFNpZ25lZC1v ZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+PiA+IENjOiBN aWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGludGVsLmNvbT4KPj4gPiAtLS0KPj4gPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMgfCA1ICsrKysrCj4+ID4gIDEgZmls ZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKykKPj4gPgo+PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2VuZ2luZV9jcy5jCj4+ID4gaW5kZXggNjk5ZjJkMzg2MWM3Li5iYzM4YmQxMjhiNzYgMTAw NjQ0Cj4+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPj4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+PiA+IEBAIC0x MjEyLDYgKzEyMTIsMTEgQEAgc3RhdGljIGJvb2wgcmluZ19pc19pZGxlKHN0cnVjdCBpbnRlbF9l bmdpbmVfY3MgKmVuZ2luZSkKPj4gPiAgCj4+ID4gIAlpbnRlbF9ydW50aW1lX3BtX2dldChkZXZf cHJpdik7Cj4+ID4gIAo+PiA+ICsJLyogRmlyc3QgY2hlY2sgdGhhdCBubyBjb21tYW5kcyBhcmUg bGVmdCBpbiB0aGUgcmluZyAqLwo+PiA+ICsJaWYgKChJOTE1X1JFQURfSEVBRChlbmdpbmUpICYg SEVBRF9BRERSKSAhPQo+PiA+ICsJICAgIChJOTE1X1JFQURfVEFJTChlbmdpbmUpICYgVEFJTF9B RERSKSkKPj4gPiArCQlpZGxlID0gZmFsc2U7Cj4+ID4gKwo+PiAKPj4gWW91IGFyZSBhbHJlYWR5 IGNlcnRhaW4gdGhhdCBpcyBub3QgaWRsZSBzbyB3aHkgbm90IGdvdG8gb3V0Pwo+Cj4gSW4gdGhp cyBjYXNlIEkgY291bGQgYXJndWUgdGhhdCBleHRyYSBwYXRoIGZvciB0aGUganVtcCBpcyBub3Qg d29ydGggaXQuCj4gSXQgc2F2ZXMgYSBtbWlvIHJlYWQsIHllcywgYnV0IHdpbGwgYW55IG9uZSBu b3RpY2U/CmFuZCBvbmUgd3JpdGUgOlAKCj4gSXQgYm9pbHMgZG93biB0byBpcyBpdCBlYXNpZXIg dG8gcmVhZCBhczoKPgoKU29sZC4gSXQgaXMgZWFzaWVyIHRvIHJlYWQgYXMgaXMuIDMvMyBpcwoK UmV2aWV3ZWQtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAaW50ZWwuY29tPgoKPiBz dGF0aWMgYm9vbCByaW5nX2lzX2lkbGUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ IHsKPiAgICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGVuZ2luZS0+ aTkxNTsKPiAgICAgICAgIGJvb2wgaWRsZSA9IGZhbHNlOwo+Cj4gICAgICAgICBpbnRlbF9ydW50 aW1lX3BtX2dldChkZXZfcHJpdik7Cj4KPiAgICAgICAgIC8qIEZpcnN0IGNoZWNrIHRoYXQgbm8g Y29tbWFuZHMgYXJlIGxlZnQgaW4gdGhlIHJpbmcgKi8KPiAgICAgICAgIGlmICgoSTkxNV9SRUFE X0hFQUQoZW5naW5lKSAmIEhFQURfQUREUikgIT0KPiAgICAgICAgICAgICAoSTkxNV9SRUFEX1RB SUwoZW5naW5lKSAmIFRBSUxfQUREUikpCj4gICAgICAgICAgICAgICAgIGdvdG8gYnVzeTsKPgo+ ICAgICAgICAgLyogTm8gYml0IGZvciBnZW4yLCBzbyBhc3N1bWUgdGhlIENTIHBhcnNlciBpcyBp ZGxlICovCj4gICAgICAgICBpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+IDIgJiYgIShJOTE1X1JF QURfTU9ERShlbmdpbmUpICYgTU9ERV9JRExFKSkKPiAgICAgICAgICAgICAgICAgZ290byBidXN5 Owo+Cj4gICAgICAgICBpZGxlID0gdHJ1ZTsKPiBidXN5Ogo+ICAgICAgICAgaW50ZWxfcnVudGlt ZV9wbV9wdXQoZGV2X3ByaXYpOwo+Cj4gICAgICAgICByZXR1cm4gaWRsZTsKPiB9Cj4KPiBGaXJz dCBpbnN0aW5jdCB3b3VsZCBiZSBubyBiZWNhdXNlIG9mIHRoZSBnb3RvLgo+IC1DaHJpcwo+Cj4g LS0gCj4gQ2hyaXMgV2lsc29uLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRyZQpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK