All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Daniel Berrange <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] .gdbinit: load QEMU sub-commands when gdb starts
Date: Wed, 17 May 2017 14:55:24 +0100	[thread overview]
Message-ID: <87lgpv37w3.fsf@linaro.org> (raw)
In-Reply-To: <20170517124042.1430-1-stefanha@redhat.com>


Stefan Hajnoczi <stefanha@redhat.com> writes:

> The scripts/qemu-gdb.py file is not easily discoverable.  Add a .gdbinit
> file so GDB either loads qemu-gdb.py automatically or prints a message
> informing the user how to enable them (some systems disable ./.gdbinit
> loading for security reasons).
>
> Symlink .gdbinit and the scripts directory in order to make out-of-tree
> builds work.  The scripts directory is used to find the qemu-gdb.py file
> specified by a relative path in .gdbinit.
>
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
> v2:
>  * Support out-of-tree builds [Daniel, Markus]
>
>  configure | 1 +
>  .gdbinit  | 8 ++++++++
>  2 files changed, 9 insertions(+)
>  create mode 100644 .gdbinit
>
> diff --git a/configure b/configure
> index 57b5ae6..04f7272 100755
> --- a/configure
> +++ b/configure
> @@ -6382,6 +6382,7 @@ FILES="$FILES pc-bios/spapr-rtas/Makefile"
>  FILES="$FILES pc-bios/s390-ccw/Makefile"
>  FILES="$FILES roms/seabios/Makefile roms/vgabios/Makefile"
>  FILES="$FILES pc-bios/qemu-icon.bmp"
> +FILES="$FILES .gdbinit scripts" # scripts needed by relative path in .gdbinit
>  for bios_file in \
>      $source_path/pc-bios/*.bin \
>      $source_path/pc-bios/*.lid \
> diff --git a/.gdbinit b/.gdbinit
> new file mode 100644
> index 0000000..9d322fc
> --- /dev/null
> +++ b/.gdbinit
> @@ -0,0 +1,8 @@
> +# GDB may have ./.gdbinit loading disabled by default.  In that case you can
> +# follow the instructions it prints.  They boil down to adding the following to
> +# your home directory's ~/.gdbinit file:
> +#
> +#   add-auto-load-safe-path /path/to/qemu/.gdbinit
> +
> +# Load QEMU-specific sub-commands and settings
> +source scripts/qemu-gdb.py


--
Alex Bennée

  reply	other threads:[~2017-05-17 13:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17 12:40 [Qemu-devel] [PATCH v2] .gdbinit: load QEMU sub-commands when gdb starts Stefan Hajnoczi
2017-05-17 13:55 ` Alex Bennée [this message]
2017-05-17 15:07 ` Eric Blake
2017-05-17 17:23 ` Philippe Mathieu-Daudé
2017-05-18  9:10 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgpv37w3.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.