From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 4/4] drm/i915/psr: Account for sink CRC raciness on some panels Date: Mon, 08 May 2017 12:12:47 +0300 Message-ID: <87lgq7af00.fsf@intel.com> References: <1494018126-30190-1-git-send-email-jim.bride@linux.intel.com> <1494018126-30190-5-git-send-email-jim.bride@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40DF26E203 for ; Mon, 8 May 2017 09:13:02 +0000 (UTC) In-Reply-To: <1494018126-30190-5-git-send-email-jim.bride@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jim Bride , intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gU2F0LCAwNiBNYXkgMjAxNywgSmltIEJyaWRlIDxqaW0uYnJpZGVAbGludXguaW50ZWwuY29t PiB3cm90ZToKPiBBY2NvcmRpbmcgdG8gdGhlIGVEUCBzcGVjLCB3aGVuIHRoZSBjb3VudCBmaWVs ZCBpbiBURVNUX1NJTktfTUlTQwo+IGluY3JlbWVudHMgdGhlbiB0aGUgc2l4IGJ5dGVzIG9mIHNp bmsgQ1JDIGluZm9ybWF0aW9uIGluIHRoZSBEUENECj4gc2hvdWxkIGJlIHZhbGlkLiAgVW5mb3J0 dW5hdGVseSwgdGhpcyBkb2Vzbid0IHNlZW0gdG8gYmUgdGhlIGNhc2UKPiBvbiBzb21lIHBhbmVs cywgYW5kIGFzIGEgcmVzdWx0IHdlIGdldCBzb21lIGluY29ycmVjdCBhbmQgaW5jb25zaXN0ZW50 Cj4gdmFsdWVzIGZyb20gdGhlIHNpbmsgQ1JDIERQQ0QgbG9jYXRpb25zIGF0IHRpbWVzLiAgVGhp cyBwcm9ibGVtIGV4aGliaXRzCj4gaXRzZWxmIG1vcmUgb24gZmFzdGVyIHByb2Nlc3NvcnMgKHJl bGF0aXZlIGZhaWx1cmUgcmF0ZXMgSFNXIDwgU0tMIDwgS0JMLikKPiBJbiBvcmRlciB0byB0cnkg YW5kIGFjY291bnQgZm9yIHRoaXMsIHdlIHRyeSBhIGxvdCBoYXJkZXIgdG8gcmVhZCB0aGUgc2lu awo+IENSQyB1bnRpbCB3ZSBnZXQgY29uc2lzdGVudCB2YWx1ZXMgdHdpY2UgaW4gYSByb3cgYmVm b3JlIHJldHVybmluZyB3aGF0IHdlCj4gcmVhZCBhbmQgZGVsYXkgZm9yIGEgdGltZSBiZWZvcmUg dHJ5aW5nIHRvIHJlYWQuICBXZSBzdGlsbCBzZWUgc29tZQo+IG9jY2FzaW9uYWwgZmFpbHVyZXMs IGJ1dCByZWFkaW5nIHRoZSBzaW5rIENSQyBpcyBtdWNoIG1vcmUgcmVsaWFibGUsCj4gcGFydGlj dWxhcmx5IG9uIFNLTCBhbmQgS0JMLCB3aXRoIHRoZXNlIGNoYW5nZXMgdGhhbiB3aXRob3V0LgoK UmV0cnlpbmcgc2VlbXMgbGlrZSBhIGdvb2QgaWRlYS4gQnV0IHRoaXMgcGF0Y2ggcmV0cmllcyB1 cCB0byAzNiB0aW1lcwppZiB0aGUgdHdvIGNvbnNlY3V0aXZlIHJlYWRzIGRvbid0IG1hdGNoLCB3 aGljaCBpcyBleGNlc3NpdmUuCgpUaGUgc2xlZXBzIHNob3VsZCBwcm9iYWJseSBiZSBhIHNlcGFy YXRlIGNoYW5nZS4gQWxzbyBub3QgaGFwcHkgYWJvdXQKdGhlIG1hZ2ljIG51bWJlcnMgdGhlcmUu CgpBbHNvLCB0aGVyZSBhcmUgcGxlbnR5IG9mIHdoYXQgc2VlbSBsaWtlIHVucmVsYXRlZCBjaGFu Z2VzLiBXaGl0ZXNwYWNlLApkZWJ1ZyBsb2dnaW5nLCBlcnJvciBjaGVja2luZywgZXRjLgoKCkJS LApKYW5pLgoKCj4KPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ IENjOiBQYXVsbyBaYW5vbmkgPHBhdWxvLnIuemFub25pQGludGVsLmNvbT4KPiBTaWduZWQtb2Zm LWJ5OiBKaW0gQnJpZGUgPGppbS5icmlkZUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jIHwgMTQgKysrKysrKy0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMgICAgIHwgNTcgKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKystLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDYxIGluc2VydGlvbnMoKyksIDEwIGRl bGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVi dWdmcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBpbmRleCA4NzBj NDcwLi40OTAyNDczIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVi dWdmcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBAQCAt MjcxOCw3ICsyNzE4LDcgQEAgc3RhdGljIGludCBpOTE1X3NpbmtfY3JjKHN0cnVjdCBzZXFfZmls ZSAqbSwgdm9pZCAqZGF0YSkKPiAgCXN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvcjsK PiAgCXN0cnVjdCBkcm1fY29ubmVjdG9yX2xpc3RfaXRlciBjb25uX2l0ZXI7Cj4gIAlzdHJ1Y3Qg aW50ZWxfZHAgKmludGVsX2RwID0gTlVMTDsKPiAtCWludCByZXQ7Cj4gKwlpbnQgcmV0LCB0cmll cyA9IDY7Cj4gIAl1OCBjcmNbNl07Cj4gIAo+ICAJZHJtX21vZGVzZXRfbG9ja19hbGwoZGV2KTsK PiBAQCAtMjczOCw5ICsyNzM4LDE3IEBAIHN0YXRpYyBpbnQgaTkxNV9zaW5rX2NyYyhzdHJ1Y3Qg c2VxX2ZpbGUgKm0sIHZvaWQgKmRhdGEpCj4gIAo+ICAJCWludGVsX2RwID0gZW5jX3RvX2ludGVs X2RwKGNvbm5lY3Rvci0+YmFzZS5zdGF0ZS0+YmVzdF9lbmNvZGVyKTsKPiAgCj4gLQkJcmV0ID0g aW50ZWxfZHBfc2lua19jcmMoaW50ZWxfZHAsIGNyYyk7Cj4gLQkJaWYgKHJldCkKPiArCQltZW1z ZXQoY3JjLCAwLCA2KTsKPiArCQlkbyB7Cj4gKwkJCXJldCA9IGludGVsX2RwX3NpbmtfY3JjKGlu dGVsX2RwLCBjcmMpOwo+ICsJCQlpZiAocmV0ID09IC1FVElNRURPVVQpCj4gKwkJCQl1c2xlZXBf cmFuZ2UoNTAwLCA3MDApOwo+ICsJCX0gd2hpbGUgKChyZXQgPT0gLUVUSU1FRE9VVCkgJiYgLS10 cmllcyk7Cj4gKwo+ICsJCWlmIChyZXQgIT0gMCkgewo+ICsJCQlzZXFfcHJpbnRmKG0sICIwMDAw MDAwMDAwMDBcbiIpOwo+ICAJCQlnb3RvIG91dDsKPiArCQl9Cj4gIAo+ICAJCXNlcV9wcmludGYo bSwgIiUwMnglMDJ4JTAyeCUwMnglMDJ4JTAyeFxuIiwKPiAgCQkJICAgY3JjWzBdLCBjcmNbMV0s IGNyY1syXSwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCAwNmI4YmQ0Li4yMTdiYzA2 IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gQEAgLTM4NzcsMTMgKzM4NzcsMTUgQEAg c3RhdGljIGludCBpbnRlbF9kcF9zaW5rX2NyY19zdG9wKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxf ZHApCj4gIAo+ICAJZG8gewo+ICAJCWludGVsX3dhaXRfZm9yX3ZibGFuayhkZXZfcHJpdiwgaW50 ZWxfY3J0Yy0+cGlwZSk7Cj4gLQo+ICsJCXVzbGVlcF9yYW5nZSgxNjcwMCwgMTcwMDApOwo+ICAJ CWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwKPiAgCQkJCSAgICAgIERQX1RF U1RfU0lOS19NSVNDLCAmYnVmKSA8IDApIHsKPiArCQkJRFJNX0RFQlVHX0tNUygiQ291bGQgbm90 IHJlYWQgVEVTVF9TSU5LX01JU0NcbiIpOwo+ICAJCQlyZXQgPSAtRUlPOwo+ICAJCQlnb3RvIG91 dDsKPiAgCQl9Cj4gIAkJY291bnQgPSBidWYgJiBEUF9URVNUX0NPVU5UX01BU0s7Cj4gKwkJRFJN X0RFQlVHX0tNUygiUFNSIGNvdW50IGlzICVkXG4iLCBjb3VudCk7Cj4gIAl9IHdoaWxlICgtLWF0 dGVtcHRzICYmIGNvdW50KTsKPiAgCj4gIAlpZiAoYXR0ZW1wdHMgPT0gMCkgewo+IEBAIC0zOTI4 LDYgKzM5MzAsOCBAQCBzdGF0aWMgaW50IGludGVsX2RwX3NpbmtfY3JjX3N0YXJ0KHN0cnVjdCBp bnRlbF9kcCAqaW50ZWxfZHApCj4gIAl9Cj4gIAo+ICAJaW50ZWxfd2FpdF9mb3JfdmJsYW5rKGRl dl9wcml2LCBpbnRlbF9jcnRjLT5waXBlKTsKPiArCXVzbGVlcF9yYW5nZSgxNjcwMCwgMTcwMDAp Owo+ICsJRFJNX0RFQlVHX0tNUygiUFNSIFN1Y2Nlc3NmdWxseSBzdGFydGVkIHNpbmsgQ1JDXG4i KTsKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IEBAIC0zOTM5LDIxICszOTQzLDMwIEBAIGludCBp bnRlbF9kcF9zaW5rX2NyYyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCB1OCAqY3JjKQo+ICAJ dTggYnVmOwo+ICAJaW50IGNvdW50LCByZXQ7Cj4gIAlpbnQgYXR0ZW1wdHMgPSA2Owo+ICsJdTgg b2xkX2NyY1s2XTsKPiArCj4gKwlpZiAoY3JjICE9IE5VTEwpCj4gKwkJbWVtc2V0KGNyYywgMCwg Nik7Cj4gKwllbHNlCj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+ICAJcmV0ID0gaW50ZWxfZHBf c2lua19jcmNfc3RhcnQoaW50ZWxfZHApOwo+IC0JaWYgKHJldCkKPiArCWlmIChyZXQpIHsKPiAr CQlEUk1fREVCVUdfS01TKCJDb3VsZCBub3Qgc3RhcnQgc2luayBjcmM7IHJldCAlZFxuIiwgcmV0 KTsKPiAgCQlyZXR1cm4gcmV0Owo+ICsJfQo+ICAKPiAgCWRvIHsKPiAgCQlpbnRlbF93YWl0X2Zv cl92YmxhbmsoZGV2X3ByaXYsIGludGVsX2NydGMtPnBpcGUpOwo+ICsJCXVzbGVlcF9yYW5nZSgx NjcwMCwgMTcwMDApOwo+ICAKPiAgCQlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5h dXgsCj4gIAkJCQkgICAgICBEUF9URVNUX1NJTktfTUlTQywgJmJ1ZikgPCAwKSB7Cj4gKwkJCURS TV9ERUJVR19LTVMoIkNvdW5kIG5vdCByZWFkIFRFU1RfU0lOS19NSVNDXG4iKTsKPiAgCQkJcmV0 ID0gLUVJTzsKPiAgCQkJZ290byBzdG9wOwo+ICAJCX0KPiAgCQljb3VudCA9IGJ1ZiAmIERQX1RF U1RfQ09VTlRfTUFTSzsKPiAtCj4gIAl9IHdoaWxlICgtLWF0dGVtcHRzICYmIGNvdW50ID09IDAp Owo+ICAKPiAgCWlmIChhdHRlbXB0cyA9PSAwKSB7Cj4gQEAgLTM5NjIsMTEgKzM5NzUsNDEgQEAg aW50IGludGVsX2RwX3NpbmtfY3JjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHU4ICpjcmMp Cj4gIAkJZ290byBzdG9wOwo+ICAJfQo+ICAKPiAtCWlmIChkcm1fZHBfZHBjZF9yZWFkKCZpbnRl bF9kcC0+YXV4LCBEUF9URVNUX0NSQ19SX0NSLCBjcmMsIDYpIDwgMCkgewo+IC0JCXJldCA9IC1F SU87Cj4gLQkJZ290byBzdG9wOwo+IC0JfQo+ICsJYXR0ZW1wdHMgPSA2Owo+ICsJbWVtc2V0KG9s ZF9jcmMsIDB4RkYsIDYpOwo+ICsJZG8gewo+ICsJCWludGVsX3dhaXRfZm9yX3ZibGFuayhkZXZf cHJpdiwgaW50ZWxfY3J0Yy0+cGlwZSk7Cj4gKwkJdXNsZWVwX3JhbmdlKDE2NTAwLCAxNzAwMCk7 Cj4gKwkJaWYgKGRybV9kcF9kcGNkX3JlYWQoJmludGVsX2RwLT5hdXgsIERQX1RFU1RfQ1JDX1Jf Q1IsCj4gKwkJCQkgICAgIGNyYywgNikgPCAwKSB7Cj4gKwkJCURSTV9ERUJVR19LTVMoIkNvdWxk IG5vdCByZWFkIHNpbmsgY3JjXG4iKTsKPiArCQkJcmV0ID0gLUVJTzsKPiArCQkJZ290byBzdG9w Owo+ICsJCX0KPiArCj4gKwkJaWYgKG1lbWNtcChvbGRfY3JjLCBjcmMsIDYpID09IDApIHsKPiAr CQkJRFJNX0RFQlVHX0tNUygiUFNSIEFjdGl2ZTogJTNzIE1hdGNoaW5nIGNyYyB2YWx1ZXMgZm91 bmQ6Igo+ICsJCQkJICAgICAgIiUwMnglMDJ4JTAyeCUwMnglMDJ4JTAyeFxuIiwKPiArCQkJCSAg ICAgIHllc25vKGRldl9wcml2LT5wc3IuYWN0aXZlKSwKPiArCQkJCSAgICAgIGNyY1swXSwgY3Jj WzFdLCBjcmNbMl0sCj4gKwkJCQkgICAgICBjcmNbM10sIGNyY1s0XSwgY3JjWzVdKTsKPiArCQkJ cmV0ID0gMDsKPiArCQkJZ290byBzdG9wOwo+ICsJCX0gZWxzZSB7Cj4gKwkJCURSTV9ERUJVR19L TVMoIlBTUiBBY3RpdmU6ICUzcyBjcmMgJTAyeCUwMnglMDJ4JTAyeCUwMnglMDJ4ICIKPiArCQkJ CSAgICAgICJkb2Vzbid0IG1hdGNoICIKPiArCQkJCSAgICAgICJwcmV2aW91cyAlMDJ4JTAyeCUw MnglMDJ4JTAyeCUwMnhcbiIsCj4gKwkJCQkgICAgICB5ZXNubyhkZXZfcHJpdi0+cHNyLmFjdGl2 ZSksCj4gKwkJCQkgICAgICBjcmNbMF0sIGNyY1sxXSwgY3JjWzJdLAo+ICsJCQkJICAgICAgY3Jj WzNdLCBjcmNbNF0sIGNyY1s1XSwKPiArCQkJCSAgICAgIG9sZF9jcmNbMF0sIG9sZF9jcmNbMV0s IG9sZF9jcmNbMl0sCj4gKwkJCQkgICAgICBvbGRfY3JjWzNdLCBvbGRfY3JjWzRdLCBvbGRfY3Jj WzVdKTsKPiArCQkJbWVtY3B5KG9sZF9jcmMsIGNyYywgNik7Cj4gKwkJfQo+ICsJfSB3aGlsZSAo LS1hdHRlbXB0cyk7Cj4gIAo+ICsJRFJNX0RFQlVHX0tNUygiRmFpbGVkIHRvIGdldCBDUkMgYWZ0 ZXIgNiBhdHRlbXB0cy5cbiIpOwo+ICsJcmV0ID0gLUVUSU1FRE9VVDsKPiAgc3RvcDoKPiAgCWlu dGVsX2RwX3NpbmtfY3JjX3N0b3AoaW50ZWxfZHApOwo+ICAJcmV0dXJuIHJldDsKCi0tIApKYW5p IE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==