From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cc7o3-000689-4h for ath10k@lists.infradead.org; Fri, 10 Feb 2017 09:47:57 +0000 From: "Valo, Kalle" Subject: Re: [PATCH v3] ath10k: Fix crash during rmmod when probe firmware fails Date: Fri, 10 Feb 2017 09:47:28 +0000 Message-ID: <87lgteidii.fsf@kamboji.qca.qualcomm.com> References: <1482221351-24029-1-git-send-email-mohammed@qca.qualcomm.com> <8760l38dz0.fsf@kamboji.qca.qualcomm.com> <871svr8d83.fsf@kamboji.qca.qualcomm.com> <20170206100448.GA13894@atheros-ThinkPad-T61> In-Reply-To: <20170206100448.GA13894@atheros-ThinkPad-T61> (Mohammed Shafi Shajakhan's message of "Mon, 6 Feb 2017 15:34:48 +0530") Content-Language: en-US MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Mohammed Shafi Shajakhan Cc: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" , "Shajakhan, Mohammed Shafi (Mohammed Shafi)" Mohammed Shafi Shajakhan writes: > the change suggested by you helps, and the device probe, scan > is successful as well. Still good to have this change part of your > basic sanity and regression testing ! Sure. I was sort of expecting that you would send v4 but I haven't seen one so I guess you assumed I send that? :) I'll then submit v4. BTW, just curious but why do you have "during rmmod" in the title? I think I was able to reproduce this crash by removing all firmware files and didn't use rmmod at all. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:4168 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751324AbdBJJsA (ORCPT ); Fri, 10 Feb 2017 04:48:00 -0500 From: "Valo, Kalle" To: Mohammed Shafi Shajakhan CC: "Shajakhan, Mohammed Shafi (Mohammed Shafi)" , "ath10k@lists.infradead.org" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH v3] ath10k: Fix crash during rmmod when probe firmware fails Date: Fri, 10 Feb 2017 09:47:28 +0000 Message-ID: <87lgteidii.fsf@kamboji.qca.qualcomm.com> (sfid-20170210_104809_460087_3C0A2B1A) References: <1482221351-24029-1-git-send-email-mohammed@qca.qualcomm.com> <8760l38dz0.fsf@kamboji.qca.qualcomm.com> <871svr8d83.fsf@kamboji.qca.qualcomm.com> <20170206100448.GA13894@atheros-ThinkPad-T61> In-Reply-To: <20170206100448.GA13894@atheros-ThinkPad-T61> (Mohammed Shafi Shajakhan's message of "Mon, 6 Feb 2017 15:34:48 +0530") Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Mohammed Shafi Shajakhan writes: > the change suggested by you helps, and the device probe, scan > is successful as well. Still good to have this change part of your > basic sanity and regression testing ! Sure. I was sort of expecting that you would send v4 but I haven't seen one so I guess you assumed I send that? :) I'll then submit v4. BTW, just curious but why do you have "during rmmod" in the title? I think I was able to reproduce this crash by removing all firmware files and didn't use rmmod at all. --=20 Kalle Valo=