From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cU8yd-0006J3-FX for qemu-devel@nongnu.org; Thu, 19 Jan 2017 04:25:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cU8yZ-0008LB-MS for qemu-devel@nongnu.org; Thu, 19 Jan 2017 04:25:51 -0500 From: Markus Armbruster References: <20170118161653.19296-1-eblake@redhat.com> <20170118161653.19296-3-eblake@redhat.com> Date: Thu, 19 Jan 2017 10:25:39 +0100 In-Reply-To: <20170118161653.19296-3-eblake@redhat.com> (Eric Blake's message of "Wed, 18 Jan 2017 10:16:49 -0600") Message-ID: <87lgu7flkc.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Jeff Cody , Gerd Hoffmann , Stefano Stabellini , Alberto Garcia , "open list:Block layer core" , Alexander Graf , Anthony Perard , Fam Zheng , Michael Roth , Chrysostomos Nanakos , Stefan Weil , Peter Lieven , "Dr. David Alan Gilbert" , "open list:X86" , Ronnie Sahlberg , Richard Henderson , Kevin Wolf , "Richard W.M. Jones" , Max Reitz , Paolo Bonzini Eric Blake writes: > Quite a few users of qdict_put() were manually wrapping a > non-QObject. We can make such call-sites shorter, by providing > common macros to do the tedious work. Also shorten nearby > qdict_put_obj(,,QOBJECT()) sequences. > > Signed-off-by: Eric Blake > Reviewed-by: Alberto Garcia > > --- > > v2: rebase to current master > > I'm okay if you want me to break this patch into smaller pieces. I guess I'm okay with a single piece, but I'd like to know how you did the conversion. Coccinelle? Manually? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts Date: Thu, 19 Jan 2017 10:25:39 +0100 Message-ID: <87lgu7flkc.fsf@dusky.pond.sub.org> References: <20170118161653.19296-1-eblake@redhat.com> <20170118161653.19296-3-eblake@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170118161653.19296-3-eblake@redhat.com> (Eric Blake's message of "Wed, 18 Jan 2017 10:16:49 -0600") List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Eric Blake Cc: Ronnie Sahlberg , Jeff Cody , qemu-devel@nongnu.org, Alexander Graf , Gerd Hoffmann , Stefano Stabellini , Alberto Garcia , "open list:Block layer core" , Michael Roth , Anthony Perard , Fam Zheng , Chrysostomos Nanakos , Stefan Weil , Peter Lieven , "Dr. David Alan Gilbert" , "open list:X86" , Stefan Hajnoczi , Richard Henderson , Kevin Wolf , "Richard W.M. Jones" , Max Reitz , Paolo Bonzini List-Id: xen-devel@lists.xenproject.org RXJpYyBCbGFrZSA8ZWJsYWtlQHJlZGhhdC5jb20+IHdyaXRlczoKCj4gUXVpdGUgYSBmZXcgdXNl cnMgb2YgcWRpY3RfcHV0KCkgd2VyZSBtYW51YWxseSB3cmFwcGluZyBhCj4gbm9uLVFPYmplY3Qu IFdlIGNhbiBtYWtlIHN1Y2ggY2FsbC1zaXRlcyBzaG9ydGVyLCBieSBwcm92aWRpbmcKPiBjb21t b24gbWFjcm9zIHRvIGRvIHRoZSB0ZWRpb3VzIHdvcmsuICBBbHNvIHNob3J0ZW4gbmVhcmJ5Cj4g cWRpY3RfcHV0X29iaigsLFFPQkpFQ1QoKSkgc2VxdWVuY2VzLgo+Cj4gU2lnbmVkLW9mZi1ieTog RXJpYyBCbGFrZSA8ZWJsYWtlQHJlZGhhdC5jb20+Cj4gUmV2aWV3ZWQtYnk6IEFsYmVydG8gR2Fy Y2lhIDxiZXJ0b0BpZ2FsaWEuY29tPgo+Cj4gLS0tCj4KPiB2MjogcmViYXNlIHRvIGN1cnJlbnQg bWFzdGVyCj4KPiBJJ20gb2theSBpZiB5b3Ugd2FudCBtZSB0byBicmVhayB0aGlzIHBhdGNoIGlu dG8gc21hbGxlciBwaWVjZXMuCgpJIGd1ZXNzIEknbSBva2F5IHdpdGggYSBzaW5nbGUgcGllY2Us IGJ1dCBJJ2QgbGlrZSB0byBrbm93IGhvdyB5b3UgZGlkCnRoZSBjb252ZXJzaW9uLiAgQ29jY2lu ZWxsZT8gIE1hbnVhbGx5PwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpo dHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==