From: krisman@linux.vnet.ibm.com (Gabriel Krisman Bertazi)
Subject: [PATCH] NVMe: Call nvme_pci_disable on error path of nvme_probe_work
Date: Mon, 14 Nov 2016 11:21:18 -0200 [thread overview]
Message-ID: <87lgwm42pd.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <62459369-5c23-8819-d360-58892b4ff1fc@amazon.com> (Rashika Kheria's message of "Mon, 14 Nov 2016 09:57:27 +0100")
Rashika Kheria <rashika at amazon.com> writes:
> Hi everyone,
>
> Could you please review the following patch? This solves a regression in
> stable 4.4.y tree.
>
>
> On 11/12/16 18:41, Christoph Hellwig wrote:
>> Bouncing to Keith and linux-nvme
>>
>> On Tue, Nov 01, 2016@04:27:56PM +0100, Rashika Kheria wrote:
>>> Commit d5537e988eec ("NVMe: Don't unmap controller registers on reset"),
>>> introduced a regression in which it did not replace nvme_dev_unmap()
>>> with nvme_pci_disable() in the error path of nvme_probe_work().
>>>
Hmm, the original commit had the same issue, which I think was fixed
upstream by f58944e265d4 ("NVMe: Simplify device reset failure"), which
was included in 4.5-rc7. Isn't the upstream commit a better candidate
for -stable? It's a bit larger but the commit message says it may
prevent other issues too.
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2016-11-14 13:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 15:27 [PATCH] NVMe: Call nvme_pci_disable on error path of nvme_probe_work Rashika Kheria
2016-11-12 17:41 ` Christoph Hellwig
2016-11-14 8:57 ` Rashika Kheria
2016-11-14 13:21 ` Gabriel Krisman Bertazi [this message]
2016-11-14 14:02 ` Rashika Kheria
2016-11-14 18:47 ` Keith Busch
2016-12-22 13:16 ` Fw: " Kheria, Rashika
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgwm42pd.fsf@linux.vnet.ibm.com \
--to=krisman@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.