From: Juan Quintela <quintela@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com,
famz@redhat.com, stefanha@redhat.com, amit.shah@redhat.com,
mreitz@redhat.com, kwolf@redhat.com, peter.maydell@linaro.org,
dgilbert@redhat.com, den@openvz.org, jsnow@redhat.com,
lirans@il.ibm.com
Subject: Re: [Qemu-devel] [PATCH 03/18] migration: split common postcopy out of ram postcopy
Date: Fri, 04 Nov 2016 13:49:44 +0100 [thread overview]
Message-ID: <87lgwzo1ef.fsf@emacs.mitica> (raw)
In-Reply-To: <1471343175-14945-4-git-send-email-vsementsov@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Tue, 16 Aug 2016 13:26:00 +0300")
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> wrote:
> Split common postcopy staff from ram postcopy staff.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index d2efeeb..cce542f 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -73,7 +73,7 @@ static struct mig_cmd_args {
> [MIG_CMD_INVALID] = { .len = -1, .name = "INVALID" },
> [MIG_CMD_OPEN_RETURN_PATH] = { .len = 0, .name = "OPEN_RETURN_PATH" },
> [MIG_CMD_PING] = { .len = sizeof(uint32_t), .name = "PING" },
> - [MIG_CMD_POSTCOPY_ADVISE] = { .len = 16, .name = "POSTCOPY_ADVISE" },
> + [MIG_CMD_POSTCOPY_ADVISE] = { .len = -1, .name = "POSTCOPY_ADVISE" },
Not sure if it is a good idea to change postcopy_advise or create a new
one.
Dave, can you comment?
next prev parent reply other threads:[~2016-11-04 12:49 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 10:25 [Qemu-devel] [PATCH 00/18] Dirty bitmaps postcopy migration Vladimir Sementsov-Ogievskiy
2016-08-16 10:25 ` [Qemu-devel] [PATCH 01/18] migration: add has_postcopy savevm handler Vladimir Sementsov-Ogievskiy
2016-11-04 12:32 ` Juan Quintela
2016-08-16 10:25 ` [Qemu-devel] [PATCH 02/18] migration: fix ram_save_pending Vladimir Sementsov-Ogievskiy
2016-08-17 12:12 ` Dr. David Alan Gilbert
2016-11-04 12:32 ` Juan Quintela
2016-08-16 10:26 ` [Qemu-devel] [PATCH 03/18] migration: split common postcopy out of ram postcopy Vladimir Sementsov-Ogievskiy
2016-11-04 12:49 ` Juan Quintela [this message]
2016-08-16 10:26 ` [Qemu-devel] [PATCH 04/18] migration: introduce postcopy-only pending Vladimir Sementsov-Ogievskiy
2016-11-04 12:46 ` Juan Quintela
2016-11-21 11:05 ` Vladimir Sementsov-Ogievskiy
2016-08-16 10:26 ` [Qemu-devel] [PATCH 05/18] block: add bdrv_next_dirty_bitmap() Vladimir Sementsov-Ogievskiy
2016-08-16 10:26 ` [Qemu-devel] [PATCH 06/18] block: add bdrv_dirty_bitmap_enable_successor() Vladimir Sementsov-Ogievskiy
2016-08-16 10:26 ` [Qemu-devel] [PATCH 07/18] qapi: add dirty-bitmaps migration capability Vladimir Sementsov-Ogievskiy
2016-08-17 9:06 ` Fam Zheng
2016-08-16 10:26 ` [Qemu-devel] [PATCH 08/18] block/dirty-bitmap: add bdrv_dirty_bitmap_release_successor Vladimir Sementsov-Ogievskiy
2016-08-16 10:26 ` [Qemu-devel] [PATCH 09/18] migration: include migrate_dirty_bitmaps in migrate_postcopy Vladimir Sementsov-Ogievskiy
2016-08-16 10:26 ` [Qemu-devel] [PATCH 10/18] migration/qemu-file: add qemu_put_counted_string() Vladimir Sementsov-Ogievskiy
2016-08-17 9:09 ` Fam Zheng
2016-11-21 5:23 ` Vladimir Sementsov-Ogievskiy
2016-08-16 10:26 ` [Qemu-devel] [PATCH 11/18] migration: add is_active_iterate handler Vladimir Sementsov-Ogievskiy
2016-08-16 10:26 ` [Qemu-devel] [PATCH 12/18] migration: add postcopy migration of dirty bitmaps Vladimir Sementsov-Ogievskiy
2016-11-04 13:09 ` Juan Quintela
2016-11-21 6:35 ` Vladimir Sementsov-Ogievskiy
2016-08-16 10:26 ` [Qemu-devel] [PATCH 13/18] iotests: maintain several vms in test Vladimir Sementsov-Ogievskiy
2016-08-16 10:26 ` [Qemu-devel] [PATCH 14/18] iotests: add add_incoming_migration to VM class Vladimir Sementsov-Ogievskiy
2016-08-16 10:26 ` [Qemu-devel] [PATCH 15/18] qapi: add md5 checksum of last dirty bitmap level to query-block Vladimir Sementsov-Ogievskiy
2016-08-16 10:37 ` Daniel P. Berrange
2016-08-16 10:42 ` Daniel P. Berrange
2016-08-16 10:26 ` [Qemu-devel] [PATCH 16/18] iotests: add default node-name Vladimir Sementsov-Ogievskiy
2016-08-17 9:19 ` Fam Zheng
2016-08-16 10:26 ` [Qemu-devel] [PATCH 17/18] iotests: add dirty bitmap migration test 169 Vladimir Sementsov-Ogievskiy
2016-08-17 11:35 ` Fam Zheng
2016-08-16 10:26 ` [Qemu-devel] [PATCH 18/18] iotests: add dirty bitmap postcopy test Vladimir Sementsov-Ogievskiy
2016-08-17 11:47 ` [Qemu-devel] [PATCH 00/18] Dirty bitmaps postcopy migration Fam Zheng
2016-08-17 12:15 ` Vladimir Sementsov-Ogievskiy
2016-08-20 11:21 ` Fam Zheng
2016-08-17 12:35 ` Dr. David Alan Gilbert
2016-08-17 13:54 ` Vladimir Sementsov-Ogievskiy
2016-09-30 11:00 ` Vladimir Sementsov-Ogievskiy
2016-10-12 11:32 ` Vladimir Sementsov-Ogievskiy
2016-10-25 13:04 ` [Qemu-devel] ping " Vladimir Sementsov-Ogievskiy
2016-11-02 11:13 ` Stefan Hajnoczi
2016-11-02 12:05 ` Denis V. Lunev
2016-11-04 13:12 ` Juan Quintela
2016-11-04 13:27 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgwzo1ef.fsf@emacs.mitica \
--to=quintela@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=lirans@il.ibm.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.