From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mga11.intel.com ([192.55.52.93]:63814 "EHLO mga11.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753628AbcJCQJG (ORCPT <rfc822;stable@vger.kernel.org>);
        Mon, 3 Oct 2016 12:09:06 -0400
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: ville.syrjala@linux.intel.com, linux-usb@vger.kernel.org
Cc: stable@vger.kernel.org,
        Ville =?utf-8?B?U3lyasOkbMOk?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"
In-Reply-To: <1475504282-13268-1-git-send-email-ville.syrjala@linux.intel.com>
References: <1475504282-13268-1-git-send-email-ville.syrjala@linux.intel.com>
Date: Mon, 03 Oct 2016 19:08:43 +0300
Message-ID: <87lgy5za7o.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>


Hi,

ville.syrjala@linux.intel.com writes:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> This reverts commit 55a0237f8f47957163125e20ee9260538c5c341c.
>
> commit  55a0237f8f47 ("usb: dwc3: gadget: use allocated/queued reqs for
> LST bit") causes my BYT FFRD8 with g_ether to behave poorly. ssh/scp
> is very sluggish and can even stall entirely. Revert cures it.
>
> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reverting that commit is not the best idea. Let's start with the usual:

- Kernel version
- dmesg on both sides (host and device)
- dwc3 tracepoints:

# mkdir -p /t
# mount -t tracefs none /t
# echo 8192 > /t/buffer_size_kb
# echo 1 > /t/events/dwc3/enable
# echo 0 > /t/events/dwc3/dwc3_readl/enable
# echo 0 > /t/events/dwc3/dwc3_writel/enable

This should be enough to tell me what's really going on.

-- 
balbi