From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44780)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1bm1vl-0005ih-0M
	for qemu-devel@nongnu.org; Mon, 19 Sep 2016 13:00:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1bm1vf-0006Tr-WE
	for qemu-devel@nongnu.org; Mon, 19 Sep 2016 13:00:32 -0400
Received: from roura.ac.upc.es ([147.83.33.10]:51381)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1bm1vf-0006TJ-KF
	for qemu-devel@nongnu.org; Mon, 19 Sep 2016 13:00:27 -0400
From: =?utf-8?Q?Llu=C3=ADs_Vilanova?= <vilanova@ac.upc.edu>
References: <1474296549-29171-1-git-send-email-berrange@redhat.com>
	<1474296549-29171-4-git-send-email-berrange@redhat.com>
Date: Mon, 19 Sep 2016 19:00:26 +0200
In-Reply-To: <1474296549-29171-4-git-send-email-berrange@redhat.com> (Daniel
	P. Berrange's message of "Mon, 19 Sep 2016 15:48:54 +0100")
Message-ID: <87lgynakph.fsf@fimbulvetr.bsc.es>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v3 03/18] trace: remove some now unused
 functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Daniel P Berrange writes:

> The trace_event_count, trace_event_id and
> trace_event_pattern methods are no longer required
> now that everything is using the iterator APIs

> The trace_event_set_state and trace_event_set_vcpu_state
> macros were also unused.

Wouldn't it make more sense to fold the removal of trace_event_pattern() into
the previous patch?

Thanks,
  Lluis