All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Jiri Kosina <jikos@kernel.org>, Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Jessica Yu <jeyu@redhat.com>, Miroslav Benes <mbenes@suse.cz>,
	Petr Mladek <pmladek@suse.com>,
	linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
	Chunyu Hu <chuhu@redhat.com>
Subject: Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific
Date: Thu, 25 Aug 2016 13:44:10 +0930	[thread overview]
Message-ID: <87lgzleb8t.fsf@rustcorp.com.au> (raw)
In-Reply-To: <alpine.LNX.2.00.1608250252380.22028@cbobk.fhfr.pm>

Jiri Kosina <jikos@kernel.org> writes:
> On Wed, 24 Aug 2016, Josh Poimboeuf wrote:
>
>> There's no reliable way to determine which module tainted the kernel
>> with CONFIG_LIVEPATCH.  For example, /sys/module/<klp module>/taint
>> doesn't report it.  Neither does the "mod -t" command in the crash tool.
>> 
>> Make it crystal clear who the guilty party is by converting
>> CONFIG_LIVEPATCH to a module taint flag.
>> 
>> This changes the behavior a bit: now the the flag gets set when the
>> module is loaded, rather than when it's enabled.
>> 
>> Reviewed-by: Chunyu Hu <chuhu@redhat.com>
>> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
>
> I like this change.
>
> Rusty, in case you're okay with it as well, could you please either 
> provide your Ack so that I could take it through livepatching.git? 
> Alternatively, if you prefer to merge this through your tree, please feel 
> free to add

Happy to leave it to you :)

Acked-by: Rusty Russell <rusty@rustcorp.com.au>

Thanks,
Rusty.

  reply	other threads:[~2016-08-25 11:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24 21:33 [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific Josh Poimboeuf
2016-08-24 21:43 ` Josh Poimboeuf
2016-08-25  0:54 ` Jiri Kosina
2016-08-25  4:14   ` Rusty Russell [this message]
2016-08-25  2:53 ` Jessica Yu
2016-08-25  3:23 ` [PATCH] " Josh Poimboeuf
2016-08-25  6:40 ` kbuild test robot
2016-08-25  7:46 ` Petr Mladek
2016-08-25 12:31   ` Josh Poimboeuf
2016-08-25 14:25 ` Miroslav Benes
2016-08-25 14:42   ` Josh Poimboeuf
2016-08-25 14:47     ` Miroslav Benes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgzleb8t.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=chuhu@redhat.com \
    --cc=jeyu@redhat.com \
    --cc=jikos@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.