From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVdGV-0005Wd-So for qemu-devel@nongnu.org; Fri, 05 Aug 2016 07:26:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVdGT-0007W6-RR for qemu-devel@nongnu.org; Fri, 05 Aug 2016 07:26:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVdGT-0007W2-LX for qemu-devel@nongnu.org; Fri, 05 Aug 2016 07:26:09 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4C95581254 for ; Fri, 5 Aug 2016 11:26:09 +0000 (UTC) From: Markus Armbruster References: <20160805082421.21994-1-marcandre.lureau@redhat.com> <20160805082421.21994-6-marcandre.lureau@redhat.com> Date: Fri, 05 Aug 2016 13:26:07 +0200 In-Reply-To: <20160805082421.21994-6-marcandre.lureau@redhat.com> (marcandre lureau's message of "Fri, 5 Aug 2016 12:23:50 +0400") Message-ID: <87lh0bzcc0.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.7 v4 05/36] qga: free remaining leaking state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com Cc: qemu-devel@nongnu.org, pbonzini@redhat.com Copying maintainer. marcandre.lureau@redhat.com writes: > From: Marc-Andr=C3=A9 Lureau > > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > qga/guest-agent-command-state.c | 6 ++++++ > qga/guest-agent-core.h | 1 + > qga/main.c | 6 ++++++ > 3 files changed, 13 insertions(+) > > diff --git a/qga/guest-agent-command-state.c b/qga/guest-agent-command-st= ate.c > index 4de229c..e609d32 100644 > --- a/qga/guest-agent-command-state.c > +++ b/qga/guest-agent-command-state.c > @@ -71,3 +71,9 @@ GACommandState *ga_command_state_new(void) > cs->groups =3D NULL; > return cs; > } > + > +void ga_command_state_free(GACommandState *cs) > +{ > + g_slist_free_full(cs->groups, g_free); > + g_free(cs); > +} > diff --git a/qga/guest-agent-core.h b/qga/guest-agent-core.h > index 0a49516..63e9d39 100644 > --- a/qga/guest-agent-core.h > +++ b/qga/guest-agent-core.h > @@ -28,6 +28,7 @@ void ga_command_state_add(GACommandState *cs, > void ga_command_state_init_all(GACommandState *cs); > void ga_command_state_cleanup_all(GACommandState *cs); > GACommandState *ga_command_state_new(void); > +void ga_command_state_free(GACommandState *cs); > bool ga_logging_enabled(GAState *s); > void ga_disable_logging(GAState *s); > void ga_enable_logging(GAState *s); > diff --git a/qga/main.c b/qga/main.c > index bb48214..0b9d04e 100644 > --- a/qga/main.c > +++ b/qga/main.c > @@ -1371,6 +1371,8 @@ int main(int argc, char **argv) > end: > if (s->command_state) { > ga_command_state_cleanup_all(s->command_state); > + ga_command_state_free(s->command_state); > + json_message_parser_destroy(&s->parser); > } > if (s->channel) { > ga_channel_free(s->channel); > @@ -1383,6 +1385,10 @@ end: > } >=20=20 > config_free(config); > + if (s->main_loop) { > + g_main_loop_unref(s->main_loop); > + } > + g_free(s); >=20=20 > return ret; > }