From: Markus Armbruster <armbru@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 10/10] machine: Skip global registration for non-existing classes
Date: Thu, 23 Jun 2016 18:24:13 +0200 [thread overview]
Message-ID: <87lh1v27rm.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20160623115502.GW2048@thinpad.lan.raisama.net> (Eduardo Habkost's message of "Thu, 23 Jun 2016 08:55:02 -0300")
Eduardo Habkost <ehabkost@redhat.com> writes:
> On Thu, Jun 23, 2016 at 10:26:49AM +0200, Markus Armbruster wrote:
>> Eduardo Habkost <ehabkost@redhat.com> writes:
>>
>> > MachineClass::compat_props may point to class names that are not
>> > compiled into the QEMU binary. Skip registering those as global
>> > properties. This will allow the qdev global property code to
>> > implement stricter checks on the global property values in the
>> > future.
>> >
>> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>>
>> Not sure what those stricter checks might be, but that's okay.
>
> I would like to make qdev_prop_register_global() validate the
> class and property names. It should be doable for the
> !cannot_destroy_with_object_finalize_yet classes.
>
> Maybe even the property value could be validated by actually
> setting the property in a temporary object, but I am not looking
> forward to audit every single property setter in QEMU to ensure
> this is safe.
Dynamically created types and properties --- the gift that keeps giving.
next prev parent reply other threads:[~2016-06-23 16:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 15:52 [Qemu-devel] [PATCH v2 00/10] globals: Clean up validation and error checking Eduardo Habkost
2016-06-20 15:52 ` [Qemu-devel] [PATCH v2 01/10] qdev: Don't stop applying globals on first error Eduardo Habkost
2016-06-23 7:40 ` Markus Armbruster
2016-06-23 11:36 ` Eduardo Habkost
2016-06-20 15:52 ` [Qemu-devel] [PATCH v2 02/10] qdev: Eliminate qemu_add_globals() function Eduardo Habkost
2016-06-23 7:42 ` Markus Armbruster
2016-06-20 15:52 ` [Qemu-devel] [PATCH v2 03/10] vl: Reject invalid class names on -global Eduardo Habkost
2016-06-23 7:52 ` Markus Armbruster
2016-06-23 11:40 ` Eduardo Habkost
2016-06-23 13:30 ` Eduardo Habkost
2016-06-23 11:45 ` Eduardo Habkost
2016-06-20 15:52 ` [Qemu-devel] [PATCH v2 04/10] qdev: GlobalProperty.errp field Eduardo Habkost
2016-06-21 8:11 ` Igor Mammedov
2016-06-21 13:32 ` Eduardo Habkost
2016-06-23 7:54 ` Markus Armbruster
2016-06-20 15:52 ` [Qemu-devel] [PATCH v2 05/10] machine: Add machine_register_compat_props() function Eduardo Habkost
2016-06-23 7:55 ` Markus Armbruster
2016-06-20 15:52 ` [Qemu-devel] [PATCH v2 06/10] vl: Set errp to &error_abort on machine compat_props Eduardo Habkost
2016-06-23 7:56 ` Markus Armbruster
2016-06-20 15:53 ` [Qemu-devel] [PATCH v2 07/10] qdev: Eliminate "global not used" warning Eduardo Habkost
2016-06-21 12:54 ` Igor Mammedov
2016-06-23 8:17 ` Markus Armbruster
2016-06-23 12:10 ` Eduardo Habkost
2016-06-20 15:53 ` [Qemu-devel] [PATCH v2 08/10] qdev: Eliminate GlobalProperty 'used' and 'user_provided' fields Eduardo Habkost
2016-06-21 12:59 ` Igor Mammedov
2016-06-20 15:53 ` [Qemu-devel] [PATCH v2 09/10] qdev: Remove qdev_prop_register_global_list() Eduardo Habkost
2016-06-21 9:09 ` Marcel Apfelbaum
2016-06-23 8:19 ` Markus Armbruster
2016-06-20 15:53 ` [Qemu-devel] [PATCH v2 10/10] machine: Skip global registration for non-existing classes Eduardo Habkost
2016-06-21 9:10 ` Marcel Apfelbaum
2016-06-23 8:26 ` Markus Armbruster
2016-06-23 11:32 ` Eduardo Habkost
2016-06-23 11:55 ` Eduardo Habkost
2016-06-23 16:24 ` Markus Armbruster [this message]
2016-06-22 22:12 ` [Qemu-devel] [PATCH v2 00/10] globals: Clean up validation and error checking Eduardo Habkost
2016-06-23 13:38 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lh1v27rm.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.