From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [4.4-rc1][Regression] drm/i915: Check live status before reading edid Date: Mon, 29 Feb 2016 11:33:59 +0200 Message-ID: <87lh63uago.fsf@intel.com> References: <56CE22DB.6050108@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56CE22DB.6050108@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joseph Salisbury , sonika.jindal@intel.com Cc: David Airlie , Daniel Vetter , intel-gfx , LKML , dri-devel , rodrigo.vivi@intel.com List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAyNCBGZWIgMjAxNiwgSm9zZXBoIFNhbGlzYnVyeSA8am9zZXBoLnNhbGlzYnVyeUBj YW5vbmljYWwuY29tPiB3cm90ZToKPiBIaSBTb25pa2EsCj4KPiBBIGtlcm5lbCBidWcgcmVwb3J0 IHdhcyBvcGVuZWQgYWdhaW5zdCBVYnVudHUgWzBdLiAgQWZ0ZXIgYSBrZXJuZWwKPiBiaXNlY3Qs IGl0IHdhcyBmb3VuZCB0aGF0IHJldmVydGluZyB0aGUgZm9sbG93aW5nIGNvbW1pdCByZXNvbHZl ZCB0aGlzIGJ1ZzoKPgo+IGNvbW1pdCAyMzdlZDg2YzY5M2Q4YThlNGRiNDc2OTc2YWViMzBkZjRk ZWFjNzRiCj4gQXV0aG9yOiBTb25pa2EgSmluZGFsIDxzb25pa2EuamluZGFsQGludGVsLmNvbT4K PiBEYXRlOiAgIFR1ZSBTZXAgMTUgMDk6NDQ6MjAgMjAxNSArMDUzMAo+Cj4gICAgIGRybS9pOTE1 OiBDaGVjayBsaXZlIHN0YXR1cyBiZWZvcmUgcmVhZGluZyBlZGlkCj4KPgo+Cj4gVGhlIHJlZ3Jl c3Npb24gd2FzIGludHJvZHVjZWQgYXMgb2YgdjQuNC1yYzEuCj4KPiBJIHdhcyBob3BpbmcgdG8g Z2V0IHlvdXIgZmVlZGJhY2ssIHNpbmNlIHlvdSBhcmUgdGhlIHBhdGNoIGF1dGhvci4gIERvCj4g dGhpbmsgaW5jcmVhc2luZyB0aGUgbnVtYmVyIG9mIHRyaWVzIGluIGludGVsX2hkbWlfZGV0ZWN0 KCkgaXMgd29ydGgKPiB0cnlpbmc/ICBEbyB5b3UgdGhpbmsgZ2F0aGVyaW5nIGFueSBhZGRpdGlv bmFsIGRhdGEgd2lsbCBoZWxwIGRpYWdub3NlCj4gdGhpcyBpc3N1ZSwgb3Igd291bGQgaXQgYmUg YmVzdCB0byBzdWJtaXQgYSByZXZlcnQgcmVxdWVzdD8KClRoZXJlIGFyZSBhdCBsZWFzdCB0aGUg Zm9sbG93aW5nIGNvbW1pdHMgY2xhaW1pbmcgdG8gZml4IGlzc3VlcyBpbiB0aGUKYWJvdmUgY29t bWl0LiBQbGVhc2UgbWFrZSBzdXJlIHlvdSBoYXZlIHRoZW0uCgpCUiwKSmFuaS4KCgpjb21taXQg OGQ0MDljYjNlOGEyNDE5NmJlNzI3MWRlZmFmZDQ2MzhmM2UwYjUxNApBdXRob3I6IFZpbGxlIFN5 cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CkRhdGU6ICAgV2VkIEZlYiAx MCAxOTo1OTowNSAyMDE2ICswMjAwCgogICAgZHJtL2k5MTU6IEZpeCBocGQgbGl2ZSBzdGF0dXMg Yml0cyBmb3IgZzR4Cgpjb21taXQgM2Q4YWNkMWY2NjdiNDVjNTMxNDAxYzhmMGMyMDMzMDcyZTMy YTA1ZApBdXRob3I6IEdhcnkgV2FuZyA8Z2FyeS5jLndhbmdAaW50ZWwuY29tPgpEYXRlOiAgIFdl ZCBEZWMgMjMgMTY6MTE6MzUgMjAxNSArMDgwMAoKICAgIGRybS9pOTE1OiBpbmNyZWFzZSB0aGUg dHJpZXMgZm9yIEhETUkgaG90cGx1ZyBsaXZlIHN0YXR1cyBjaGVja2luZwoKY29tbWl0IDk3Zjkw MTBhZjA1YzE1ZTBiN2U2YjRlZjZmZjhjYjBlYmI3ZTc3MTUKQXV0aG9yOiBEYW5pZWwgVmV0dGVy IDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgpEYXRlOiAgIEZyaSBEZWMgMTEgMTk6NDQ6MTUgMjAx NSArMDEwMAoKICAgIGRybS9pOTE1OiBtZGVsYXkoMTApIGNvbnNpZGVyZWQgaGFybWZ1bAoKY29t bWl0IDBmNWE5YmUxNTc5N2Y3OGM5YTM0ZTQzMmYyNmM3OTYxNjViNmU0OWEKQXV0aG9yOiBJbXJl IERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+CkRhdGU6ICAgRnJpIE5vdiAyNyAxODo1NToyOSAy MDE1ICswMjAwCgogICAgZHJtL2k5MTU6IHRha2UgYSBwb3dlciBkb21haW4gcmVmZXJlbmNlIHdo aWxlIGNoZWNraW5nIHRoZSBIRE1JIGxpdmUgc3RhdHVzCgoKCgotLSAKSmFuaSBOaWt1bGEsIElu dGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753422AbcB2JeK (ORCPT ); Mon, 29 Feb 2016 04:34:10 -0500 Received: from mga09.intel.com ([134.134.136.24]:41189 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752689AbcB2JeF convert rfc822-to-8bit (ORCPT ); Mon, 29 Feb 2016 04:34:05 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,520,1449561600"; d="scan'208";a="926059884" From: Jani Nikula To: Joseph Salisbury , sonika.jindal@intel.com Cc: shashank.sharma@intel.com, rodrigo.vivi@intel.com, Daniel Vetter , David Airlie , intel-gfx , dri-devel , LKML Subject: Re: [4.4-rc1][Regression] drm/i915: Check live status before reading edid In-Reply-To: <56CE22DB.6050108@canonical.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <56CE22DB.6050108@canonical.com> User-Agent: Notmuch/0.21+34~g7dd0d52 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 29 Feb 2016 11:33:59 +0200 Message-ID: <87lh63uago.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Feb 2016, Joseph Salisbury wrote: > Hi Sonika, > > A kernel bug report was opened against Ubuntu [0]. After a kernel > bisect, it was found that reverting the following commit resolved this bug: > > commit 237ed86c693d8a8e4db476976aeb30df4deac74b > Author: Sonika Jindal > Date: Tue Sep 15 09:44:20 2015 +0530 > > drm/i915: Check live status before reading edid > > > > The regression was introduced as of v4.4-rc1. > > I was hoping to get your feedback, since you are the patch author. Do > think increasing the number of tries in intel_hdmi_detect() is worth > trying? Do you think gathering any additional data will help diagnose > this issue, or would it be best to submit a revert request? There are at least the following commits claiming to fix issues in the above commit. Please make sure you have them. BR, Jani. commit 8d409cb3e8a24196be7271defafd4638f3e0b514 Author: Ville Syrjälä Date: Wed Feb 10 19:59:05 2016 +0200 drm/i915: Fix hpd live status bits for g4x commit 3d8acd1f667b45c531401c8f0c2033072e32a05d Author: Gary Wang Date: Wed Dec 23 16:11:35 2015 +0800 drm/i915: increase the tries for HDMI hotplug live status checking commit 97f9010af05c15e0b7e6b4ef6ff8cb0ebb7e7715 Author: Daniel Vetter Date: Fri Dec 11 19:44:15 2015 +0100 drm/i915: mdelay(10) considered harmful commit 0f5a9be15797f78c9a34e432f26c796165b6e49a Author: Imre Deak Date: Fri Nov 27 18:55:29 2015 +0200 drm/i915: take a power domain reference while checking the HDMI live status -- Jani Nikula, Intel Open Source Technology Center