From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqnMV-0006dU-MH for qemu-devel@nongnu.org; Mon, 26 Oct 2015 15:23:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqnMR-0002k3-FG for qemu-devel@nongnu.org; Mon, 26 Oct 2015 15:23:19 -0400 Received: from roura.ac.upc.edu ([147.83.33.10]:60356 helo=roura.ac.upc.es) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqnMR-0002i3-3t for qemu-devel@nongnu.org; Mon, 26 Oct 2015 15:23:15 -0400 From: =?utf-8?Q?Llu=C3=ADs_Vilanova?= References: <1445850626-29407-1-git-send-email-den@openvz.org> <1445850841-29510-1-git-send-email-den@openvz.org> <1445850841-29510-2-git-send-email-den@openvz.org> <87io5tu62s.fsf@fimbulvetr.bsc.es> <562E5DEB.2070009@redhat.com> Date: Mon, 26 Oct 2015 20:23:11 +0100 In-Reply-To: <562E5DEB.2070009@redhat.com> (Eric Blake's message of "Mon, 26 Oct 2015 11:07:55 -0600") Message-ID: <87lhapmo2o.fsf@fimbulvetr.bsc.es> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 11/11] log: add "-d trace:PATTERN" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, "Denis V. Lunev" Eric Blake writes: > On 10/26/2015 07:12 AM, Llu=C3=ADs Vilanova wrote: >> Denis V Lunev writes: >>=20 >>> From: Paolo Bonzini >>> This is a bit easier to use than "-trace" if you are also enabling >>> other kinds of logging. It is also more discoverable for experienced >>> QEMU users, and accessible from user-mode emulators. >>=20 >> I'm not sure this should be added, since the same functionality is also >> available through "-trace enable=3D" (and the shortcut "-trace >> "). > Having more than one way to do something is not necessarily bad; it does > imply more maintenance to keep both ways working, but if one way is more > discoverable than the other it may be worth it. Certainly true. I just find it confusing to have the same functionality available through different forms. >>=20 >> Also, I'd rather fold event name discovery into "-trace enable=3D?" (and= the >> shortcut "-trace ?"), mimicking the format already available for CPUs ("= -cpu >> ?"). >>=20 > If we do that, we should also support '-trace enable=3Dhelp', because ? is > a shell metacharacter, and we have been moving towards using 'help' > rather than '?' to minimize the need for shell quoting when asking for he= lp. Oh, I wasn't aware of the "deprecation" of '?'. Then it certainly makes more sense to use 'help'. Thanks, Lluis --=20 "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as told by Norton Juster in The Phantom Tollbooth