From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752850AbbH1Td7 (ORCPT ); Fri, 28 Aug 2015 15:33:59 -0400 Received: from mga11.intel.com ([192.55.52.93]:35670 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752164AbbH1Td6 (ORCPT ); Fri, 28 Aug 2015 15:33:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,426,1437462000"; d="scan'208";a="634194112" From: Andi Kleen To: Alexander Shishkin Cc: Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo Subject: Re: [PATCH] perf/x86/intel/pt: Export cpu frequency ratios needed by PT decoders References: <1440687986-27246-1-git-send-email-alexander.shishkin@linux.intel.com> Date: Fri, 28 Aug 2015 12:33:58 -0700 In-Reply-To: <1440687986-27246-1-git-send-email-alexander.shishkin@linux.intel.com> (Alexander Shishkin's message of "Thu, 27 Aug 2015 18:06:26 +0300") Message-ID: <87lhcvtdg9.fsf@tassilo.jf.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alexander Shishkin writes: > + return sprintf(page, "%lu\n", val); > + case 1: > + cpuid(0x15, &eax, &ebx, &ecx, &edx); Surely this needs to be protected by a cpuid level check? Broadwell for once doesn't have CPUID 0x15. -Andi -- ak@linux.intel.com -- Speaking for myself only