From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH for v4.2] Revert "drm/i915: Allow parsing of variable size child device entries from VBT" Date: Wed, 19 Aug 2015 09:58:29 +0300 Message-ID: <87lhd7dasq.fsf@intel.com> References: <1439890416-16826-1-git-send-email-jani.nikula@intel.com> <20150818170040.GL5176@intel.com> <87fv3g9fbc.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 916C36E06C for ; Tue, 18 Aug 2015 23:55:30 -0700 (PDT) In-Reply-To: <87fv3g9fbc.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAxOSBBdWcgMjAxNSwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4g d3JvdGU6Cj4gT24gV2VkLCAxOSBBdWcgMjAxNSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xs LmNoPiB3cm90ZToKPj4gT24gVHVlLCBBdWcgMTgsIDIwMTUgYXQgMTA6MDAgQU0sIFZpbGxlIFN5 cmrDpGzDpAo+PiA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+Pj4gT24g VHVlLCBBdWcgMTgsIDIwMTUgYXQgMDk6NTg6NTdBTSAtMDcwMCwgRGFuaWVsIFZldHRlciB3cm90 ZToKPj4+PiBPbiBUdWUsIEF1ZyAxOCwgMjAxNSBhdCAyOjMzIEFNLCBKYW5pIE5pa3VsYSA8amFu aS5uaWt1bGFAaW50ZWwuY29tPiB3cm90ZToKPj4+PiA+IFRoaXMgcmV2ZXJ0cwo+Pj4+ID4KPj4+ PiA+IGNvbW1pdCAwNDdmZTZlNmRiOTE2MWU2OTI3MWY1NmRhYWFmZGFmMmFkZDAyM2IxCj4+Pj4g PiBBdXRob3I6IERhdmlkIFdlaW5laGFsbCA8ZGF2aWQud2VpbmVoYWxsQGxpbnV4LmludGVsLmNv bT4KPj4+PiA+IERhdGU6ICAgVHVlIEF1ZyA0IDE2OjU1OjUyIDIwMTUgKzAzMDAKPj4+PiA+Cj4+ Pj4gPiAgICAgZHJtL2k5MTU6IEFsbG93IHBhcnNpbmcgb2YgdmFyaWFibGUgc2l6ZSBjaGlsZCBk ZXZpY2UgZW50cmllcyBmcm9tIFZCVAo+Pj4+ID4KPj4+PiA+IFRoYXQgY29tbWl0IGlzIG5vdCB2 YWxpZCBmb3IgdjQuMiwgaG93ZXZlciBpdCB3aWxsIGJlIHZhbGlkIGZvciB2NC4zLiBJdAo+Pj4+ ID4gd2FzIHNpbXBseSBxdWV1ZWQgdG9vIGVhcmx5Lgo+Pj4+Cj4+Pj4gTm9wZSwgdGhpcyBwYXRj aCBmcm9tIERhdmlkIGFsc28gaW5jaWRlbnRhbGx5IGZpeGVzIGEgcmVncmVzc2lvbiBmcm9tCj4+ Pj4gOTBlNGYxNTkyYmI2ZTgyZjY2OTBmMGUwNWE4YWFkYyB3aGljaCBpcyB3aHkgSSBtZXJnZWQg aXQgdG8uCj4+Pgo+Pj4gV2hhdCByZWdyZXNzaW9uPwo+Pgo+PiBRdW90aW5nIHRoZSBjb21taXQg bWVzc2FnZTogIi4uLiAgc2luY2Ugd2UncmUgaGl0dGluZyBhIERSTV9FUlJPUiBvbgo+PiBvbGRl ciBwbGF0Zm9ybXMgd2l0aCB0aGlzLiIgTm90IGV2ZXJ5IHBsYXRmb3JtIGhhcyB0aGUgQlNXIHZi dCBsYXlvdXQKPj4gOy0pIE9oIGFuZCB3aHkgZG8gSSBldmVuIGJvdGhlciB0byB3cml0ZSB0aGlz IHN0dWZmIHdoZW4gbm8gb25lIHJlYWRzCj4+IGl0Pwo+Cj4gSSByZWFkIGl0LCBhbmQgSSB0aGlu ayBpdCdzIHdyb25nLiBJIGV2ZW4gZXhwbGFpbmVkIHdoeSBpbiBteSBjb21taXQKPiBtZXNzYWdl ICh5ZXMsIHBsZWFzZSByZWFkIGl0KS4gSSBkb24ndCB0aGluayB0aGVyZSB3YXMgYSBEUk1fRVJS T1Igb24KPiBvbGRlciBwbGF0Zm9ybSB3aXRoIFZpbGxlJ3MgcGF0Y2gsIG9uIHY0LjIgd2hlcmUg dGhlIHJldmVydCBpcyB0YXJnZXRlZCwKPiBhbmQgZXZlbiBpZiB0aGVyZSB3ZXJlLCBEYXZpZCdz IHBhdGNoIHdvdWxkICpub3QqIGZpeCBpdC4gSW5kZWVkIHRoZXJlCj4gd2FzIG5vIGRpc2N1c3Np b24gb2YgYSByZWdyZXNzaW9uIG9uIHRoZSBtYWlsaW5nIGxpc3QuCj4KPiBJZiB0aGVyZSB3YXMg YW55IHJlZ3Jlc3Npb24sIGl0IHdhcyBpbnRyb2R1Y2VkIGJ5Cj4KPiBjb21taXQgNzUwNjdkZGVj ZjIxMjcxNjMxYmMwMThkMmZiMjNkZGQwOWI2NmFhZQo+IEF1dGhvcjogQW50dGkgS29za2lwYWEg PGFudHRpLmtvc2tpcGFhQGxpbnV4LmludGVsLmNvbT4KPiBEYXRlOiAgIEZyaSBKdWwgMTAgMTQ6 MTA6NTUgMjAxNSArMDMwMAo+Cj4gICAgIGRybS9pOTE1OiBQZXItRERJIElfYm9vc3Qgb3ZlcnJp ZGUKPgo+IHdoZW4gdGhlIHNpemUgb2YgdW5pb24gY2hpbGRfZGV2aWNlX2NvbmZpZyBjaGFuZ2Vk LiBCdXQgdGhhdCdzIGhlYWRlZAo+IGZvciB2NC4zLiBBbmQgd2UncmUgdGFsa2luZyBhYm91dCB2 NC4yLCB3aGljaCBpcyBnZXR0aW5nIHByZXR0eQo+IHVyZ2VudC4gV2UnbGwgaGF2ZSBhIGJpdCBt b3JlIHRpbWUgdG8gc29ydCBvdXQgdGhlIG1lc3MgdGhhdCB3aWxsIGxhbmQKPiBpbiB2NC4zIChh bmQgSSd2ZSBhbHJlYWR5IHNlbnQgb25lIHBhdGNoIHNvcnRpbmcgb3V0IFNEVk8gYnJlYWthZ2Up LgoKSSdtIG5vdCB3YWl0aW5nIHdpdGggdGhpcy4gSSdtIHRha2luZyBteSBjaGFuY2VzLCBwdXNo ZWQgdG8KZHJtLWludGVsLWZpeGVzLiBUaGFua3MgZm9yIHRoZSByZXZpZXcuCgpOb3RlIHRoYXQg dGhlIGNvbW1pdCByZW1haW5zIGluIGRybS1pbnRlbC1uZXh0LWZpeGVzIGFuZApkcm0taW50ZWwt bmV4dC1xdWV1ZWQsIGJ1dCBub3QgaW4gZHJtLWludGVsLW5pZ2h0bHkgZHVlIHRvIHRoaXMKcmV2 ZXJ0LiBXZSdsbCBuZWVkIHRvIGNsZWFyIHRoYXQgdXAsIGJ1dCBmb3IgdGhlIHRpbWUgYmVpbmcg Z2V0dGluZyB2NC4yCmZpeGVkIHVwIGlzIG9mIGEgaGlnaGVyIHByaW9yaXR5IHRvIG1lLgoKQlIs CkphbmkuCgoKCgo+Cj4gQlIsCj4gSmFuaS4KPgo+Cj4KPj4gLURhbmllbAo+Pgo+Pj4+IElmIHlv dQo+Pj4+IHdhbnQgdG8gcmV2ZXJ0IHRoaXMsIHlvdSBuZWVkIHRvIHJldmVydCBtb3JlIChhbmQg d2l0aCB0aGF0IGFsc28gYnJlYWsKPj4+PiBCU1cpLgo+Pj4+Cj4+Pj4gSXNuJ3QgdGhlcmUgYSBt b3JlIG1pbmltYWwgZml4IHdlIGNhbiBkbyBmb3IgNC4yPwo+Pj4+IC1EYW5pZWwKPj4+Pgo+Pj4+ ID4KPj4+PiA+IFRoZSByZWZlcmVuY2VkIHJlZ3Jlc3NpbmcgY29tbWl0IGlzIGp1c3QgZmluZSB1 bnRpbCB0aGUgc2l6ZSBvZiBzdHJ1Y3QKPj4+PiA+IGNvbW1vbl9jaGlsZF9kZXZfY29uZmlnIGNo YW5nZXMsIGFuZCB0aGF0IHdvbid0IGhhcHBlbiB1bnRpbAo+Pj4+ID4gdjQuMy4gSW5kZWVkLCB0 aGUgZXhwZWN0ZWQgc2l6ZSBjaGVja3MgaGVyZSByZWx5IG9uIHRoZSBpbmNyZWFzZWQgc2l6ZQo+ Pj4+ID4gb2YgdGhlIHN0cnVjdCwgYnJlYWtpbmcgbmV3IHBsYXRmb3Jtcy4KPj4+PiA+Cj4+Pj4g PiBGaXhlczogMDQ3ZmU2ZTZkYjkxICgiZHJtL2k5MTU6IEFsbG93IHBhcnNpbmcgb2YgdmFyaWFi bGUgc2l6ZSBjaGlsZCBkZXZpY2UgZW50cmllcyBmcm9tIFZCVCIpCj4+Pj4gPiBDYzogRGFuaWVs IFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgo+Pj4+ID4gQ2M6IERhdmlkIFdlaW5laGFsbCA8ZGF2 aWQud2VpbmVoYWxsQGxpbnV4LmludGVsLmNvbT4KPj4+PiA+IENjOiBWaWxsZSBTeXJqw6Rsw6Qg PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+Pj4+ID4gU2lnbmVkLW9mZi1ieTogSmFu aSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPj4+PiA+Cj4+Pj4gPiAtLS0KPj4+PiA+ Cj4+Pj4gPiBUaGVyZSB3YXMgYW5vdGhlciBwYXRjaCBmcm9tIERhdmlkIGluY3JlYXNpbmcgdGhl IHNpemUgb2YgdGhlIHN0cnVjdAo+Pj4+ID4gWzFdLCBidXQgdGhhdCB0aGVuIHJlZ3Jlc3NlcyBz ZHZvIG1hcHBpbmcgcGFyc2luZy4gSXQncyB0aGUgc2ltcGxlc3QgdG8KPj4+PiA+IGp1c3QgcmV2 ZXJ0IGFuZCBmaXggdGhpcyB1cCBwcm9wZXJseSBmb3IgdjQuMy4KPj4+PiA+Cj4+Pj4gPiBbMV0g aHR0cDovL21pZC5nbWFuZS5vcmcvMjAxNTA4MTMxMzE0MTUuR082MTUwQGJvb20KPj4+PiA+IC0t LQo+Pj4+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYyB8IDI3ICsrKystLS0t LS0tLS0tLS0tLS0tLS0tLS0tLQo+Pj4+ID4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMo KyksIDIzIGRlbGV0aW9ucygtKQo+Pj4+ID4KPj4+PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9z LmMKPj4+PiA+IGluZGV4IDNkY2Q1OWU2OTRkYi4uMTk4ZmMzYzMyOTFiIDEwMDY0NAo+Pj4+ID4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jCj4+Pj4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPj4+PiA+IEBAIC0xMDc1LDM0ICsxMDc1LDE1 IEBAIHBhcnNlX2RldmljZV9tYXBwaW5nKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPj4+PiA+ICAgICAgICAgY29uc3QgdW5pb24gY2hpbGRfZGV2aWNlX2NvbmZpZyAqcF9jaGls ZDsKPj4+PiA+ICAgICAgICAgdW5pb24gY2hpbGRfZGV2aWNlX2NvbmZpZyAqY2hpbGRfZGV2X3B0 cjsKPj4+PiA+ICAgICAgICAgaW50IGksIGNoaWxkX2RldmljZV9udW0sIGNvdW50Owo+Pj4+ID4g LSAgICAgICB1OCBleHBlY3RlZF9zaXplOwo+Pj4+ID4gLSAgICAgICB1MTYgYmxvY2tfc2l6ZTsK Pj4+PiA+ICsgICAgICAgdTE2ICAgICBibG9ja19zaXplOwo+Pj4+ID4KPj4+PiA+ICAgICAgICAg cF9kZWZzID0gZmluZF9zZWN0aW9uKGJkYiwgQkRCX0dFTkVSQUxfREVGSU5JVElPTlMpOwo+Pj4+ ID4gICAgICAgICBpZiAoIXBfZGVmcykgewo+Pj4+ID4gICAgICAgICAgICAgICAgIERSTV9ERUJV R19LTVMoIk5vIGdlbmVyYWwgZGVmaW5pdGlvbiBibG9jayBpcyBmb3VuZCwgbm8gZGV2aWNlcyBk ZWZpbmVkLlxuIik7Cj4+Pj4gPiAgICAgICAgICAgICAgICAgcmV0dXJuOwo+Pj4+ID4gICAgICAg ICB9Cj4+Pj4gPiAtICAgICAgIGlmIChiZGItPnZlcnNpb24gPCAxOTUpIHsKPj4+PiA+IC0gICAg ICAgICAgICAgICBleHBlY3RlZF9zaXplID0gMzM7Cj4+Pj4gPiAtICAgICAgIH0gZWxzZSBpZiAo YmRiLT52ZXJzaW9uID09IDE5NSkgewo+Pj4+ID4gLSAgICAgICAgICAgICAgIGV4cGVjdGVkX3Np emUgPSAzNzsKPj4+PiA+IC0gICAgICAgfSBlbHNlIGlmIChiZGItPnZlcnNpb24gPD0gMTk3KSB7 Cj4+Pj4gPiAtICAgICAgICAgICAgICAgZXhwZWN0ZWRfc2l6ZSA9IDM4Owo+Pj4+ID4gLSAgICAg ICB9IGVsc2Ugewo+Pj4+ID4gLSAgICAgICAgICAgICAgIGV4cGVjdGVkX3NpemUgPSAzODsKPj4+ PiA+IC0gICAgICAgICAgICAgICBEUk1fREVCVUdfRFJJVkVSKCJFeHBlY3RlZCBjaGlsZF9kZXZp Y2VfY29uZmlnIHNpemUgZm9yIEJEQiB2ZXJzaW9uICV1IG5vdCBrbm93bjsgYXNzdW1pbmcgJXVc biIsCj4+Pj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBleHBlY3RlZF9zaXpl LCBiZGItPnZlcnNpb24pOwo+Pj4+ID4gLSAgICAgICB9Cj4+Pj4gPiAtCj4+Pj4gPiAtICAgICAg IGlmIChleHBlY3RlZF9zaXplID4gc2l6ZW9mKCpwX2NoaWxkKSkgewo+Pj4+ID4gLSAgICAgICAg ICAgICAgIERSTV9FUlJPUigiY2hpbGRfZGV2aWNlX2NvbmZpZyBjYW5ub3QgZml0IGluIHBfY2hp bGRcbiIpOwo+Pj4+ID4gLSAgICAgICAgICAgICAgIHJldHVybjsKPj4+PiA+IC0gICAgICAgfQo+ Pj4+ID4gLQo+Pj4+ID4gLSAgICAgICBpZiAocF9kZWZzLT5jaGlsZF9kZXZfc2l6ZSAhPSBleHBl Y3RlZF9zaXplKSB7Cj4+Pj4gPiAtICAgICAgICAgICAgICAgRFJNX0VSUk9SKCJTaXplIG1pc21h dGNoOyBjaGlsZF9kZXZpY2VfY29uZmlnIHNpemU9JXUgKGV4cGVjdGVkICV1KTsgYmRiLT52ZXJz aW9uOiAldVxuIiwKPj4+PiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgcF9kZWZzLT5jaGls ZF9kZXZfc2l6ZSwgZXhwZWN0ZWRfc2l6ZSwgYmRiLT52ZXJzaW9uKTsKPj4+PiA+ICsgICAgICAg aWYgKHBfZGVmcy0+Y2hpbGRfZGV2X3NpemUgPCBzaXplb2YoKnBfY2hpbGQpKSB7Cj4+Pj4gPiAr ICAgICAgICAgICAgICAgRFJNX0VSUk9SKCJHZW5lcmFsIGRlZmluaXRvbiBibG9jayBjaGlsZCBk ZXZpY2Ugc2l6ZSBpcyB0b28gc21hbGwuXG4iKTsKPj4+PiA+ICAgICAgICAgICAgICAgICByZXR1 cm47Cj4+Pj4gPiAgICAgICAgIH0KPj4+PiA+ICAgICAgICAgLyogZ2V0IHRoZSBibG9jayBzaXpl IG9mIGdlbmVyYWwgZGVmaW5pdGlvbnMgKi8KPj4+PiA+IEBAIC0xMTQ5LDcgKzExMzAsNyBAQCBw YXJzZV9kZXZpY2VfbWFwcGluZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ Pj4gPgo+Pj4+ID4gICAgICAgICAgICAgICAgIGNoaWxkX2Rldl9wdHIgPSBkZXZfcHJpdi0+dmJ0 LmNoaWxkX2RldiArIGNvdW50Owo+Pj4+ID4gICAgICAgICAgICAgICAgIGNvdW50Kys7Cj4+Pj4g PiAtICAgICAgICAgICAgICAgbWVtY3B5KGNoaWxkX2Rldl9wdHIsIHBfY2hpbGQsIHBfZGVmcy0+ Y2hpbGRfZGV2X3NpemUpOwo+Pj4+ID4gKyAgICAgICAgICAgICAgIG1lbWNweShjaGlsZF9kZXZf cHRyLCBwX2NoaWxkLCBzaXplb2YoKnBfY2hpbGQpKTsKPj4+PiA+ICAgICAgICAgfQo+Pj4+ID4g ICAgICAgICByZXR1cm47Cj4+Pj4gPiAgfQo+Pj4+ID4gLS0KPj4+PiA+IDIuMS40Cj4+Pj4gPgo+ Pj4+Cj4+Pj4KPj4+Pgo+Pj4+IC0tCj4+Pj4gRGFuaWVsIFZldHRlcgo+Pj4+IFNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+Pj4+ICs0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKPj4+Cj4+PiAtLQo+Pj4gVmlsbGUgU3lyasOkbMOkCj4+PiBJbnRl bCBPVEMKPj4KPj4KPj4KPj4gLS0gCj4+IERhbmllbCBWZXR0ZXIKPj4gU29mdHdhcmUgRW5naW5l ZXIsIEludGVsIENvcnBvcmF0aW9uCj4+ICs0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Js b2cuZmZ3bGwuY2gKPgo+IC0tIAo+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNo bm9sb2d5IENlbnRlcgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9s b2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=