From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZADVs-0004CV-Tv for qemu-devel@nongnu.org; Wed, 01 Jul 2015 04:37:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZADVr-000124-Si for qemu-devel@nongnu.org; Wed, 01 Jul 2015 04:37:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZADVr-00011v-EQ for qemu-devel@nongnu.org; Wed, 01 Jul 2015 04:36:59 -0400 From: Juan Quintela In-Reply-To: <1434043048-4444-3-git-send-email-dgilbert@redhat.com> (David Alan Gilbert's message of "Thu, 11 Jun 2015 18:17:18 +0100") References: <1434043048-4444-1-git-send-email-dgilbert@redhat.com> <1434043048-4444-3-git-send-email-dgilbert@redhat.com> Date: Wed, 01 Jul 2015 10:36:57 +0200 Message-ID: <87lhf02s0m.fsf@neno.neno> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 02/12] qemu_ram_foreach_block: pass up error value, and down the ramblock name Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: amit.shah@redhat.com, arei.gonglei@huawei.com, qemu-devel@nongnu.org, mrhines@us.ibm.com "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > check the return value of the function it calls and error if it's non-0 > Fixup qemu_rdma_init_one_block that is the only current caller, > and rdma_add_block the only function it calls using it. > > Pass the name of the ramblock to the function; helps in debugging. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: David Gibson > Reviewed-by: Amit Shah > Reviewed-by: Michael R. Hines Reviewed-by: Juan Quintela