From mboxrd@z Thu Jan 1 00:00:00 1970 From: robert.jarzmik@free.fr (Robert Jarzmik) Date: Mon, 19 Jan 2015 20:29:40 +0100 Subject: [PATCH v3 1/3] dt-bindings: mfd: add lubbock-io binding In-Reply-To: <20150119083533.GF21886@x1> (Lee Jones's message of "Mon, 19 Jan 2015 08:35:33 +0000") References: <1421406010-14851-1-git-send-email-robert.jarzmik@free.fr> <20150119083533.GF21886@x1> Message-ID: <87lhkyh8m3.fsf@free.fr> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Lee Jones writes: > On Fri, 16 Jan 2015, Robert Jarzmik wrote: > >> Add a binding for lubbock motherboard IO board. >> >> Signed-off-by: Robert Jarzmik >> --- >> .../devicetree/bindings/mfd/lubbock-io.txt | 26 ++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/lubbock-io.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/lubbock-io.txt b/Documentation/devicetree/bindings/mfd/lubbock-io.txt >> new file mode 100644 >> index 0000000..33c9e21 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/lubbock-io.txt >> @@ -0,0 +1,26 @@ >> +Intel's pxa255 system development platform motherboard. > > s/pxa25/PXA25/ Ok. > > "system development platform motherboard" doesn't quite sit right with me. > > How about "Intel Xscale PXA255 development platform (Lubbock)"? OK. > >> +This is the motherboard, or IO board, of the pxa25x development system, >> +supporting a lubbock pxa25x SoC board. > > Again, this sounds weird. Would it sound better with : This regroups all the CPLDs on the Lubbock motherboard, providing interrupt muxing, leds handling, ... > >> +Required properties: >> + - compatible : One of the following chip-specific strings: >> + "intel,lubbock-io" > > An odd thing to say with only one entry. Right, a simple "should be" would fit better. > >> + - interrupts : The first interrupt is the line the /IRQ signal the IO board >> + multiplex is connected to. The only known case is GPIO0 on the >> + pxa25x SoC. > > Can you get someone to help you re-word this into a more fluid > sentence? Aouch, how about this : interrupts : The first interrupt is the SoC input interrupt connected to the lubbock IO board interrupt multiplexer output. The only known working configuration is GPIO0 on the pxa25x SoC. > >> +Optional properties: >> + - interrupts : The second optional interrupt is the base of the interrupts >> + multiplexed by the lubbock motherboard. If unspecified, the >> + range is fully dynamic, and the irqdomain will generate its >> + interrupt base on the fly. >> + >> +Example: >> + >> +mb: lubbock-mb at 0 { >> + compatible = "intel,lubbock-io"; >> + interrupts = <0 IRQ_TYPE_EDGE_FALLING 400 IRQ_TYPE_NONE>; >> + #interrupt-cells = <2>; >> + interrupt-parent = <&pxairq>; > > Whitespace error. Right. > I'm guessing mb means motherboard? I think it's unusual for a > motherboard to have it's own driver. Usually we provide drivers for > the individual components/peripherals situated on the board. Yes, mb for motherboard. Well, this driver is actually for the CPLDs on the motherboard. Would "lubbock-cplds" be a better choice ? Cheers. -- Robert From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH v3 1/3] dt-bindings: mfd: add lubbock-io binding Date: Mon, 19 Jan 2015 20:29:40 +0100 Message-ID: <87lhkyh8m3.fsf@free.fr> References: <1421406010-14851-1-git-send-email-robert.jarzmik@free.fr> <20150119083533.GF21886@x1> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20150119083533.GF21886@x1> (Lee Jones's message of "Mon, 19 Jan 2015 08:35:33 +0000") Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lee Jones Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Daniel Mack , Haojian Zhuang , Samuel Ortiz , Arnd Bergmann , Dmitry Eremin-Solenikov , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Lee Jones writes: > On Fri, 16 Jan 2015, Robert Jarzmik wrote: > >> Add a binding for lubbock motherboard IO board. >> >> Signed-off-by: Robert Jarzmik >> --- >> .../devicetree/bindings/mfd/lubbock-io.txt | 26 ++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/lubbock-io.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/lubbock-io.txt b/Documentation/devicetree/bindings/mfd/lubbock-io.txt >> new file mode 100644 >> index 0000000..33c9e21 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/lubbock-io.txt >> @@ -0,0 +1,26 @@ >> +Intel's pxa255 system development platform motherboard. > > s/pxa25/PXA25/ Ok. > > "system development platform motherboard" doesn't quite sit right with me. > > How about "Intel Xscale PXA255 development platform (Lubbock)"? OK. > >> +This is the motherboard, or IO board, of the pxa25x development system, >> +supporting a lubbock pxa25x SoC board. > > Again, this sounds weird. Would it sound better with : This regroups all the CPLDs on the Lubbock motherboard, providing interrupt muxing, leds handling, ... > >> +Required properties: >> + - compatible : One of the following chip-specific strings: >> + "intel,lubbock-io" > > An odd thing to say with only one entry. Right, a simple "should be" would fit better. > >> + - interrupts : The first interrupt is the line the /IRQ signal the IO board >> + multiplex is connected to. The only known case is GPIO0 on the >> + pxa25x SoC. > > Can you get someone to help you re-word this into a more fluid > sentence? Aouch, how about this : interrupts : The first interrupt is the SoC input interrupt connected to the lubbock IO board interrupt multiplexer output. The only known working configuration is GPIO0 on the pxa25x SoC. > >> +Optional properties: >> + - interrupts : The second optional interrupt is the base of the interrupts >> + multiplexed by the lubbock motherboard. If unspecified, the >> + range is fully dynamic, and the irqdomain will generate its >> + interrupt base on the fly. >> + >> +Example: >> + >> +mb: lubbock-mb@0 { >> + compatible = "intel,lubbock-io"; >> + interrupts = <0 IRQ_TYPE_EDGE_FALLING 400 IRQ_TYPE_NONE>; >> + #interrupt-cells = <2>; >> + interrupt-parent = <&pxairq>; > > Whitespace error. Right. > I'm guessing mb means motherboard? I think it's unusual for a > motherboard to have it's own driver. Usually we provide drivers for > the individual components/peripherals situated on the board. Yes, mb for motherboard. Well, this driver is actually for the CPLDs on the motherboard. Would "lubbock-cplds" be a better choice ? Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752118AbbAST3o (ORCPT ); Mon, 19 Jan 2015 14:29:44 -0500 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:18544 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751596AbbAST3n (ORCPT ); Mon, 19 Jan 2015 14:29:43 -0500 X-ME-Helo: beldin X-ME-Date: Mon, 19 Jan 2015 20:29:41 +0100 X-ME-IP: 109.222.126.211 From: Robert Jarzmik To: Lee Jones Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Daniel Mack , Haojian Zhuang , Samuel Ortiz , Arnd Bergmann , Dmitry Eremin-Solenikov , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/3] dt-bindings: mfd: add lubbock-io binding References: <1421406010-14851-1-git-send-email-robert.jarzmik@free.fr> <20150119083533.GF21886@x1> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 19 Jan 2015 20:29:40 +0100 In-Reply-To: <20150119083533.GF21886@x1> (Lee Jones's message of "Mon, 19 Jan 2015 08:35:33 +0000") Message-ID: <87lhkyh8m3.fsf@free.fr> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lee Jones writes: > On Fri, 16 Jan 2015, Robert Jarzmik wrote: > >> Add a binding for lubbock motherboard IO board. >> >> Signed-off-by: Robert Jarzmik >> --- >> .../devicetree/bindings/mfd/lubbock-io.txt | 26 ++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/lubbock-io.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/lubbock-io.txt b/Documentation/devicetree/bindings/mfd/lubbock-io.txt >> new file mode 100644 >> index 0000000..33c9e21 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/lubbock-io.txt >> @@ -0,0 +1,26 @@ >> +Intel's pxa255 system development platform motherboard. > > s/pxa25/PXA25/ Ok. > > "system development platform motherboard" doesn't quite sit right with me. > > How about "Intel Xscale PXA255 development platform (Lubbock)"? OK. > >> +This is the motherboard, or IO board, of the pxa25x development system, >> +supporting a lubbock pxa25x SoC board. > > Again, this sounds weird. Would it sound better with : This regroups all the CPLDs on the Lubbock motherboard, providing interrupt muxing, leds handling, ... > >> +Required properties: >> + - compatible : One of the following chip-specific strings: >> + "intel,lubbock-io" > > An odd thing to say with only one entry. Right, a simple "should be" would fit better. > >> + - interrupts : The first interrupt is the line the /IRQ signal the IO board >> + multiplex is connected to. The only known case is GPIO0 on the >> + pxa25x SoC. > > Can you get someone to help you re-word this into a more fluid > sentence? Aouch, how about this : interrupts : The first interrupt is the SoC input interrupt connected to the lubbock IO board interrupt multiplexer output. The only known working configuration is GPIO0 on the pxa25x SoC. > >> +Optional properties: >> + - interrupts : The second optional interrupt is the base of the interrupts >> + multiplexed by the lubbock motherboard. If unspecified, the >> + range is fully dynamic, and the irqdomain will generate its >> + interrupt base on the fly. >> + >> +Example: >> + >> +mb: lubbock-mb@0 { >> + compatible = "intel,lubbock-io"; >> + interrupts = <0 IRQ_TYPE_EDGE_FALLING 400 IRQ_TYPE_NONE>; >> + #interrupt-cells = <2>; >> + interrupt-parent = <&pxairq>; > > Whitespace error. Right. > I'm guessing mb means motherboard? I think it's unusual for a > motherboard to have it's own driver. Usually we provide drivers for > the individual components/peripherals situated on the board. Yes, mb for motherboard. Well, this driver is actually for the CPLDs on the motherboard. Would "lubbock-cplds" be a better choice ? Cheers. -- Robert