From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwAye-0004xY-Bd for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:32:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwAyY-0006g3-6s for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:32:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwAyX-0006fs-TS for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:32:18 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB3EWG6R015260 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 3 Dec 2014 09:32:17 -0500 From: Markus Armbruster References: <1417602521-14482-1-git-send-email-famz@redhat.com> <1417602521-14482-4-git-send-email-famz@redhat.com> Date: Wed, 03 Dec 2014 15:32:14 +0100 In-Reply-To: <1417602521-14482-4-git-send-email-famz@redhat.com> (Fam Zheng's message of "Wed, 3 Dec 2014 18:28:38 +0800") Message-ID: <87lhmokdn5.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v3 3/6] vmdk: Clean up descriptor file reading List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi Fam Zheng writes: > Zeroing a buffer that will be filled right after is not necessary, and > allocating a power of two + 1 is naughty. > > Suggested-by: Markus Armbruster > Signed-off-by: Fam Zheng Reviewed-by: Markus Armbruster