From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48095)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WxDLr-00029q-3U
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 06:44:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WxDLj-0002m2-Hy
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 06:44:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58360)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WxDLj-0002lv-7w
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 06:44:15 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <32593ed6bfc27fe8192677a69aa2adaa7ed9c11b.1403079139.git.amit.shah@redhat.com>
	(Amit Shah's message of "Wed, 18 Jun 2014 13:43:36 +0530")
References: <cover.1403079139.git.amit.shah@redhat.com>
	<cover.1403079139.git.amit.shah@redhat.com>
	<32593ed6bfc27fe8192677a69aa2adaa7ed9c11b.1403079139.git.amit.shah@redhat.com>
Date: Wed, 18 Jun 2014 12:44:12 +0200
Message-ID: <87lhsuijk3.fsf@troll.troll>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v4 02/18] vmstate-static-checker: script to
	validate vmstate changes
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Alexander Graf <agraf@suse.de>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>

Amit Shah <amit.shah@redhat.com> wrote:
> This script compares the vmstate dumps in JSON format as output by QEMU
> with the -dump-vmstate option.
>
> It flags various errors, like version mismatch, sections going away,
> size mismatches, etc.
>
> This script is tolerant of a few changes that do not change the on-wire
> format, like embedding a few fields within substructs.
>
> The script takes -s/--src and -d/--dest parameters, to which filenames
> are given as arguments.
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>



> +def check_fields_match(s_field, d_field):
> +    if s_field == d_field:
> +        return True
> +
> +    # Some fields changed names between qemu versions.  This list
> +    # is used to whitelist such changes.
> +    changed_names = [
> +                     ['d', 'dev', 'pcidev', 'pci_dev', 'parent_obj'],
> +                     ['card', 'parent_obj'],
> +                     ['bridge.dev', 'parent_obj'],
> +                     ['br.dev', 'parent_obj.parent_obj'],
> +                     ['port.br.dev', 'parent_obj.parent_obj.parent_obj'],
> +                     ['port.br.dev.exp.aer_log',
> +                      'parent_obj.parent_obj.parent_obj.exp.aer_log'],
> +                     ['br.dev.exp.aer_log',
> +                      'parent_obj.parent_obj.exp.aer_log'],
> +                     ['shpc', 'bridge.dev.shpc'],
> +                     ['pci0_status',
> +                      'acpi_pci_hotplug.acpi_pcihp_pci_status[0x0]'],
> +                     ['pci_irq_levels', 'pci_irq_levels_vmstate'],
> +                     ['usb-ptr-queue', 'HIDPointerEventQueue'],
> +                     ['num_surfaces', 'ssd.num_surfaces'],
> +                     ['timer', 'timer_expiry'],
> +                    ]

I expect this not to be very big, so ... could we prepend the VMState
description name on this?

"usb-ptr-queue" and "HIDPointerEventQueue" are quite descriptive, but

"d" "dev" "pci_dev" ...

I am not sure that we want to do this translation for any
VMSTateDescription.  In particular, we are ending that parent_obj can
match with anything :-()

My python is rusty (to be generous with me), so I am assuming rest of
things are idiomatic Python O:-)

Later, Juan.