From: "Bjørn Mork" <bjorn@mork.no>
To: David Miller <davem@davemloft.net>
Cc: freddy@asix.com.tw, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] AX88179_178A: Add VID:DID for Lenovo OneLinkDock Gigabit LAN
Date: Wed, 26 Feb 2014 22:14:10 +0100 [thread overview]
Message-ID: <87lhwx7f19.fsf@nemi.mork.no> (raw)
In-Reply-To: <20140226.154801.1466276966991949680.davem@davemloft.net> (David Miller's message of "Wed, 26 Feb 2014 15:48:01 -0500 (EST)")
David Miller <davem@davemloft.net> writes:
> From: Bjørn Mork <bjorn@mork.no>
> Date: Wed, 26 Feb 2014 13:13:12 +0100
>
>> freddy@asix.com.tw writes:
>>
>>> From: Freddy Xin <freddy@asix.com.tw>
>>>
>>> Add VID:DID for Lenovo OneLinkDock Gigabit LAN
>>
>> This is the same patch Keith Packard sent, but with a slighly different
>> description. I take that as another proof that we should not attempt to
>> describe devices in these drivers. Describe the driver instead.
>
> Are you saying that this patch needs to be implemented differently?
No, sorry for being confusing. The patch is fine. But Keith sent it
first...
The other comment is more of a personal opinion on the driver style. In
any case, it's something that can be fixed up later. If at all.
Bjørn
next prev parent reply other threads:[~2014-02-26 21:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 8:54 [PATCH 1/1] AX88179_178A: Add VID:DID for Lenovo OneLinkDock Gigabit LAN freddy
2014-02-26 12:13 ` Bjørn Mork
2014-02-26 20:48 ` David Miller
2014-02-26 21:14 ` Bjørn Mork [this message]
2014-02-26 21:16 ` David Miller
2014-02-26 21:44 ` Bjørn Mork
2014-02-26 22:02 ` David Miller
2014-02-26 22:23 ` Keith Packard
2014-02-26 22:37 ` Joe Perches
2014-02-26 23:04 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhwx7f19.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=freddy@asix.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.