From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36067)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1VmO3E-0007n3-VF
	for qemu-devel@nongnu.org; Fri, 29 Nov 2013 08:24:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1VmO38-0007wF-Vc
	for qemu-devel@nongnu.org; Fri, 29 Nov 2013 08:24:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56419)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1VmO38-0007w8-M2
	for qemu-devel@nongnu.org; Fri, 29 Nov 2013 08:24:02 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rATDO1u3018971
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 29 Nov 2013 08:24:01 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1385662155-15212-1-git-send-email-lersek@redhat.com>
	<1385662155-15212-2-git-send-email-lersek@redhat.com>
Date: Fri, 29 Nov 2013 14:23:57 +0100
In-Reply-To: <1385662155-15212-2-git-send-email-lersek@redhat.com> (Laszlo
	Ersek's message of "Thu, 28 Nov 2013 19:09:12 +0100")
Message-ID: <87li07mjde.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v2 1/4] i440fx-test: qtest_start() should
	be paired with qtest_end()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: qemu-devel@nongnu.org

Laszlo Ersek <lersek@redhat.com> writes:

> Similarly to commit 1d9358e6
> ("libqtest: New qtest_end() to go with qtest_start()").
>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  tests/i440fx-test.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c
> index 65c786c..6ac46bf 100644
> --- a/tests/i440fx-test.c
> +++ b/tests/i440fx-test.c
> @@ -2,9 +2,11 @@
>   * qtest I440FX test case
>   *
>   * Copyright IBM, Corp. 2012-2013
> + * Copyright Red Hat, Inc. 2013
>   *
>   * Authors:
>   *  Anthony Liguori   <aliguori@us.ibm.com>
> + *  Laszlo Ersek      <lersek@redhat.com>
>   *
>   * This work is licensed under the terms of the GNU GPL, version 2 or later.
>   * See the COPYING file in the top-level directory.
> @@ -256,7 +258,6 @@ static void test_i440fx_pam(gconstpointer opaque)
>  
>  int main(int argc, char **argv)
>  {
> -    QTestState *s;
>      TestData data;
>      char *cmdline;
>      int ret;
> @@ -266,20 +267,17 @@ int main(int argc, char **argv)
>      data.num_cpus = 1;
>  
>      cmdline = g_strdup_printf("-smp %d", data.num_cpus);
> -    s = qtest_start(cmdline);
> +    qtest_start(cmdline);
>      g_free(cmdline);
>  
>      data.bus = qpci_init_pc();
>  
>      g_test_add_data_func("/i440fx/defaults", &data, test_i440fx_defaults);
>      g_test_add_data_func("/i440fx/pam", &data, test_i440fx_pam);
> -    
>  
>      ret = g_test_run();
>  
> -    if (s) {
> -        qtest_quit(s);
> -    }
> +    qtest_end();
>  
>      return ret;
>  }

There are a few more mismatched qtest_start()..qtest_quit() pairs
elsewhere.  That's an observation, not a demand :)