From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-gg0-f180.google.com (mail-gg0-f180.google.com [209.85.161.180]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id C6F52E0172C for ; Tue, 12 Nov 2013 03:32:21 -0800 (PST) Received: by mail-gg0-f180.google.com with SMTP id l12so350265gge.11 for ; Tue, 12 Nov 2013 03:32:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=Yww8FyDmBxYowW0vPJa18L8TiPg/BZm5r5ihGX5duFo=; b=XsegHlS8TfTwgGakHYG8Zv0AqiZ/dWrtHNvFHRT284F0FE4KMMDstkgKUq7YfCvTpd 9q86lFHC7QfmAecqDrR6vb2cxkQ/3SS6ChGycTWqYqnCxS8mvmqG80A4Z64r8faWUK5l +2a5ucpoRgZu7auYiVnO7joL2Q8tXL8URuAOuW0XpIjH4W4OavBcfe35IR1uOp8or7NC iZ5EvMzQM8fF1bHuqaACOvhtYSjXPPW3QMXoM5VZWpRD15jonAjKTevwmCrfDQlSAGfs Xbvjk0N0SZeDDgSdD7rKmn4wH/Wxd4nY6QUc/XjkX+NgQmfYSF98laE6s1J6GxTEJ301 QLzw== X-Received: by 10.236.202.34 with SMTP id c22mr93104yho.135.1384255940007; Tue, 12 Nov 2013 03:32:20 -0800 (PST) Received: from parenteses.gmail.com (email.parenteses.org. [198.199.72.94]) by mx.google.com with ESMTPSA id m29sm9705175yho.14.2013.11.12.03.32.18 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 12 Nov 2013 03:32:19 -0800 (PST) Sender: Mario Domenech Goulart From: Mario Domenech Goulart To: Daiane Angolini References: <1384188262-7571-1-git-send-email-mario@ossystems.com.br> <1384188262-7571-2-git-send-email-mario@ossystems.com.br> Date: Tue, 12 Nov 2013 11:32:15 +0000 In-Reply-To: (Daiane Angolini's message of "Tue, 12 Nov 2013 09:21:26 -0200") Message-ID: <87li0t7t4w.fsf@parenteses.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Cc: "meta-freescale@yoctoproject.org" Subject: Re: [meta-fsl-arm-extra][PATCH 2/3] wandboard.inc: add X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Nov 2013 11:32:24 -0000 Content-Type: text/plain Hi Daiane, On Tue, 12 Nov 2013 09:21:26 -0200 Daiane Angolini wrote: > On Mon, Nov 11, 2013 at 2:44 PM, Mario Domenech Goulart wrote: >> Common settings for wandboard-quad, wandboard-dual and wandboard-solo. > > What? > > I like you patch, but I think you can improve this commit log/subject. I'm gonna submit the patches again, since I created them against dora by mistake. While at it, I'll improve the commit message. Best wishes. Mario > > > Daiane > >> >> Signed-off-by: Mario Domenech Goulart >> --- >> conf/machine/include/wandboard.inc | 10 ++++++++++ >> conf/machine/wandboard-dual.conf | 9 ++------- >> conf/machine/wandboard-quad.conf | 9 ++------- >> conf/machine/wandboard-solo.conf | 9 +-------- >> 4 files changed, 15 insertions(+), 22 deletions(-) >> create mode 100644 conf/machine/include/wandboard.inc >> >> diff --git a/conf/machine/include/wandboard.inc b/conf/machine/include/wandboard.inc >> new file mode 100644 >> index 0000000..a304b11 >> --- /dev/null >> +++ b/conf/machine/include/wandboard.inc >> @@ -0,0 +1,10 @@ >> +# Common settings for wandboard boards >> + >> +include conf/machine/include/imx-base.inc >> +include conf/machine/include/tune-cortexa9.inc >> + >> +PREFERRED_PROVIDER_virtual/kernel = "linux-wandboard" >> + >> +SERIAL_CONSOLE = "115200 ttymxc0" >> + >> +MACHINE_FEATURES += "pci wifi" >> diff --git a/conf/machine/wandboard-dual.conf b/conf/machine/wandboard-dual.conf >> index eaee17b..1821192 100644 >> --- a/conf/machine/wandboard-dual.conf >> +++ b/conf/machine/wandboard-dual.conf >> @@ -3,19 +3,14 @@ >> #@SOC: i.MX6DL >> #@DESCRIPTION: Machine configuration for i.MX6 Wandboard Duallite >> >> -include conf/machine/include/imx-base.inc >> -include conf/machine/include/tune-cortexa9.inc >> +include include/wandboard.inc >> >> SOC_FAMILY = "mx6:mx6dl:wandboard" >> >> -PREFERRED_PROVIDER_virtual/kernel = "linux-wandboard" >> - >> UBOOT_MACHINE = "wandboard_dl_config" >> >> KERNEL_DEVICETREE = "imx6dl-wandboard.dtb" >> >> -SERIAL_CONSOLE = "115200 ttymxc0" >> - >> -MACHINE_FEATURES += " pci wifi bluetooth" >> +MACHINE_FEATURES += "bluetooth" >> >> MACHINE_EXTRA_RRECOMMENDS += " broadcom-nvram-config" >> diff --git a/conf/machine/wandboard-quad.conf b/conf/machine/wandboard-quad.conf >> index 4f32590..195a69f 100644 >> --- a/conf/machine/wandboard-quad.conf >> +++ b/conf/machine/wandboard-quad.conf >> @@ -3,19 +3,14 @@ >> #@SOC: i.MX6Q >> #@DESCRIPTION: Machine configuration for i.MX6 Wandboard Quad >> >> -include conf/machine/include/imx-base.inc >> -include conf/machine/include/tune-cortexa9.inc >> +include include/wandboard.inc >> >> SOC_FAMILY = "mx6:mx6q:wandboard" >> >> -PREFERRED_PROVIDER_virtual/kernel = "linux-wandboard" >> - >> UBOOT_MACHINE = "wandboard_quad_config" >> >> KERNEL_DEVICETREE = "imx6q-wandboard.dtb" >> >> -SERIAL_CONSOLE = "115200 ttymxc0" >> - >> -MACHINE_FEATURES += " pci wifi bluetooth" >> +MACHINE_FEATURES += "bluetooth" >> >> MACHINE_EXTRA_RRECOMMENDS += " broadcom-nvram-config" >> diff --git a/conf/machine/wandboard-solo.conf b/conf/machine/wandboard-solo.conf >> index 970e650..9696aeb 100644 >> --- a/conf/machine/wandboard-solo.conf >> +++ b/conf/machine/wandboard-solo.conf >> @@ -3,17 +3,10 @@ >> #@SOC: i.MX6S >> #@DESCRIPTION: Machine configuration for i.MX6 Wandboard Solo >> >> -include conf/machine/include/imx-base.inc >> -include conf/machine/include/tune-cortexa9.inc >> +include include/wandboard.inc >> >> SOC_FAMILY = "mx6:mx6s:wandboard" >> >> -PREFERRED_PROVIDER_virtual/kernel = "linux-wandboard" >> - >> UBOOT_MACHINE = "wandboard_solo_config" >> >> KERNEL_DEVICETREE = "imx6dl-wandboard.dtb" >> - >> -SERIAL_CONSOLE = "115200 ttymxc0" >> - >> -MACHINE_FEATURES += " pci wifi" >> -- >> 1.7.10.4 >> >> _______________________________________________ >> meta-freescale mailing list >> meta-freescale@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/meta-freescale >