All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 1/3] perf tools: Separate lbfd check out of NO_DEMANGLE condition
Date: Wed, 02 Oct 2013 17:38:13 +0900	[thread overview]
Message-ID: <87li2cm5je.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20131002081757.GA3496@krava.brq.redhat.com> (Jiri Olsa's message of "Wed, 2 Oct 2013 10:17:57 +0200")

Hi Jiri,

On Wed, 2 Oct 2013 10:17:57 +0200, Jiri Olsa wrote:
> On Wed, Oct 02, 2013 at 10:18:32AM +0900, Namhyung Kim wrote:
>> It seems that it needs libdl for loading plugins.  Adding -ldl makes
>> above build successfully.  So we need to add -ldl for EXTLIBS IMHO.
>> Without it, make NO_GTK2=1 NO_LIBPERL=1 NO_LIBPYTHON=1 will fail to
>> check libbfd correctly (FYI, libperl and libpython add -ldl to the
>> dependency list).
>
> hum, so on my system -liberty check wins without -lbfd,
> so 'NO_GTK2=1 NO_LIBPERL=1 NO_LIBPYTHON=1' passes
>
> I need to check Ingo's latest changes on this, not sure how
> if this problem is relevant any longer ;-)

AFAICS, Ingo's patch does "-lbfd -ldl" rather than "-lbfd".  So probably
there's no problem then. :)

Thanks,
Namhyung

  reply	other threads:[~2013-10-02  8:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26 18:55 [PATCH] perf tools: Add missing -ldl for gtk build Jiri Olsa
2013-09-27  2:27 ` Namhyung Kim
2013-09-27 14:32 ` [PATCH 1/3] perf tools: Separate lbfd check out of NO_DEMANGLE condition Jiri Olsa
2013-09-27 14:32   ` [PATCH 2/3] perf tools: Adding missing ifdef for cmd_trace call Jiri Olsa
2013-09-27 14:32   ` [BUG/RFC 3/3] perf tools: Add missing GTK2_SUPPORT ifdefs Jiri Olsa
2013-09-27 18:54     ` Arnaldo Carvalho de Melo
2013-09-29  6:54       ` Namhyung Kim
2013-09-29  6:52   ` [PATCH 1/3] perf tools: Separate lbfd check out of NO_DEMANGLE condition Namhyung Kim
2013-09-30  3:13     ` Jiri Olsa
2013-10-02  1:18     ` Namhyung Kim
2013-10-02  8:17       ` Jiri Olsa
2013-10-02  8:38         ` Namhyung Kim [this message]
2013-10-02 10:08           ` Ingo Molnar
2013-10-15  5:28 ` [tip:perf/core] perf tools: Add missing -ldl for gtk build tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87li2cm5je.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.