From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UouHu-0001h8-Qn for qemu-devel@nongnu.org; Tue, 18 Jun 2013 07:41:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UouHt-00013K-Kc for qemu-devel@nongnu.org; Tue, 18 Jun 2013 07:41:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UouHt-00013F-CN for qemu-devel@nongnu.org; Tue, 18 Jun 2013 07:41:25 -0400 From: Markus Armbruster References: <1371208516-7857-1-git-send-email-armbru@redhat.com> <1371208516-7857-8-git-send-email-armbru@redhat.com> <87k3lwg62x.fsf@codemonkey.ws> Date: Tue, 18 Jun 2013 13:41:21 +0200 In-Reply-To: <87k3lwg62x.fsf@codemonkey.ws> (Anthony Liguori's message of "Fri, 14 Jun 2013 08:44:22 -0500") Message-ID: <87li67odcu.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v3 07/16] qtest: Don't reset on qtest chardev connect List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: aviksil@linux.vnet.ibm.com, alex.williamson@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, afaerber@suse.de Anthony Liguori writes: > Markus Armbruster writes: > >> libqtest's qtest_init() connecting to the qtest socket triggers reset. >> This was coded in the hope we could use the same QEMU process for >> multiple tests that way. Never used. Injects an extra reset even >> when it's not used, and that can mess up tests such as the one of >> -boot once I'm about to add. Drop it. >> >> Signed-off-by: Markus Armbruster > > We could always add a reset qtest command. Probably makes more sense really. Agree. But since I don't need it at this time... > Reviewed-by: Anthony Liguori Thanks!