From mboxrd@z Thu Jan 1 00:00:00 1970 From: arno@natisbad.org (Arnaud Ebalard) Date: Tue, 28 May 2013 10:15:04 +0000 Subject: Re: [lm-sensors] [PATCHv2 0/3] Add G762/G763 PWM fan controller Message-Id: <87li6z2yxj.fsf@natisbad.org> List-Id: References: <152190814.eApXVbVBPA@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Guenter Roeck , Andrew Lunn , Russell King - ARM Linux , Jason Cooper , linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Olivier Mouchet , Rob Herring , lm-sensors@lm-sensors.org, Grant Likely , Rob Landley , Jean Delvare , Simon Guinot Hi Arnd, Arnd Bergmann writes: > On Tuesday 28 May 2013 00:02:29 Arnaud Ebalard wrote: >> >> This series adds support for GMT G762/G763. This work is based on a >> basic version for 2.6.31 kernel developed Olivier Mouchet for LaCie >> NAS. Updates have been performed to run on recent kernels. Support has >> been completed and additional features added: ability to configure >> various characteristics from .dts file, better initialization, alarms >> and error reporting support, gear mode, polarity, fan pulse per >> revolution, fan startup voltage control. > > I wonder if this could be split into two separate drivers, one for > the pwm subsystem, and one for a hardware-independent fan controller > based on the pwm interfaces. To be honest, I wouldn't even know how to start in order to do that. Additionally, it would be worth the effort if other drivers could be easily refactored using this idea. I'll let hwmon people provide some feedback and try and comply with their directions (based on the cpu cycle I can spend on this). Cheers, a+ _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 From: arno@natisbad.org (Arnaud Ebalard) Date: Tue, 28 May 2013 12:15:04 +0200 Subject: [PATCHv2 0/3] Add G762/G763 PWM fan controller References: <152190814.eApXVbVBPA@wuerfel> Message-ID: <87li6z2yxj.fsf@natisbad.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Arnd, Arnd Bergmann writes: > On Tuesday 28 May 2013 00:02:29 Arnaud Ebalard wrote: >> >> This series adds support for GMT G762/G763. This work is based on a >> basic version for 2.6.31 kernel developed Olivier Mouchet for LaCie >> NAS. Updates have been performed to run on recent kernels. Support has >> been completed and additional features added: ability to configure >> various characteristics from .dts file, better initialization, alarms >> and error reporting support, gear mode, polarity, fan pulse per >> revolution, fan startup voltage control. > > I wonder if this could be split into two separate drivers, one for > the pwm subsystem, and one for a hardware-independent fan controller > based on the pwm interfaces. To be honest, I wouldn't even know how to start in order to do that. Additionally, it would be worth the effort if other drivers could be easily refactored using this idea. I'll let hwmon people provide some feedback and try and comply with their directions (based on the cpu cycle I can spend on this). Cheers, a+ From mboxrd@z Thu Jan 1 00:00:00 1970 From: arno@natisbad.org (Arnaud Ebalard) Subject: Re: [PATCHv2 0/3] Add G762/G763 PWM fan controller Date: Tue, 28 May 2013 12:15:04 +0200 Message-ID: <87li6z2yxj.fsf@natisbad.org> References: <152190814.eApXVbVBPA@wuerfel> Mime-Version: 1.0 Content-Type: text/plain Return-path: Sender: linux-doc-owner@vger.kernel.org To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Guenter Roeck , Andrew Lunn , Russell King - ARM Linux , Jason Cooper , linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Olivier Mouchet , Rob Herring , lm-sensors@lm-sensors.org, Grant Likely , Rob Landley , Jean Delvare , Simon Guinot List-Id: devicetree@vger.kernel.org Hi Arnd, Arnd Bergmann writes: > On Tuesday 28 May 2013 00:02:29 Arnaud Ebalard wrote: >> >> This series adds support for GMT G762/G763. This work is based on a >> basic version for 2.6.31 kernel developed Olivier Mouchet for LaCie >> NAS. Updates have been performed to run on recent kernels. Support has >> been completed and additional features added: ability to configure >> various characteristics from .dts file, better initialization, alarms >> and error reporting support, gear mode, polarity, fan pulse per >> revolution, fan startup voltage control. > > I wonder if this could be split into two separate drivers, one for > the pwm subsystem, and one for a hardware-independent fan controller > based on the pwm interfaces. To be honest, I wouldn't even know how to start in order to do that. Additionally, it would be worth the effort if other drivers could be easily refactored using this idea. I'll let hwmon people provide some feedback and try and comply with their directions (based on the cpu cycle I can spend on this). Cheers, a+