From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Sujith Manoharan <sujith@msujith.org>
Cc: Joe Perches <joe@perches.com>, <linux-wireless@vger.kernel.org>,
<ath10k-devel@qca.qualcomm.com>
Subject: Re: [PATCH 00/29] ath10k: mac80211 driver for Qualcomm Atheros qca988x devices
Date: Wed, 15 May 2013 19:22:41 +0300 [thread overview]
Message-ID: <87li7gnrfy.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <87wqr0ns47.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Wed, 15 May 2013 19:08:08 +0300")
Kalle Valo <kvalo@qca.qualcomm.com> writes:
> Sujith Manoharan <sujith@msujith.org> writes:
>
>> Joe Perches wrote:
>>> Perhaps it would be reasonable to create and use standardized
>>> logging ath_<level> functions for all the device ath<x>k_<level>s.
>>
>> Indeed.
>>
>> You already did that in "ath: Add and use ath_printk and ath_<level>" :)
>
> IIRC Sujith actually suggested this to me already earlier, but I didn't
> buy the idea even then. ath9k and ath10k are very different, so we
> cannot share all the debug levels. I just feel that it restricts and
> confuses the driver debugging too much, and all just to save something
> like 100 lines of code. I'm having hard time to see why bother.
I also noticed that ath.h doesn't support tracing. I would hate to lose
that.
--
Kalle Valo
next prev parent reply other threads:[~2013-05-15 16:22 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 14:42 [PATCH 00/29] ath10k: mac80211 driver for Qualcomm Atheros qca988x devices Kalle Valo
2013-05-15 14:42 ` [PATCH 01/29] ath10k: add bmi.c Kalle Valo
2013-05-15 14:42 ` [PATCH 02/29] ath10k: add bmi.h Kalle Valo
2013-05-15 15:01 ` Johannes Berg
2013-05-15 15:17 ` Kalle Valo
2013-05-15 14:43 ` [PATCH 03/29] ath10k: add ce.c Kalle Valo
2013-05-15 14:43 ` [PATCH 04/29] ath10k: add ce.h Kalle Valo
2013-05-15 14:43 ` [PATCH 05/29] ath10k: add core.c Kalle Valo
2013-05-15 14:43 ` [PATCH 06/29] ath10k: add core.h Kalle Valo
2013-05-15 14:43 ` [PATCH 07/29] ath10k: add debug.c Kalle Valo
2013-05-15 14:43 ` [PATCH 08/29] ath10k: add debug.h Kalle Valo
2013-05-15 14:43 ` [PATCH 09/29] ath10k: add hif.h Kalle Valo
2013-05-15 14:44 ` [PATCH 10/29] ath10k: add htc.c Kalle Valo
2013-05-15 14:44 ` [PATCH 11/29] ath10k: add htc.h Kalle Valo
2013-05-15 14:44 ` [PATCH 12/29] ath10k: add htt.c Kalle Valo
2013-05-15 14:44 ` [PATCH 13/29] ath10k: add htt.h Kalle Valo
2013-05-15 14:44 ` [PATCH 14/29] ath10k: add htt_rx.c Kalle Valo
2013-05-15 14:44 ` [PATCH 15/29] ath10k: add htt_tx.c Kalle Valo
2013-05-15 14:45 ` [PATCH 16/29] ath10k: add hw.h Kalle Valo
2013-05-15 14:45 ` [PATCH 17/29] ath10k: add mac.c Kalle Valo
2013-05-15 14:45 ` [PATCH 18/29] ath10k: add mac.h Kalle Valo
2013-05-15 14:45 ` [PATCH 19/29] ath10k: add pci.c Kalle Valo
2013-05-15 14:45 ` [PATCH 20/29] ath10k: add pci.h Kalle Valo
2013-05-15 14:45 ` [PATCH 21/29] ath10k: add rx_desc.h Kalle Valo
2013-05-15 14:45 ` [PATCH 22/29] ath10k: add targaddrs.h Kalle Valo
2013-05-15 14:46 ` [PATCH 23/29] ath10k: add trace.c Kalle Valo
2013-05-15 14:46 ` [PATCH 24/29] ath10k: add trace.h Kalle Valo
2013-05-15 14:46 ` [PATCH 25/29] ath10k: add txrx.c Kalle Valo
2013-05-15 14:46 ` [PATCH 26/29] ath10k: add txrx.h Kalle Valo
2013-05-15 14:46 ` [PATCH 27/29] ath10k: add wmi.c Kalle Valo
2013-05-15 14:46 ` [PATCH 28/29] ath10k: add wmi.h Kalle Valo
2013-05-15 14:46 ` [PATCH 29/29] ath10k: add Kconfig and Makefile Kalle Valo
2013-05-15 15:52 ` [PATCH 00/29] ath10k: mac80211 driver for Qualcomm Atheros qca988x devices Joe Perches
2013-05-15 15:54 ` Sujith Manoharan
2013-05-15 16:08 ` Kalle Valo
2013-05-15 16:22 ` Kalle Valo [this message]
[not found] ` <1368639816.2194.9.camel@joe-AO722>
[not found] ` <8761yknn7i.fsf@kamboji.qca.qualcomm.com>
2013-05-16 7:03 ` [ath9k-devel] [PATCH 1/2] ath10k: Convert ath10k_dbg uses Joe Perches
2013-05-16 8:25 ` Michal Kazior
2013-05-20 7:12 ` Kalle Valo
2013-05-20 16:01 ` Joe Perches
2013-05-20 18:43 ` Kalle Valo
2013-05-16 7:05 ` [ath9k-devel] [PATCH 2/2] ath10k: Neaten ath10k_<level> uses Joe Perches
2013-06-01 9:19 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li7gnrfy.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k-devel@qca.qualcomm.com \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.