From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Thu, 9 May 2013 11:31:43 +0300 Subject: [ath9k-devel] [PATCH 1/3] ath10k: WMI add AP PS In-Reply-To: <3078A9B976EF864C8DDD0C499FFD07913139B7B8B4@EXMB01.eu.tieto.com> (Janusz Dziedzic's message of "Thu, 9 May 2013 10:35:26 +0300") References: <1367999363-20424-1-git-send-email-janusz.dziedzic@tieto.com> <1367999363-20424-2-git-send-email-janusz.dziedzic@tieto.com> <87bo8ky6hg.fsf@kamboji.qca.qualcomm.com> <3078A9B976EF864C8DDD0C499FFD07913139B7B8B4@EXMB01.eu.tieto.com> Message-ID: <87li7owo40.fsf@kamboji.qca.qualcomm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org writes: >>-----Original Message----- >>From: Kalle Valo [mailto:kvalo at qca.qualcomm.com] >>Sent: 9 maja 2013 09:10 >>To: Dziedzic Janusz >>Cc: ath9k-devel at lists.ath9k.org >>Subject: Re: [ath9k-devel] [PATCH 1/3] ath10k: WMI add AP PS >> >>Janusz Dziedzic writes: >> >>> Add AP power save (UAPSD) structures, enums. >>> >>> Signed-off-by: Janusz Dziedzic >> >>[...] >> >>> + cmd->vdev_id = __cpu_to_le32(vdev_id); >>> + cmd->param_id = __cpu_to_le32(param_id); >>> + cmd->param_value = __cpu_to_le32(value); >> >>Remove the extra whitespace before '='. >> > > I did same style we have in wmi.c In other functions, Yeah, I know. But I would prefer not to use that style in ath10k. I have been trying to remove that style from ath10k, but I haven't converted all cases yet. > Eg. (ath10k_wmi_set_psmode) > cmd->vdev_id = __cpu_to_le32(vdev_id); > cmd->sta_ps_mode = __cpu_to_le32(psmode); > > So, should I change this? I'm happy to take patches :) -- Kalle Valo