From mboxrd@z Thu Jan 1 00:00:00 1970 From: arno@natisbad.org (Arnaud Ebalard) Date: Wed, 24 Apr 2013 20:28:47 +0000 Subject: Re: [lm-sensors] [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan controller Message-Id: <87li878ygw.fsf@natisbad.org> List-Id: References: <63961d39aee9db94767f28fd441312bec2029473.1366753420.git.arno@natisbad.org> <20130424053758.GC8710@lunn.ch> <87obd4wb4e.fsf@natisbad.org> <20130424133856.GA18851@roeck-us.net> In-Reply-To: <20130424133856.GA18851@roeck-us.net> (Guenter Roeck's message of "Wed, 24 Apr 2013 06:38:56 -0700") MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: Guenter Roeck Cc: Andrew Lunn , Russell King - ARM Linux , Jason Cooper , linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Olivier Mouchet , Rob Herring , lm-sensors@lm-sensors.org, Grant Likely , Rob Landley , Jean Delvare , Linux ARM Kernel Mailing List , Simon Guinot Hi, Guenter Roeck writes: >> > You could consider using regmap for holding this cache. >> > >> > http://elceurope2012.sched.org/event/100619b669ce5767341624253aa03659?= iframe=3Dno&w=900&sidebar=3Dyes&bg=3Dno#.UXdspHLQ5jM >> > >> > http://elinux.org/ELCE_Europe_2012_Presentations >>=20 >> Interesting. As I am not yet familiar w/ regmap I would prefer having >> the driver accepted during merge window with current data structure and >> then convert it to regmap. But I will take a look (e.g. will study >> fca1dd03 for instance). Thanks for the pointers.=20 >>=20 > I have not had time for a detailed review, but adding regmap support > will not be a requirement. > > Note that it is too late for 3.10, so the driver will have to wait for > 3.11. Well, I think I can live with it; The only bad thing is that it kills my excuses not to spend time on regmap ;-) >> >> +/* >> >> + * Helpers to import hardware characteristics from .dts file and ove= rload >> >> + * default config values. >> >> + */ >> >> + >> >> +#ifdef CONFIG_OF >> > >> > Can the driver be used without device tree? Would it be simpler to >> > just add depends OF in the Kconfig entry? >>=20 >> It can be used if the default params (or those configured by u-boot I >> guess) fit your needs. I think it would be fairly easy to extend the >> driver later to expose g762_config struct to allow parameters to be set >> w/o using OF. If someone wants to do that, I think it is better to not >> depend on OF in Kconfig at the moment but I have not strong argument >> other that that one. I'll let you decide. >>=20 > Agreed. As long as there are major platforms not supporting device tree, > and as long as device tree overlays are not supported, it must not be made > mandatory. Especially for I2C and SPI devices I reserve the right to be a= ble > test the hardware on an X86 system and not require a reboot to do so. Understood. Following Simon's post, I think it's useful to implement some init function for non DT-enabled platforms.=20 a+ _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 From: arno@natisbad.org (Arnaud Ebalard) Date: Wed, 24 Apr 2013 22:28:47 +0200 Subject: [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan controller In-Reply-To: <20130424133856.GA18851@roeck-us.net> (Guenter Roeck's message of "Wed, 24 Apr 2013 06:38:56 -0700") References: <63961d39aee9db94767f28fd441312bec2029473.1366753420.git.arno@natisbad.org> <20130424053758.GC8710@lunn.ch> <87obd4wb4e.fsf@natisbad.org> <20130424133856.GA18851@roeck-us.net> Message-ID: <87li878ygw.fsf@natisbad.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Guenter Roeck writes: >> > You could consider using regmap for holding this cache. >> > >> > http://elceurope2012.sched.org/event/100619b669ce5767341624253aa03659?iframe=no&w=900&sidebar=yes&bg=no#.UXdspHLQ5jM >> > >> > http://elinux.org/ELCE_Europe_2012_Presentations >> >> Interesting. As I am not yet familiar w/ regmap I would prefer having >> the driver accepted during merge window with current data structure and >> then convert it to regmap. But I will take a look (e.g. will study >> fca1dd03 for instance). Thanks for the pointers. >> > I have not had time for a detailed review, but adding regmap support > will not be a requirement. > > Note that it is too late for 3.10, so the driver will have to wait for > 3.11. Well, I think I can live with it; The only bad thing is that it kills my excuses not to spend time on regmap ;-) >> >> +/* >> >> + * Helpers to import hardware characteristics from .dts file and overload >> >> + * default config values. >> >> + */ >> >> + >> >> +#ifdef CONFIG_OF >> > >> > Can the driver be used without device tree? Would it be simpler to >> > just add depends OF in the Kconfig entry? >> >> It can be used if the default params (or those configured by u-boot I >> guess) fit your needs. I think it would be fairly easy to extend the >> driver later to expose g762_config struct to allow parameters to be set >> w/o using OF. If someone wants to do that, I think it is better to not >> depend on OF in Kconfig at the moment but I have not strong argument >> other that that one. I'll let you decide. >> > Agreed. As long as there are major platforms not supporting device tree, > and as long as device tree overlays are not supported, it must not be made > mandatory. Especially for I2C and SPI devices I reserve the right to be able > test the hardware on an X86 system and not require a reboot to do so. Understood. Following Simon's post, I think it's useful to implement some init function for non DT-enabled platforms. a+ From mboxrd@z Thu Jan 1 00:00:00 1970 From: arno@natisbad.org (Arnaud Ebalard) Subject: Re: [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan controller Date: Wed, 24 Apr 2013 22:28:47 +0200 Message-ID: <87li878ygw.fsf@natisbad.org> References: <63961d39aee9db94767f28fd441312bec2029473.1366753420.git.arno@natisbad.org> <20130424053758.GC8710@lunn.ch> <87obd4wb4e.fsf@natisbad.org> <20130424133856.GA18851@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130424133856.GA18851@roeck-us.net> (Guenter Roeck's message of "Wed, 24 Apr 2013 06:38:56 -0700") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Guenter Roeck Cc: Andrew Lunn , Russell King - ARM Linux , Jason Cooper , linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Olivier Mouchet , Rob Herring , lm-sensors@lm-sensors.org, Grant Likely , Rob Landley , Jean Delvare , Linux ARM Kernel Mailing List , Simon Guinot List-Id: devicetree@vger.kernel.org Hi, Guenter Roeck writes: >> > You could consider using regmap for holding this cache. >> > >> > http://elceurope2012.sched.org/event/100619b669ce5767341624253aa03659?iframe=no&w=900&sidebar=yes&bg=no#.UXdspHLQ5jM >> > >> > http://elinux.org/ELCE_Europe_2012_Presentations >> >> Interesting. As I am not yet familiar w/ regmap I would prefer having >> the driver accepted during merge window with current data structure and >> then convert it to regmap. But I will take a look (e.g. will study >> fca1dd03 for instance). Thanks for the pointers. >> > I have not had time for a detailed review, but adding regmap support > will not be a requirement. > > Note that it is too late for 3.10, so the driver will have to wait for > 3.11. Well, I think I can live with it; The only bad thing is that it kills my excuses not to spend time on regmap ;-) >> >> +/* >> >> + * Helpers to import hardware characteristics from .dts file and overload >> >> + * default config values. >> >> + */ >> >> + >> >> +#ifdef CONFIG_OF >> > >> > Can the driver be used without device tree? Would it be simpler to >> > just add depends OF in the Kconfig entry? >> >> It can be used if the default params (or those configured by u-boot I >> guess) fit your needs. I think it would be fairly easy to extend the >> driver later to expose g762_config struct to allow parameters to be set >> w/o using OF. If someone wants to do that, I think it is better to not >> depend on OF in Kconfig at the moment but I have not strong argument >> other that that one. I'll let you decide. >> > Agreed. As long as there are major platforms not supporting device tree, > and as long as device tree overlays are not supported, it must not be made > mandatory. Especially for I2C and SPI devices I reserve the right to be able > test the hardware on an X86 system and not require a reboot to do so. Understood. Following Simon's post, I think it's useful to implement some init function for non DT-enabled platforms. a+