From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPU88-0000lo-Ji for qemu-devel@nongnu.org; Tue, 09 Apr 2013 04:42:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPU87-0006zO-Hi for qemu-devel@nongnu.org; Tue, 09 Apr 2013 04:42:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10384) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPU87-0006zA-A4 for qemu-devel@nongnu.org; Tue, 09 Apr 2013 04:42:15 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r398gD84012230 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 9 Apr 2013 04:42:14 -0400 From: Markus Armbruster References: <1365103395-11547-1-git-send-email-pbonzini@redhat.com> <1365103395-11547-3-git-send-email-pbonzini@redhat.com> Date: Tue, 09 Apr 2013 10:35:25 +0200 In-Reply-To: <1365103395-11547-3-git-send-email-pbonzini@redhat.com> (Paolo Bonzini's message of "Thu, 4 Apr 2013 21:22:42 +0200") Message-ID: <87li8snlte.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 02/35] hw: move headers to include/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Paolo Bonzini writes: > Many of these should be cleaned up with proper qdev-/QOM-ification. > Right now there are many catch-all headers in include/hw/ARCH depending > on cpu.h, and this makes it necessary to compile these files per-target. > However, fixing this does not belong in these patches. Breaks the build for me: hw/9pfs/virtio-9p-device.h moved to include/hw/virtio/virtio-9p.h, but hw/9pfs/virtio-9p-device.c's #include not updated.