All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] New package: cache-calibrator
Date: Tue, 29 Jan 2013 21:33:52 +0100	[thread overview]
Message-ID: <87libbd8zz.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1359453232-23310-1-git-send-email-sho@relinux.de> (Stephan Hoffmann's message of "Tue, 29 Jan 2013 10:53:52 +0100")

>>>>> "Stephan" == Stephan Hoffmann <sho@relinux.de> writes:

 Stephan> The Calibrator is a small C program that is supposed to analyze
 Stephan> a computers (cache-) memory system and extract the following
 Stephan> parameters:

 Stephan>     number of cache levels
 Stephan>     for each cache level:
 Stephan>         its size
 Stephan>         its linesize
 Stephan>         its access/miss latency
 Stephan>     main memory access latency
 Stephan>     number of TLB levels
 Stephan>     for each TLB level:
 Stephan>         its capacity (i.e. number of entries)
 Stephan>         the pagesize used
 Stephan>         the TLB miss latency

 Stephan> http://homepages.cwi.nl/~manegold/Calibrator/

 Stephan> It is also recommended as a load generator for realtime testing in:

 Stephan> https://rt.wiki.kernel.org/index.php/RT_PREEMPT_HOWTO#Benchmarking

 Stephan> Signed-off-by: Stephan Hoffmann <sho@relinux.de>
 Stephan> ---
 Stephan> v2: Review by Arnout Vandecappelle
 Stephan> 	Fix License
 Stephan> 	Use $(TARGET_CFLAGS) and $(TARGET_LDFLAGS)
 Stephan> 	Fix Typo
 Stephan> 	Remove $(CACHE_CALIBRATOR_DIR) 
 Stephan> v3: Review by Thomas Petazzoni
 Stephan> 	Fix CACHE_CALIBRATOR_EXTRACT_CMDS

 Stephan> @@ -0,0 +1,13 @@
 Stephan> +config BR2_PACKAGE_CACHE_CALIBRATOR
 Stephan> +	bool "cache-calibrator"
 Stephan> +	help
 Stephan> +	  Cache calibrator is a small C program that is
 Stephan> +	  supposed to analyze a computers (cache-) memory
 Stephan> +	  system and extract useful information
 Stephan> +
 Stephan> +	  http://homepages.cwi.nl/~manegold/Calibrator/
 Stephan> +
 Stephan> +	  It is also recommended as a load generator for
 Stephan> +	  realtime testing in:

We normally wrap help text around col 70, not 50. I've reformatted this
to better fit menuconfig.


 Stephan> +++ b/package/cache-calibrator/cache-calibrator.mk
 Stephan> @@ -0,0 +1,24 @@
 Stephan> +#############################################################
 Stephan> +#
 Stephan> +# cache-calibrator
 Stephan> +#
 Stephan> +#############################################################
 Stephan> +
 Stephan> +CACHE_CALIBRATOR_SOURCE = calibrator.c
 Stephan> +CACHE_CALIBRATOR_SITE = http://homepages.cwi.nl/~manegold/Calibrator/src
 Stephan> +CACHE_CALIBRATOR_LICENSE = Cache calibrator license
 Stephan> +CACHE_CALIBRATOR_LICENSE_FILES = calibrator.c
 Stephan> +
 Stephan> +define CACHE_CALIBRATOR_EXTRACT_CMDS
 Stephan> +	cp $(DL_DIR)/$(CACHE_CALIBRATOR_SOURCE) $(D)

Did you test this? It is $(@D) not $(D) (which expands to the empty
string)

Committed with these fixes, thanks.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2013-01-29 20:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-29  8:31 [Buildroot] [PATCH] New package: cache-calibrator Stephan Hoffmann
2013-01-29  8:52 ` Thomas Petazzoni
2013-01-29  9:07 ` Peter Korsgaard
2013-01-29  9:15 ` Stephan Hoffmann
2013-01-29  9:21   ` Stephan Hoffmann
2013-01-29  9:25     ` Peter Korsgaard
2013-01-29  9:36     ` Thomas Petazzoni
2013-01-29  9:53 ` [Buildroot] [PATCH v3] " Stephan Hoffmann
2013-01-29 17:47   ` Arnout Vandecappelle
2013-01-29 20:33   ` Peter Korsgaard [this message]
2013-01-30  7:51     ` Stephan Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87libbd8zz.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.