From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH -V2 1/9] mm: move hugetlbfs region tracking function to common code Date: Sun, 04 Mar 2012 23:07:50 +0530 Message-ID: <87linge07l.fsf@linux.vnet.ibm.com> References: <1330593380-1361-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1330593380-1361-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20120301143345.7e928efe.akpm@linux-foundation.org> Mime-Version: 1.0 Return-path: In-Reply-To: <20120301143345.7e928efe.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, mgorman-l3A5Bk7waGM@public.gmane.org, kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org, dhillf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, mhocko-AlSwsSmVLrQ@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrea Righi , John Stultz On Thu, 1 Mar 2012 14:33:45 -0800, Andrew Morton wrote: > On Thu, 1 Mar 2012 14:46:12 +0530 > "Aneesh Kumar K.V" wrote: > > > This patch moves the hugetlbfs region tracking function to > > common code. We will be using this in later patches in the > > series. > > > > ... > > > > +struct file_region { > > + struct list_head link; > > + long from; > > + long to; > > +}; > > Both Andrea Righi and John Stultz are working on (more sophisticated) > versions of file region tracking code. And we already have a (poor) > implementation in fs/locks.c. > > That's four versions of the same thing floating around the place. This > is nutty. We should be able to remove region.c once other alternatives are in upstream. I will also look at the alternatives and see if it would need any change to make it usable for this work. Thanks, -aneesh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx126.postini.com [74.125.245.126]) by kanga.kvack.org (Postfix) with SMTP id A92EB6B00E8 for ; Sun, 4 Mar 2012 12:38:54 -0500 (EST) Received: from /spool/local by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 4 Mar 2012 17:34:55 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q24Hc4Jr934086 for ; Mon, 5 Mar 2012 04:38:12 +1100 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q24Hc4cU026709 for ; Mon, 5 Mar 2012 04:38:04 +1100 From: "Aneesh Kumar K.V" Subject: Re: [PATCH -V2 1/9] mm: move hugetlbfs region tracking function to common code In-Reply-To: <20120301143345.7e928efe.akpm@linux-foundation.org> References: <1330593380-1361-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1330593380-1361-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20120301143345.7e928efe.akpm@linux-foundation.org> Date: Sun, 04 Mar 2012 23:07:50 +0530 Message-ID: <87linge07l.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: linux-mm@kvack.org, mgorman@suse.de, kamezawa.hiroyu@jp.fujitsu.com, dhillf@gmail.com, aarcange@redhat.com, mhocko@suse.cz, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Andrea Righi , John Stultz On Thu, 1 Mar 2012 14:33:45 -0800, Andrew Morton wrote: > On Thu, 1 Mar 2012 14:46:12 +0530 > "Aneesh Kumar K.V" wrote: > > > This patch moves the hugetlbfs region tracking function to > > common code. We will be using this in later patches in the > > series. > > > > ... > > > > +struct file_region { > > + struct list_head link; > > + long from; > > + long to; > > +}; > > Both Andrea Righi and John Stultz are working on (more sophisticated) > versions of file region tracking code. And we already have a (poor) > implementation in fs/locks.c. > > That's four versions of the same thing floating around the place. This > is nutty. We should be able to remove region.c once other alternatives are in upstream. I will also look at the alternatives and see if it would need any change to make it usable for this work. Thanks, -aneesh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754585Ab2CDRi3 (ORCPT ); Sun, 4 Mar 2012 12:38:29 -0500 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:44317 "EHLO e23smtp07.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754457Ab2CDRi1 (ORCPT ); Sun, 4 Mar 2012 12:38:27 -0500 From: "Aneesh Kumar K.V" To: Andrew Morton Cc: linux-mm@kvack.org, mgorman@suse.de, kamezawa.hiroyu@jp.fujitsu.com, dhillf@gmail.com, aarcange@redhat.com, mhocko@suse.cz, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Andrea Righi , John Stultz Subject: Re: [PATCH -V2 1/9] mm: move hugetlbfs region tracking function to common code In-Reply-To: <20120301143345.7e928efe.akpm@linux-foundation.org> References: <1330593380-1361-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1330593380-1361-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20120301143345.7e928efe.akpm@linux-foundation.org> User-Agent: Notmuch/0.11.1+190~g31a336a (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sun, 04 Mar 2012 23:07:50 +0530 Message-ID: <87linge07l.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii x-cbid: 12030407-0260-0000-0000-000000A4AFD1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Mar 2012 14:33:45 -0800, Andrew Morton wrote: > On Thu, 1 Mar 2012 14:46:12 +0530 > "Aneesh Kumar K.V" wrote: > > > This patch moves the hugetlbfs region tracking function to > > common code. We will be using this in later patches in the > > series. > > > > ... > > > > +struct file_region { > > + struct list_head link; > > + long from; > > + long to; > > +}; > > Both Andrea Righi and John Stultz are working on (more sophisticated) > versions of file region tracking code. And we already have a (poor) > implementation in fs/locks.c. > > That's four versions of the same thing floating around the place. This > is nutty. We should be able to remove region.c once other alternatives are in upstream. I will also look at the alternatives and see if it would need any change to make it usable for this work. Thanks, -aneesh