From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v8 16/24] gpio/omap: use pm-runtime framework Date: Fri, 04 Nov 2011 10:13:29 -0700 Message-ID: <87lirvbykm.fsf@ti.com> References: <1317803593-12259-1-git-send-email-tarun.kanti@ti.com> <1317803593-12259-17-git-send-email-tarun.kanti@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog107.obsmtp.com ([74.125.149.197]:47734 "EHLO na3sys009aog107.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751219Ab1KDRNj (ORCPT ); Fri, 4 Nov 2011 13:13:39 -0400 Received: by mail-qw0-f41.google.com with SMTP id c11so2889675qad.0 for ; Fri, 04 Nov 2011 10:13:38 -0700 (PDT) In-Reply-To: <1317803593-12259-17-git-send-email-tarun.kanti@ti.com> (Tarun Kanti DebBarma's message of "Wed, 5 Oct 2011 14:03:05 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tarun Kanti DebBarma Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tony Lindgren , Charulatha V Tarun Kanti DebBarma writes: > Call runtime pm APIs pm_runtime_get_sync() and pm_runtime_put_sync() > for enabling/disabling clocks appropriately. Remove syscore_ops and > instead use SET_RUNTIME_PM_OPS macro. > > Signed-off-by: Charulatha V > Signed-off-by: Tarun Kanti DebBarma > Reviewed-by: Santosh Shilimkar > --- > arch/arm/mach-omap2/gpio.c | 2 - > drivers/gpio/gpio-omap.c | 67 +++++++++++++++++++++++++++++--------------- > 2 files changed, 44 insertions(+), 25 deletions(-) > > diff --git a/arch/arm/mach-omap2/gpio.c b/arch/arm/mach-omap2/gpio.c > index 5ae1cf3..a992802 100644 > --- a/arch/arm/mach-omap2/gpio.c > +++ b/arch/arm/mach-omap2/gpio.c > @@ -146,8 +146,6 @@ static int omap2_gpio_dev_init(struct omap_hwmod *oh, void *unused) > return PTR_ERR(od); > } > > - omap_device_disable_idle_on_suspend(od); > - No description in the changelog about this change. (Yes, I understand why it's removed, but it needs to be described in the changelog so when I forget, I'll have a way to remember.) Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Fri, 04 Nov 2011 10:13:29 -0700 Subject: [PATCH v8 16/24] gpio/omap: use pm-runtime framework In-Reply-To: <1317803593-12259-17-git-send-email-tarun.kanti@ti.com> (Tarun Kanti DebBarma's message of "Wed, 5 Oct 2011 14:03:05 +0530") References: <1317803593-12259-1-git-send-email-tarun.kanti@ti.com> <1317803593-12259-17-git-send-email-tarun.kanti@ti.com> Message-ID: <87lirvbykm.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Tarun Kanti DebBarma writes: > Call runtime pm APIs pm_runtime_get_sync() and pm_runtime_put_sync() > for enabling/disabling clocks appropriately. Remove syscore_ops and > instead use SET_RUNTIME_PM_OPS macro. > > Signed-off-by: Charulatha V > Signed-off-by: Tarun Kanti DebBarma > Reviewed-by: Santosh Shilimkar > --- > arch/arm/mach-omap2/gpio.c | 2 - > drivers/gpio/gpio-omap.c | 67 +++++++++++++++++++++++++++++--------------- > 2 files changed, 44 insertions(+), 25 deletions(-) > > diff --git a/arch/arm/mach-omap2/gpio.c b/arch/arm/mach-omap2/gpio.c > index 5ae1cf3..a992802 100644 > --- a/arch/arm/mach-omap2/gpio.c > +++ b/arch/arm/mach-omap2/gpio.c > @@ -146,8 +146,6 @@ static int omap2_gpio_dev_init(struct omap_hwmod *oh, void *unused) > return PTR_ERR(od); > } > > - omap_device_disable_idle_on_suspend(od); > - No description in the changelog about this change. (Yes, I understand why it's removed, but it needs to be described in the changelog so when I forget, I'll have a way to remember.) Kevin