All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] cifs-utils: new package
Date: Mon, 26 Sep 2011 22:36:46 +0200	[thread overview]
Message-ID: <87litbvy5d.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <515aeaac2f96b302ad89abf28796ab86f1b940d7.1316468572.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Mon, 19 Sep 2011 23:42:57 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thanks, committed with minor fixes (see below):

 Thomas> new file mode 100644
 Thomas> index 0000000..861aaeb
 Thomas> --- /dev/null
 Thomas> +++ b/package/cifs-utils/Config.in
 Thomas> @@ -0,0 +1,13 @@
 Thomas> +config BR2_PACKAGE_CIFS_UTILS
 Thomas> +        bool "cifs-utils"

Wrong indentation.

 Thomas> +	help
 Thomas> +	  The in-kernel CIFS filesystem is generally the preferred
 Thomas> +	  method for mounting SMB/CIFS shares on Linux. The in-kernel
 Thomas> +	  CIFS filesystem relies on a set of user-space tools. That
 Thomas> +	  package of tools is called cifs-utils. Although not really
 Thomas> +	  part of Samba proper, these tools were originally part of
 Thomas> +	  the Samba package. For several reasons, shipping these tools
 Thomas> +	  as part of Samba was problematic and it was deemed better to
 Thomas> +	  split them off into their own package.
 Thomas> +
 Thomas> +	  http://wiki.samba.org/index.php/LinuxCIFS_utils
 Thomas> \ No newline at end of file

..

 Thomas> diff --git a/package/cifs-utils/cifs-utils.mk b/package/cifs-utils/cifs-utils.mk
 Thomas> +$(eval $(call AUTOTARGETS,package,cifs-utils))
 Thomas> \ No newline at end of file

You forgot the newlines again ;)

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2011-09-26 20:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-19 21:42 [Buildroot] [pull request] Pull request for branch for-2011.11/cifs-utils Thomas Petazzoni
2011-09-19 21:42 ` [Buildroot] [PATCH 1/1] cifs-utils: new package Thomas Petazzoni
2011-09-26 20:36   ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87litbvy5d.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.